>Number: 178634 >Category: ports >Synopsis: [patch] net-mgmt/collectd5: add LIB_DEPENDS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue May 14 16:40:05 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Boris Samorodov >Release: FreeBSD 9-i386 >Organization: BSDprint >Environment: FreeBSD srv.bb.tel.ru 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #7 r243514: Sun Nov 25 20:10:07 SAMT 2012 bsam@srv.bb.tel.ru:/usr/obj/usr/src/sys/BB i386 >Description: add libnotify to LIB_DEPENDS (which is needed for world as per configure.log); bump PORTREVISION. Here is the relevant part from the configure.log: ----- Configuration: Libraries: [...] libnotify . . . . . . no (Package libnotify was not found in the pkg-config search path. Perhaps you should add the directory containing `libnotify.pc' to the PKG_CONFIG_PATH environment variable Package 'libnotify', required by 'world', not found) ----- PS. Please, keep in mind that I'll submit several PRs on the port as I treat those changes differently. This one imho right but I'm not sure. The maintainer should know better. >How-To-Repeat: Try to build the port at a vanilla system and lok at the configure.log. >Fix: Index: Makefile =================================================================== --- Makefile (revision 317544) +++ Makefile (working copy) @@ -2,13 +2,15 @@ # $FreeBSD$ PORTNAME= collectd PORTVERSION= 5.2.1 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= net-mgmt MASTER_SITES= http://collectd.org/files/ MAINTAINER= ports@bsdserwis.com COMMENT= Systems & network statistics collection daemon +LIB_DEPENDS= notify:${PORTSDIR}/devel/libnotify + USE_BZIP2= yes USE_GMAKE= yes GNU_CONFIGURE= yes >Release-Note: >Audit-Trail: >Unformatted: _______________________________________________ freebsd-ports-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
. add libnotify to LIB_DEPENDS (which is needed for world as per configure.log); . bump PORTREVISION. Here is the relevant part from the configure.log: ----- Configuration: Libraries: [...] libnotify . . . . . . no (Package libnotify was not found in the pkg-config search path. Perhaps you should add the directory containing `libnotify.pc' to the PKG_CONFIG_PATH environment variable Package 'libnotify', required by 'world', not found) ----- PS. Please, keep in mind that I'll submit several PRs on the port as I treat those changes differently. This one imho right but I'm not sure. The maintainer should know better. Fix: Patch attached with submission follows: How-To-Repeat: Try to build the port at a vanilla system and lok at the configure.log.
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Maintainer of net-mgmt/collectd5, Please note that PR ports/178634 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178634 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
Responsible Changed From-To: freebsd-ports-bugs->bsam Take.
Hello, On Tue, May 14, 2013 at 04:40:12PM +0000, Edwin Groothuis wrote: > Maintainer of net-mgmt/collectd5, > > Please note that PR ports/178634 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178634 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org > I approve this patch. Greetings, -- Krzysztof Stryjek UNIX administrator/Juniper Networks Specialist email: wtp (at) bsdserwis (dot) com http://www.linkedin.com/in/KrzysztofStryjek GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C 91CD 1292 8959 DC61 0E76 In theory, there is no difference between theory and practice. In practice, there is.
State Changed From-To: feedback->closed Committed, thanks! ;-)