The addition of libnotify to LIB_DEPENDS in net-mgmt/collectd5 means net-mgmt/collectd5 no longer builds on systems that have WITHOUT_X11 defined in /etc/make.conf. The LIB_DEPENDS change causes a new dependency to be added, graphics/gtk-update-icon-cache, which refuses to build if cairo does not have X11 support. This is a regression since collectd has always worked fine without libnotify and X11. It should not be a mandatory dependency. Fix: Revert last commit to net-mgmt/collectd5 (remove libnotify from LIB_DEPENDS) How-To-Repeat: Define WITHOUT_X11=yes in /etc/make.conf Try to build net-mgmt/collectd5 on a clean system
Maintainer of net-mgmt/collectd5, Please note that PR ports/178697 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178697 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hello, On Thu, May 16, 2013 at 11:00:07PM +0000, Edwin Groothuis wrote: > Maintainer of net-mgmt/collectd5, > > Please note that PR ports/178697 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178697 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org > Yes, my fault - I don't check very careful last PR. I've made a patch for Makefile that will be much better for collectd5 and email notification. Greetings, -- Krzysztof Stryjek UNIX administrator/Juniper Networks Specialist email: wtp (at) bsdserwis (dot) com http://www.linkedin.com/in/KrzysztofStryjek GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C 91CD 1292 8959 DC61 0E76 In theory, there is no difference between theory and practice. In practice, there is.
State Changed From-To: feedback->open maintainer has replied with patch to fix the problem.
CC'ing bsam since he added the dependency in r318238. Additionally, doesn't the patch in this PR also apply to net-mgmt/collectd?
19.05.2013 02:12, Raphael Kubo da Costa пиÑеÑ: > CC'ing bsam since he added the dependency in r318238. The dependency was added because the there is a message at the log that libnotify is needed. If it may be used as an option -- well, that's good. Nevertheless, it smells like a bug if libnotify unconditionally depends upon X11. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Responsible Changed From-To: freebsd-ports-bugs->bsam Take.
Author: bsam Date: Mon May 20 06:14:09 2013 New Revision: 318574 URL: http://svnweb.freebsd.org/changeset/ports/318574 Log: Optionify libnotify dependency. PR: ports/178697 Submitted by: Benjamin Lee <ben@b1c1l1.com> Patch by: Krzysztof Stryjek <ports@bsdserwis.com> (maintainer) Modified: head/net-mgmt/collectd5/Makefile Modified: head/net-mgmt/collectd5/Makefile ============================================================================== --- head/net-mgmt/collectd5/Makefile Mon May 20 06:11:46 2013 (r318573) +++ head/net-mgmt/collectd5/Makefile Mon May 20 06:14:09 2013 (r318574) @@ -3,15 +3,13 @@ PORTNAME= collectd PORTVERSION= 5.2.1 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= net-mgmt MASTER_SITES= http://collectd.org/files/ MAINTAINER= ports@bsdserwis.com COMMENT= Systems & network statistics collection daemon -LIB_DEPENDS= notify:${PORTSDIR}/devel/libnotify - USE_BZIP2= yes USE_GMAKE= yes GNU_CONFIGURE= yes @@ -50,7 +48,7 @@ MBMON_DESC= MBMon MEMCACHED_DESC= Memcached MODBUS_DESC= Modbus support via libmodbus MYSQL_DESC= MySQL -NOTIFYEMAIL_DESC= Email notifications (libesmtp) +NOTIFYEMAIL_DESC= Email notifications (libesmtp, libnotify) NGINX_DESC= Nginx OPENVPN_DESC= OpenVPN statistics PDNS_DESC= PowerDNS @@ -120,7 +118,6 @@ CONFIGURE_ARGS= --localstatedir=/var \ --disable-netlink \ --disable-nfs \ --disable-notify_desktop \ - --disable-notify_email \ --disable-olsrd \ --disable-onewire \ --disable-oracle \ @@ -320,6 +317,7 @@ PLIST_SUB+= IPMI="@comment " .if ${PORT_OPTIONS:MNOTIFYEMAIL} LIB_DEPENDS+= esmtp:${PORTSDIR}/mail/libesmtp +LIB_DEPENDS+= notify:${PORTSDIR}/devel/libnotify CONFIGURE_ARGS+=--enable-notify_email CONFIGURE_ARGS+=--with-libesmtp=${PREFIX} PLIST_SUB+= NOTIFYEMAIL="" _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!