Bug 178712 - net/boinc-client - fails to build with -std=c++11 (fix is trivial)
Summary: net/boinc-client - fails to build with -std=c++11 (fix is trivial)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 12:20 UTC by c.kworr
Modified: 2013-07-10 13:20 UTC (History)
0 users

See Also:

Attachments
file.diff (1.10 KB, patch)
2013-05-17 12:20 UTC, c.kworr 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description c.kworr 2013-05-17 12:20:02 UTC 
When building this port with LIBCPLUSPLUS I get this two glitches:

boinc_api.cpp:114:39: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
const char* api_version="API_VERSION_"PACKAGE_VERSION;
                                      ^

In file included from acct_mgr.cpp:34:
./client_msgs.h:76:20: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
#define _(x) "_(\""x"\")"
                   ^

Fix: Patch to the port attached.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-17 12:20:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2013-07-10 10:40:04 UTC 
Responsible Changed
From-To: pav->rene

I took over the port.
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2013-07-10 13:14:57 UTC 
State Changed
From-To: open->closed

Committed, thanks
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-07-10 13:18:29 UTC 
Author: rene
Date: Wed Jul 10 12:18:21 2013
New Revision: 322677
URL: http://svnweb.freebsd.org/changeset/ports/322677

Log:
  Fix build with --std=c++11
  
  PR:		ports/178712
  Submitted by:	Volodymyr Kostyrko <c.kworr@gmail.com>

Added:
  head/net/boinc-client/files/patch-api__boinc_api.cpp   (contents, props changed)
  head/net/boinc-client/files/patch-client__client_msgs.h   (contents, props changed)

Added: head/net/boinc-client/files/patch-api__boinc_api.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/net/boinc-client/files/patch-api__boinc_api.cpp	Wed Jul 10 12:18:21 2013	(r322677)
@@ -0,0 +1,11 @@
+--- api/boinc_api.cpp.old	2013-05-17 14:10:37.000000000 +0300
++++ api/boinc_api.cpp	2013-05-17 14:10:49.000000000 +0300
+@@ -111,7 +111,7 @@
+     // CPPFLAGS=-DGETRUSAGE_IN_TIMER_THREAD
+ #endif
+ 
+-const char* api_version="API_VERSION_"PACKAGE_VERSION;
++const char* api_version="API_VERSION_" PACKAGE_VERSION;
+ static APP_INIT_DATA aid;
+ static FILE_LOCK file_lock;
+ APP_CLIENT_SHM* app_client_shm = 0;

Added: head/net/boinc-client/files/patch-client__client_msgs.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/net/boinc-client/files/patch-client__client_msgs.h	Wed Jul 10 12:18:21 2013	(r322677)
@@ -0,0 +1,10 @@
+--- client/client_msgs.h.old	2013-05-17 14:13:10.000000000 +0300
++++ client/client_msgs.h	2013-05-17 14:13:20.000000000 +0300
+@@ -73,6 +73,6 @@
+     __attribute__ ((format (printf, 4, 5)))
+ ;
+ 
+-#define _(x) "_(\""x"\")"
++#define _(x) "_(\"" x"\")"
+ 
+ #endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"