Bug 178721 - www/firefox: application icon is broken [w/fix]
Summary: www/firefox: application icon is broken [w/fix]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 16:40 UTC by Lawrence Chen
Modified: 2013-05-17 18:50 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2013-05-17 16:40:00 UTC
	After updating to firefox-21.0,1 the icon is broken

Fix: 

change the symlink to point to
	/usr/local/lib/firefox/browser/chrome/icons/default/default48.png
How-To-Repeat: 	update to it

	/usr/local/share/pixmaps/firefox.png is a broken symlink, because
	/usr/local/lib/firefox/chrome/icons/default/default48.png doesn't exist.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-17 16:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gecko

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-05-17 18:43:33 UTC
Author: flo
Date: Fri May 17 17:43:21 2013
New Revision: 318394
URL: http://svnweb.freebsd.org/changeset/ports/318394

Log:
  Fix icon installation
  
  PR:		ports/178711
  PR:		ports/178721
  Submitted by:	Denny Lin <dennylin93@hs.ntnu.edu.tw>
  
  > Description of fields to fill in above:                     76 columns --|
  > PR:            If a GNATS PR is affected by the change.
  > Submitted by:  If someone else sent in the change.
  > Reviewed by:   If someone else reviewed your modification.
  > Approved by:   If you needed approval for this commit.
  > Obtained from: If the change is from a third party.
  > MFC after:     N [day[s]|week[s]|month[s]].  Request a reminder email.
  > Security:      Vulnerability reference (one per line) or description.
  > Sponsored by:  If the change was sponsored by an organization.
  > Empty fields above will be automatically removed.
  
  M    firefox/Makefile

Modified:
  head/www/firefox/Makefile

Modified: head/www/firefox/Makefile
==============================================================================
--- head/www/firefox/Makefile	Fri May 17 17:09:05 2013	(r318393)
+++ head/www/firefox/Makefile	Fri May 17 17:43:21 2013	(r318394)
@@ -3,6 +3,7 @@
 
 PORTNAME=	firefox
 DISTVERSION=	21.0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	www ipv6
 MASTER_SITES=	MOZILLA/${PORTNAME}/releases/${DISTVERSION}/source
@@ -40,7 +41,7 @@ USE_DOS2UNIX=	media/webrtc/trunk/webrtc/
 NO_MOZPKGINSTALL=yes
 
 FIREFOX_ICON=		${MOZILLA}.png
-FIREFOX_ICON_SRC=	${PREFIX}/lib/${MOZILLA}/chrome/icons/default/default48.png
+FIREFOX_ICON_SRC=	${PREFIX}/lib/${MOZILLA}/browser/chrome/icons/default/default48.png
 MOZ_OPTIONS=	--program-transform-name='s/firefox/${MOZILLA}/' \
 		--enable-application=browser \
 		--enable-official-branding
@@ -100,14 +101,10 @@ port-pre-install:
 	${ECHO_CMD} 'share/applications/${MOZILLA}.desktop' >> ${PLISTF}
 	${ECHO_CMD} "@dirrmtry share/applications" >> ${PLISTD}
 	${ECHO_CMD} 'share/pixmaps/${FIREFOX_ICON}' >> ${PLISTF}
-	${ECHO_CMD} "@dirrm lib/firefox/chrome/icons/default" >> ${PLISTD}
-	${ECHO_CMD} "@dirrm lib/firefox/chrome/icons" >> ${PLISTD}
-	${ECHO_CMD} "@dirrm lib/firefox/chrome" >> ${PLISTD}
 
 post-install:
 	${MKDIR} ${PREFIX}/share/applications ${PREFIX}/share/pixmaps
 	${INSTALL_DATA} ${WRKDIR}/${MOZILLA}.desktop ${PREFIX}/share/applications/
-	${MKDIR} ${PREFIX}/lib/${MOZILLA}/chrome/icons/default
 	${LN} -sf ${FIREFOX_ICON_SRC} ${PREFIX}/share/pixmaps/${FIREFOX_ICON}
 	@${CAT} ${PKGMESSAGE}
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Florian Smeets freebsd_committer freebsd_triage 2013-05-17 18:45:33 UTC
State Changed
From-To: open->closed

Fixed in r318394