Bug 178784 - [patch] enable PowerPC support in devel/gdb
Summary: [patch] enable PowerPC support in devel/gdb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-20 07:40 UTC by Andreas Tobler
Modified: 2013-09-01 23:40 UTC (History)
0 users

See Also:


Attachments
file.diff (3.42 KB, patch)
2013-05-20 07:40 UTC, Andreas Tobler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Tobler freebsd_committer freebsd_triage 2013-05-20 07:40:00 UTC
The latest gdb, 7.6, brings native PowerPC FreeBSD support. We just need enable it in ports.
There is a minor glitch which needs patching gdb itself. Namely, ALL_TARGET_OBJ is missing ppcfbsd-tdep.o. This part is already sent upstream.

The attached patch enables PowerPC support in gdb.
The patch is made with svn diff in the devel/gdb directory.

Fix: Apply the attached patch :)

Patch attached with submission follows:
How-To-Repeat: -
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-20 07:40:15 UTC
Maintainer of devel/gdb,

Please note that PR ports/178784 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178784

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-20 07:40:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 luca.pizzamiglio 2013-05-22 13:02:36 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I tested the patch and I found no problems, then patch approved!
Thanks for the help!

Luca

On 05/20/13 08:40, Edwin Groothuis wrote:
> Maintainer of devel/gdb,
>
> Please note that PR ports/178784 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178784
>
-----BEGIN PGP SIGNATURE-----
Version: APG v1.0.8

iQJLBAEBCAA1BQJRnLPcLhxMdWNhIFBpenphbWlnbGlvIDxsdWNhLnBpenphbWln
bGlvQGdtYWlsLmNvbT4ACgkQ1r9Hhyzd6UVWOxAAi1pMdjnP6EiqgQyWFLhyirnz
VUcyuzDtojI6t8YGwOtVFJK2t1uhchH1o3upFsb//W1kBukJPMFTfm3oCrdyKu31
oPFrwsi1b27JvTPSmnrYMkFEaP+X8AEKRQZojgXrYIGiqN12+t0Xilaox18lM6+M
+EemO4bkWsHNvS7MVRBR20Ch3JXlzJqfyhlZi8Q6qJNc3rOxqn/BSp6CxtJj2ZGp
t+oebLqG6QsniphFgVDoZ+s956zMthw3AzL19EeFEx46ixm7YfitmCus6vn02faG
DGjxTojHo5Q98w90/YUT8p4htKdC9rvxaGX7dY834zWerWz9CKf1IikLiuRFbFO2
14nkhhWCHeIfHPb0zjDYxYGaK9pPEMzGBO+521loSduABElZmHo/vGBCltGPIxnJ
DKspevcX7tSloIiKW4QYLhI23CXAd5NT4yNDo/AgS2cf234gJzuMLD6eVG80BC7x
ZQTelfVrXzdZLCw4JLb0UxvZUXkzqSdyTQR2D1Le14oxzMn0sFf8CCge9tel2WLl
F8tOOEm/VzL2VjxOE6RUX1MeH7dZI91GR12NilQrlo4Q9gz9OQvNBnzpRb3qZtWD
I5RkgA0Ne1vk3YJ63kufMxLolhbH3VBF5RCn2kCoVroAHgKyR8BiHUaZNqkM96if
ylSBjOZhpEG99dJY5NY=
=TRxd
-----END PGP SIGNATURE-----
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2013-05-22 22:20:51 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-09-01 23:31:57 UTC
Author: rakuco
Date: Sun Sep  1 22:31:44 2013
New Revision: 325922
URL: http://svnweb.freebsd.org/changeset/ports/325922

Log:
  Enable PowerPC support.
  
  The latest gdb, 7.6, brings native PowerPC FreeBSD support. We just need
  enable it in ports.
  
  There is a minor glitch which needs patching gdb itself. Namely,
  ALL_TARGET_OBJ is missing ppcfbsd-tdep.o. This part is already sent
  upstream.
  
  PR:		ports/178784
  Submitted by:	andreast
  Approved by:	Luca Pizzamiglio <luca.pizzamiglio@gmail.com>

Modified:
  head/devel/gdb/Makefile
  head/devel/gdb/files/extrapatch-gdb-Makefile.in
  head/devel/gdb/files/extrapatch-gdb-configure.tgt

Modified: head/devel/gdb/Makefile
==============================================================================
--- head/devel/gdb/Makefile	Sun Sep  1 22:07:00 2013	(r325921)
+++ head/devel/gdb/Makefile	Sun Sep  1 22:31:44 2013	(r325922)
@@ -31,7 +31,7 @@ VER=	${PORTVERSION:S/.//g}
 PLIST_SUB=	VER=${VER}
 MAN1=	gdb${VER}.1
 
-ONLY_FOR_ARCHS=	i386 amd64	# untested elsewhere, might work
+ONLY_FOR_ARCHS=	i386 amd64 powerpc powerpc64	# untested elsewhere, might work
 
 OPTIONS_DEFINE=	DEBUG EXPAT PYTHON THREADS TUI GDB_LINK
 OPTIONS_SINGLE_READLINE=	BASE_READLINE BUNDLED_READLINE PORT_READLINE

Modified: head/devel/gdb/files/extrapatch-gdb-Makefile.in
==============================================================================
--- head/devel/gdb/files/extrapatch-gdb-Makefile.in	Sun Sep  1 22:07:00 2013	(r325921)
+++ head/devel/gdb/files/extrapatch-gdb-Makefile.in	Sun Sep  1 22:31:44 2013	(r325922)
@@ -1,9 +1,20 @@
---- gdb/Makefile.in.orig	2012-07-02 17:29:33.000000000 +0200
-+++ gdb/Makefile.in	2012-08-26 21:01:45.589052997 +0200
-@@ -573,6 +573,7 @@
+--- gdb/Makefile.in.orig	2013-04-02 19:38:43.000000000 +0200
++++ gdb/Makefile.in	2013-05-18 13:08:47.000000000 +0200
+@@ -566,8 +566,8 @@
+ 	moxie-tdep.o \
+ 	mt-tdep.o \
+ 	nto-tdep.o \
+-	ppc-linux-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o ppc-sysv-tdep.o \
+-	ppc64-tdep.o rl78-tdep.o \
++	ppc-linux-tdep.o ppcfbsd-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o \
++	ppc-sysv-tdep.o ppc64-tdep.o rl78-tdep.o \
+ 	rs6000-aix-tdep.o rs6000-tdep.o ppc-ravenscar-thread.o \
+ 	rs6000-lynx178-tdep.o \
+ 	rx-tdep.o \
+@@ -585,6 +585,7 @@
  	xtensa-config.o xtensa-tdep.o xtensa-linux-tdep.o \
  	glibc-tdep.o \
-	bsd-uthread.o \
+ 	bsd-uthread.o \
 +	fbsd-threads.o \
  	nbsd-tdep.o obsd-tdep.o \
  	sol2-tdep.o \

Modified: head/devel/gdb/files/extrapatch-gdb-configure.tgt
==============================================================================
--- head/devel/gdb/files/extrapatch-gdb-configure.tgt	Sun Sep  1 22:07:00 2013	(r325921)
+++ head/devel/gdb/files/extrapatch-gdb-configure.tgt	Sun Sep  1 22:31:44 2013	(r325922)
@@ -1,6 +1,6 @@
---- gdb/configure.tgt.orig	2012-08-01 21:48:44.000000000 +0200
-+++ gdb/configure.tgt	2012-08-22 16:47:02.000000000 +0200
-@@ -176,7 +176,7 @@
+--- gdb/configure.tgt.orig	2013-03-05 14:37:10.000000000 +0100
++++ gdb/configure.tgt	2013-05-18 13:11:06.000000000 +0200
+@@ -188,7 +188,7 @@
  i[34567]86-*-freebsd* | i[34567]86-*-kfreebsd*-gnu)
  	# Target: FreeBSD/i386
  	gdb_target_obs="i386-tdep.o i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
@@ -9,7 +9,16 @@
  	;;
  i[34567]86-*-netbsd* | i[34567]86-*-knetbsd*-gnu)
  	# Target: NetBSD/i386
-@@ -606,7 +606,7 @@
+@@ -398,7 +398,7 @@
+ powerpc*-*-freebsd*)
+ 	# Target: FreeBSD/powerpc
+ 	gdb_target_obs="rs6000-tdep.o ppc-sysv-tdep.o ppc64-tdep.o \
+-		        ppcfbsd-tdep.o solib-svr4.o \
++		        ppcfbsd-tdep.o solib-svr4.o fbsd-threads.o \
+ 			ravenscar-thread.o ppc-ravenscar-thread.o"
+ 	;;
+ 
+@@ -650,7 +650,7 @@
  	# Target: FreeBSD/amd64
  	gdb_target_obs="amd64-tdep.o amd64fbsd-tdep.o i386-tdep.o \
  			i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2013-09-01 23:32:40 UTC
State Changed
From-To: open->closed

Committed, thank you. I trimmed the original diff a bit so as not to 
touch unrelated parts.