Avoiding the build problem pointed by http://pointyhat-west.isc.freebsd.org/errorlogs/amd64-errorlogs/e.10-exp.20130522091700.pointyhat-west/arm-elf-binutils-2.23.2.log Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->bdrewery bdrewery@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Instead of ignoring the warnings, it would be better to write patches to fix the warnings and send upstream, or find upstream fixes. There's no WWW in pkg-descr, I'm not sure where this port comes from. Do you know?
I think they had good reasons to write this code. For example, the warning: plugin.c:436:8: error: explicitly assigning a variable of type 'struct ld_plugin_input_file *' to itself [-Werror,-Wself-assign] file = file; On GCC, assign a function parameter to itself avoids the warning "warning: unused parameter 'file'". But the clang is generating another warning. I think there is no problem with the "--disable-werror" in this case and the others warnings too. What do you think? About the WWW, I'll fix it.
On 6/4/2013 11:30 PM, Danilo Egea wrote: > I think they had good reasons to write this code. > For example, the warning: > > plugin.c:436:8: error: explicitly assigning a variable of type 'struct > ld_plugin_input_file *' to itself [-Werror,-Wself-assign] > file = file; > > On GCC, assign a function parameter to itself avoids the warning > "warning: unused parameter 'file'". But the clang is generating another > warning. > > I think there is no problem with the "--disable-werror" in this case and > the others warnings too. > > What do you think? > > About the WWW, I'll fix it. I'll commit the --disable-werror for now to at least make it buildable with clang. I still suggest contacting upstream and sending them patches to make the code support both GCC and clang. They may already have patches for this as well. Just send another PR to update the WWW. Thank you for your work on this. -- Regards, Bryan Drewery
State Changed From-To: open->closed Committed. Thanks!
Author: bdrewery Date: Thu Jun 6 00:04:19 2013 New Revision: 320038 URL: http://svnweb.freebsd.org/changeset/ports/320038 Log: - Disable -Werror for now to fix clang building. Discussed with maintainer a more proper solution and to contact upstream. This at least allows clang to build for now. PR: ports/179041 Submitted by: Danilo Egea Gondolfo <danilogondolfo@gmail.com> (maintainer) Modified: head/devel/arm-elf-binutils/Makefile Modified: head/devel/arm-elf-binutils/Makefile ============================================================================== --- head/devel/arm-elf-binutils/Makefile Wed Jun 5 22:40:22 2013 (r320037) +++ head/devel/arm-elf-binutils/Makefile Thu Jun 6 00:04:19 2013 (r320038) @@ -15,7 +15,7 @@ USE_BZIP2= yes USE_GMAKE= yes USES= gettext GNU_CONFIGURE= yes -CONFIGURE_ARGS= --target=${PKGNAMEPREFIX:S/-$//} CFLAGS="-I/usr/local/include" +CONFIGURE_ARGS= --target=${PKGNAMEPREFIX:S/-$//} --disable-werror CFLAGS="-I/usr/local/include" INFO_PATH= ${PKGNAMEPREFIX:S/-$//}/info MAN1= ${PKGNAMEPREFIX}addr2line.1 ${PKGNAMEPREFIX}as.1 \ ${PKGNAMEPREFIX}ar.1 ${PKGNAMEPREFIX}c++filt.1 \ _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"