Bug 179130 - [PATCH] multimedia/vcdgear: Convert to OptionsNG, trim comment and docs
Summary: [PATCH] multimedia/vcdgear: Convert to OptionsNG, trim comment and docs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 22:40 UTC by nemysis
Modified: 2014-02-07 22:50 UTC (History)
1 user (show)

See Also:


Attachments
vcdgear-1.6d.patch (2.37 KB, patch)
2013-05-30 22:40 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-05-30 22:40:00 UTC
- Shorten header
- Trim comment
- Convert to OptionsNG
- Trim docs
- Remove pkg-plist

Removed file(s):
- pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130530202301-46110/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-30 22:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Thomas Abthorpe freebsd_committer freebsd_triage 2014-01-10 03:34:45 UTC
Responsible Changed
From-To: beech->nemysis

Submitter is committer
Comment 3 Rusmir Dusko freebsd_committer freebsd_triage 2014-02-07 22:41:15 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-02-07 22:47:35 UTC
Author: nemysis
Date: Fri Feb  7 22:47:27 2014
New Revision: 343303
URL: http://svnweb.freebsd.org/changeset/ports/343303
QAT: https://qat.redports.org/buildarchive/r343303/

Log:
  - Remove leading article from COMMENT
  - Use PLIST_FILES instead of pkg-plist
  - Change DOCS, add DOCS Option
  - Support STAGEDIR
  
  PR:		ports/179130
  Submitted by:	nemysis (self)

Deleted:
  head/multimedia/vcdgear/pkg-plist
Modified:
  head/multimedia/vcdgear/Makefile
  head/multimedia/vcdgear/distinfo

Modified: head/multimedia/vcdgear/Makefile
==============================================================================
--- head/multimedia/vcdgear/Makefile	Fri Feb  7 22:30:46 2014	(r343302)
+++ head/multimedia/vcdgear/Makefile	Fri Feb  7 22:47:27 2014	(r343303)
@@ -7,11 +7,19 @@ CATEGORIES=	multimedia
 MASTER_SITES=	http://www.vcdgear.com/files/
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A tool to convert VCDs from cue/bin format to mpeg
+COMMENT=	Tool to convert VCDs from cue/bin format to mpeg 
+
+WRKSRC=		${WRKDIR}/vcdgear16
+NO_BUILD=	true
+
+PLIST_FILES=	bin/${PORTNAME}
+
+PORTDOCS=	faq.txt manual.txt whatsnew.txt
+
+OPTIONS_DEFINE=	DOCS
 
 ONLY_FOR_ARCHS=	alpha i386 amd64
 
-NO_STAGE=	yes
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == i386 || ${ARCH} == amd64
@@ -20,16 +28,11 @@ DISTNAME=	${PORTNAME}16d_i386_freebsd42
 DISTNAME=	${PORTNAME}16d_alpha_freebsd41
 .endif
 
-NO_BUILD=	true
-WRKSRC=		${WRKDIR}/vcdgear16
-
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static ${PREFIX}/bin/vcdgear
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for file in faq.txt manual.txt whatsnew.txt
-	${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
-.endfor
-.endif
+	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static \
+		${STAGEDIR}${PREFIX}/bin/${PORTNAME}
+
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.post.mk>

Modified: head/multimedia/vcdgear/distinfo
==============================================================================
--- head/multimedia/vcdgear/distinfo	Fri Feb  7 22:30:46 2014	(r343302)
+++ head/multimedia/vcdgear/distinfo	Fri Feb  7 22:47:27 2014	(r343303)
@@ -1,4 +1,2 @@
-SHA256 (vcdgear16d_alpha_freebsd41.tar.gz) = cedce8180bd7e4959aaa3b26d4e83d0804c156c94168a1ef7f0f7259f91159e8
-SIZE (vcdgear16d_alpha_freebsd41.tar.gz) = 121796
 SHA256 (vcdgear16d_i386_freebsd42.tar.gz) = c90cc63ff402ab6bcfc545d9b534bd3ce86954d8a5b2069554174073b73bf432
 SIZE (vcdgear16d_i386_freebsd42.tar.gz) = 98035
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"