Bug 179565 - [MAINTAINER] devel/pecl-pthreads: [SUMMARIZE CHANGES]
Summary: [MAINTAINER] devel/pecl-pthreads: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-15 06:30 UTC by johnpupu
Modified: 2013-12-30 09:20 UTC (History)
0 users

See Also:


Attachments
pecl-pthreads-0.0.44_1.patch (765 bytes, patch)
2013-06-15 06:30 UTC, johnpupu
no flags Details | Diff
pecl-pthreads-0.0.44_1.patch (914 bytes, patch)
2013-08-19 04:54 UTC, johnpupu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description johnpupu 2013-06-15 06:30:00 UTC
Fix PHP Thread-Safe problem.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: suffix)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-15 06:30:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2013-07-11 16:24:31 UTC
State Changed
From-To: open->feedback

this patch fails to build please create a test account under redport.org 
there u can test you patch.
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2013-09-22 15:13:19 UTC
Responsible Changed
From-To: miwi->freebsd-ports-bugs

Back to the heap due to timeout
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-27 19:20:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-12-30 09:12:41 UTC
Author: sunpoet
Date: Mon Dec 30 09:12:33 2013
New Revision: 338065
URL: http://svnweb.freebsd.org/changeset/ports/338065

Log:
  - Fix PHP Thread-Safe problem
  - While I'm here:
    - Remove leading indefinite article from COMMENT
    - Avoid INDEX breakage:
      - Check existence of ${LOCALBASE}/bin/php
      - PHP_ZTS defaults to disabled
    - Support STAGEDIR
  
  PR:		ports/179565
  Submitted by:	John Chen <johnpupu@gmail.com> (maintainer)

Modified:
  head/devel/pecl-pthreads/Makefile

Modified: head/devel/pecl-pthreads/Makefile
==============================================================================
--- head/devel/pecl-pthreads/Makefile	Mon Dec 30 09:08:13 2013	(r338064)
+++ head/devel/pecl-pthreads/Makefile	Mon Dec 30 09:12:33 2013	(r338065)
@@ -10,7 +10,7 @@ EXTRACT_SUFX=	.tgz
 DIST_SUBDIR=	PECL
 
 MAINTAINER=	johnpupu@gmail.com
-COMMENT=	A compatible Threading API for PHP5.3+
+COMMENT=	Compatible Threading API for PHP5.3+
 
 LICENSE=	PHP301
 
@@ -21,5 +21,16 @@ USE_PHPEXT=	yes
 PHP_MODNAME=	pthreads
 IGNORE_WITH_PHP=	52
 
-NO_STAGE=	yes
+.include <bsd.port.options.mk>
+
+.if !defined(PHP_ZTS) && exists(${LOCALBASE}/bin/php)
+PHP_ZTS!=	${LOCALBASE}/bin/php -r 'phpinfo();' | ${GREP} 'Thread Safety' | ${AWK} -F '=> ' '{print $$2}'
+.else
+PHP_ZTS=	disabled
+.endif
+
+.if ${PHP_ZTS} == "disabled"
+IGNORE=		pthreads requires ZTS, please re-compile PHP with ZTS enabled
+.endif
+
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-30 09:12:43 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!