Bug 179665 - mail/php52-imap missing SSL support, won't compile (fix included)
Summary: mail/php52-imap missing SSL support, won't compile (fix included)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-18 01:00 UTC by Adam McDougall
Modified: 2013-06-18 18:50 UTC (History)
0 users

See Also:


Attachments
lang.php52.diff (764 bytes, patch)
2013-06-18 05:54 UTC, admin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam McDougall 2013-06-18 01:00:00 UTC
In r319990 lang/php52 was convert to new options framework.  The implementation of SSL support was turned into a positive option instead of ".if !defined(WITHOUT_SSL)" but the new option is never set or offered in make config.  

In contrast php53 port has:
.if ${PHP_MODNAME} == "imap"
OPTIONS_DEFINE= SSL
OPTIONS_DEFAULT=        SSL
LIB_DEPENDS+=   c-client4.9:${PORTSDIR}/mail/cclient

CONFIGURE_ARGS+=--with-imap=${LOCALBASE} \
                --with-pcre-dir=${LOCALBASE}
USE_OPENSSL=    yes
.endif

But lang/php52/Makefile.ext is missing the OPTIONS_... = SSL lines so compile fails in a different section.  It compiles when I add the two OPTIONS lines, not sure if pcre-dir is needed or desired.

Fix: 

Add OPTIONS_DEFINE=SSL and OPTIONS_DEFAULT=SSL to .if ${PHP_MODNAME} == "imap" in ports/lang/php52/Makefile.ext like ports/lang/php53/Makefile.ext
How-To-Repeat: compile lang/php52-imap, note configure error (cclient has SSL support but php52-imap wasn't instructed to use SSL so configure fails)

checking for crypt in -lcrypt... yes
configure: error: This c-client library is built with SSL support.

      Add --with-imap-ssl to your configure line. Check config.log for details.
      
===>  Script "configure" failed unexpectedly.
Please report the problem to admin@lissyara.su [maintainer] and attach the
"/wrkdirs/usr/ports/mail/php52-imap/work/php-5.2.17/ext/imap/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** [do-configure] Error code 1

Stop in /usr/ports/mail/php52-imap.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-18 03:03:26 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-18 03:03:26 UTC
Maintainer of mail/php52-imap,

Please note that PR ports/179665 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179665

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 admin 2013-06-18 05:54:22 UTC
please, commit attached patch
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-06-18 18:48:44 UTC
Author: az
Date: Tue Jun 18 17:48:36 2013
New Revision: 321208
URL: http://svnweb.freebsd.org/changeset/ports/321208

Log:
  - Fix after convertion to new options framework
  
  PR:		ports/179665
  Submitted by:	Adam McDougall <mcdouga9@egr.msu.edu>
  Approved by:	Alex Keda <admin@lissyara.su> (maintainer)

Modified:
  head/lang/php52/Makefile.ext   (contents, props changed)

Modified: head/lang/php52/Makefile.ext
==============================================================================
--- head/lang/php52/Makefile.ext	Tue Jun 18 17:36:23 2013	(r321207)
+++ head/lang/php52/Makefile.ext	Tue Jun 18 17:48:36 2013	(r321208)
@@ -142,6 +142,8 @@ USES+=		iconv
 .endif
 
 .if ${PHP_MODNAME} == "imap"
+OPTIONS_DEFINE=	SSL
+OPTIONS_DEFAULT=	SSL
 LIB_DEPENDS+=	c-client4.9:${PORTSDIR}/mail/cclient
 
 CONFIGURE_ARGS+=--with-imap=${LOCALBASE}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Andrej Zverev freebsd_committer freebsd_triage 2013-06-18 18:48:51 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!