Bug 179882 - [PATCH] games/thegrind: unbreak (bad dependency)
Summary: [PATCH] games/thegrind: unbreak (bad dependency)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-23 16:50 UTC by John Marino
Modified: 2013-06-24 15:00 UTC (History)
0 users

See Also:


Attachments
file.diff (486 bytes, patch)
2013-06-23 16:50 UTC, John Marino
no flags Details | Diff
thegrind.diff (1.65 KB, patch)
2013-06-23 21:54 UTC, nemysis
no flags Details | Diff
thegrind.diff (1.67 KB, patch)
2013-06-24 11:05 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2013-06-23 16:50:00 UTC
thegame requests the dynamic library "radius" from radius-engine, but this isn't listed in the package list.  THe attached patch lists the static library radius-engine.a instead to fix it.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-23 16:50:12 UTC
Maintainer of games/thegrind,

Please note that PR ports/179882 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179882

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-23 16:50:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 nemysis 2013-06-23 21:54:20 UTC
- Trim Makefile header
- Remove leading article from COMMENT
- Trim dependency for graphics/radius-engine
- Trim PLIST_FILES and PLIST_DIRS
- Trim typo


Build log

https://redports.org/buildarchive/20130623191400-7766/
Comment 4 William Grzybowski freebsd_committer freebsd_triage 2013-06-23 21:56:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 5 nemysis 2013-06-24 11:05:49 UTC
Sorry have forged to add Options for DOCS

- Add DOCS Option
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-06-24 14:54:30 UTC
Author: wg
Date: Mon Jun 24 13:54:22 2013
New Revision: 321682
URL: http://svnweb.freebsd.org/changeset/ports/321682

Log:
  games/thegrind: fix build depends
  
  - Fix BUILD_DEPENDS: needs a static library [1]
  - Remove leading article in COMMENT [2]
  - Add maintainer alias in Makefile [2]
  - Add DOCS option and unmute docs mkdir [2]
  
  PR:		ports/179882
  Submitted by:	John Marino <draco@marino.st> [1], maintainer [2]

Modified:
  head/games/thegrind/Makefile

Modified: head/games/thegrind/Makefile
==============================================================================
--- head/games/thegrind/Makefile	Mon Jun 24 13:53:29 2013	(r321681)
+++ head/games/thegrind/Makefile	Mon Jun 24 13:54:22 2013	(r321682)
@@ -1,4 +1,4 @@
-# Created by: nemysis@gmx.ch
+# Created by: nemysis <nemysis@gmx.ch>
 # $FreeBSD$
 
 PORTNAME=	thegrind
@@ -8,38 +8,41 @@ CATEGORIES=	games
 MASTER_SITES=	SF/radius-engine/ld21/
 
 MAINTAINER=	nemysis@gmx.ch
-COMMENT=	A simple game about escaping from work
+COMMENT=	Simple game about escaping from work
 
 LICENSE=	GPLv2
 
-LIB_DEPENDS=	radius:${PORTSDIR}/graphics/radius-engine \
-		lua-5.1:${PORTSDIR}/lang/lua \
+BUILD_DEPENDS=	${LOCALBASE}/lib/libradius-engine.a:${PORTSDIR}/graphics/radius-engine
+LIB_DEPENDS=	lua-5.1:${PORTSDIR}/lang/lua \
 		png15:${PORTSDIR}/graphics/png \
 		physfs.1:${PORTSDIR}/devel/physfs
 RUN_DEPENDS=	zip:${PORTSDIR}/archivers/zip
 
 USES=		pkgconfig
-GNU_CONFIGURE=	yes
-ALL_TARGET=	${PORTNAME}
 USE_SDL=	sdl sound
 USE_GL=		glu
+GNU_CONFIGURE=	yes
+ALL_TARGET=	${PORTNAME}
+
 MAKE_JOBS_SAFE=	yes
 
 PLIST_FILES=	bin/${PORTNAME} \
 		share/applications/${PORTNAME}.desktop \
-		share/pixmaps/${PORTNAME}.png
+		share/pixmaps/${PORTNAME}.png \
+		%%DATADIR%%/${PORTNAME}.zip
+PLIST_DIRS=	%%DATADIR%%
 PLIST_DIRSTRY=	share/applications
 
-PORTDATA=	*
 PORTDOCS=	ChangeLog
 
+OPTIONS_DEFINE=	DOCS
+
 .include <bsd.port.options.mk>
 
 post-install:
-# Documentation
 .if ${PORT_OPTIONS:MDOCS}
-	${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/ChangeLog ${DOCSDIR}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 William Grzybowski freebsd_committer freebsd_triage 2013-06-24 14:55:15 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!