Bug 179933 - [patch] www/serf: remove gmake dependency
Summary: [patch] www/serf: remove gmake dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-apache (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 18:50 UTC by Tijl Coosemans
Modified: 2013-07-06 10:25 UTC (History)
0 users

See Also:

Attachments
serf.patch (1.13 KB, patch)
2013-06-24 18:50 UTC, Tijl Coosemans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2013-06-24 18:50:00 UTC 
I'm going over devel/subversion dependencies to see if any can be
removed. The attached patch removes gmake from www/serf and some
other small changes:
- Put PROJECTHOST together with MASTER_SITES.
- Replace NOPORTDOCS with DOCS option.
- Remove USE_GMAKE.
- Silence post-patch.
- Rename check target to regression-test such that pointyhat runs
  the tests.
- Put parentheses around "cd <dir> && <command>" as recommended
  by make(1).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-24 18:50:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2013-07-04 10:09:37 UTC 
If there are no objections I'd like to commit this Sunday.
http://www.freebsd.org/cgi/query-pr.cgi?pr=179933
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-07-06 09:50:35 UTC 
Author: ohauer
Date: Sat Jul  6 08:50:22 2013
New Revision: 322369
URL: http://svnweb.freebsd.org/changeset/ports/322369

Log:
  - remove gmake dependency
  - bump PORTREVISION
  
  PR:		ports/179933
  Submitted by:	Tijl Coosemans tijl@

Modified:
  head/www/serf/Makefile

Modified: head/www/serf/Makefile
==============================================================================
--- head/www/serf/Makefile	Sat Jul  6 08:46:39 2013	(r322368)
+++ head/www/serf/Makefile	Sat Jul  6 08:50:22 2013	(r322369)
@@ -3,6 +3,7 @@
 
 PORTNAME=	serf
 PORTVERSION=	1.2.1
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	GOOGLE_CODE
 MASTER_SITE_SUBDIR=	db
@@ -13,26 +14,27 @@ COMMENT=	Serf HTTP client library
 LIB_DEPENDS+=	apr-1:${PORTSDIR}/devel/apr1
 
 MAKE_JOBS_SAFE=	yes
-
-PROJECTHOST=	serf
 USE_BZIP2=	yes
-USE_GMAKE=	yes
-USES=	pathfix
+USES=		pathfix
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 CONFIGURE_ARGS+=	--with-apr=${LOCALBASE}/bin/apr-1-config \
 			--with-apr-util=${LOCALBASE}/bin/apu-1-config
 
+OPTIONS_DEFINE=	DOCS
+
+.include <bsd.port.options.mk>
+
 post-patch:
-	${REINPLACE_CMD} -e '/^Requires.private/d' ${WRKSRC}/serf.pc.in
+	@${REINPLACE_CMD} -e '/^Requires.private/d' ${WRKSRC}/serf.pc.in
 
 post-install:
-.if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/design-guide.txt ${DOCSDIR}
 .endif
 
-check:
-	@cd ${WRKSRC}/ && ${MAKE} check
+regression-test:
+	@(cd ${WRKSRC} && ${MAKE} check)
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Olli Hauer freebsd_committer freebsd_triage 2013-07-06 10:25:09 UTC 
State Changed
From-To: open->closed

Committed, 
Thanks!