Bug 179934 - mail/courier fails to build if devel/pkgconf is not present
Summary: mail/courier fails to build if devel/pkgconf is not present
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 20:10 UTC by evgeni.dimitrov
Modified: 2013-08-30 14:20 UTC (History)
0 users

See Also:


Attachments
file.diff (633 bytes, patch)
2013-06-24 20:10 UTC, evgeni.dimitrov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description evgeni.dimitrov 2013-06-24 20:10:00 UTC
There is a PKG_CHECK_MODULES macro in ${WRKSRC}/rfc822/configure.in, line 44 that fails to expand if devel/pkgconf is not installed for example when building the port with poudriere. The result is an invalid ${WRKSRC}/rfc822/configure script.

Fix: The attached patch adds devel/pkgconf to BUILD_DEPEND.

Patch attached with submission follows:
How-To-Repeat: Try building mail/courier without having devel/pkgconf installed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-24 20:10:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-24 20:10:07 UTC
Maintainer of mail/courier,

Please note that PR ports/179934 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179934

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Alex Kozlov 2013-06-26 23:43:30 UTC
Hi

It's better to use USES= pkgconfig instead of BUILD_DEPENDS.


-- 
Alex
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2013-08-30 14:18:01 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-08-30 14:18:05 UTC
Author: bdrewery
Date: Fri Aug 30 13:17:53 2013
New Revision: 325688
URL: http://svnweb.freebsd.org/changeset/ports/325688

Log:
  - Fix build after autotools update [1]
  - Add missing pkgconfig dependency [2]
  
  Reported by:	Marat Bakeev <hawara@Hawara.com> via ports@ [1]
  PR:		ports/179934 [2]
  Reported by:	Evgeni Dimitrov <evgeni.dimitrov@gmail.com> [2]
  Approved by:	maintainer timeout

Modified:
  head/mail/courier/Makefile

Modified: head/mail/courier/Makefile
==============================================================================
--- head/mail/courier/Makefile	Fri Aug 30 13:15:31 2013	(r325687)
+++ head/mail/courier/Makefile	Fri Aug 30 13:17:53 2013	(r325688)
@@ -57,12 +57,12 @@ CALENDIR=	/var/spool/calendar
 MIMETYPES=	${LOCALBASE}/etc/mime.types
 WITH_TRANSPORT=	local esmtp dsn
 
-USE_AUTOTOOLS=	libtool aclocal
+USE_AUTOTOOLS=	libtool aclocal automake
 AUTOMAKE_ARGS=	--add-missing
 USE_BZIP2=	yes
 USE_GCC=	any
 USE_FAM=	yes
-USES=		gettext
+USES=		gettext pkgconfig
 USE_GMAKE=	yes
 USE_OPENSSL=	yes
 USE_PERL5=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2013-08-30 14:18:08 UTC
State Changed
From-To: feedback->closed

Fixed, thanks!