Bug 180113 - [MAINTAINER] x11/florence: Add missing dependency, trim NLS
Summary: [MAINTAINER] x11/florence: Add missing dependency, trim NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-29 23:40 UTC by nemysis
Modified: 2013-07-03 13:50 UTC (History)
1 user (show)

See Also:

Attachments
florence-0.6.0.patch (1.23 KB, patch)
2013-06-29 23:40 UTC, nemysis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-29 23:40:00 UTC 
- Add run dependency for accessibility/at-spi2-core
- New world order USES: desktop-file-utils iconv pathfix
- Add DOCS Option
- Trim NLS

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)

How-To-Repeat: 
kwm@ have said to add this dependency

Build log

https://redports.org/buildarchive/20130629203300-39123/
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2013-07-03 02:33:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-07-03 13:44:20 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-07-03 13:44:25 UTC 
Author: wg
Date: Wed Jul  3 12:44:17 2013
New Revision: 322227
URL: http://svnweb.freebsd.org/changeset/ports/322227

Log:
  x11/florence: fix run depends
  
  - BUILD_DEPENDS is RUN_DEPENDS as well
  - Add DOCS option
  - Use OPTIONS_SUB
  
  PR:		ports/180113
  Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)

Modified:
  head/x11/florence/Makefile

Modified: head/x11/florence/Makefile
==============================================================================
--- head/x11/florence/Makefile	Wed Jul  3 12:41:28 2013	(r322226)
+++ head/x11/florence/Makefile	Wed Jul  3 12:44:17 2013	(r322227)
@@ -4,7 +4,7 @@
 PORTNAME=	florence
 PORTVERSION=	0.6.0
 CATEGORIES=	x11
-MASTER_SITES=	SF/florence/florence/${PORTVERSION}
+MASTER_SITES=	SF/florence/florence/${PORTVERSION}/
 
 MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Extensible scalable virtual keyboard
@@ -14,9 +14,10 @@ LICENSE_COMB=	dual
 
 LIB_DEPENDS=	notify:${PORTSDIR}/devel/libnotify
 BUILD_DEPENDS=	${LOCALBASE}/libexec/at-spi2-registryd:${PORTSDIR}/accessibility/at-spi2-core
+RUN_DEPENDS:=	${BUILD_DEPENDS}
 
 USE_BZIP2=	yes
-USES=		desktop-file-utils gettext iconv pathfix
+USES=		desktop-file-utils iconv pathfix
 USE_XORG=	xtst xext
 USE_GNOME=	gtk30 cairo intlhack gnomedocutils librsvg2
 USE_GSTREAMER=	yes
@@ -31,16 +32,12 @@ MAN1=		${PORTNAME}.1 ${PORTNAME}_applet.
 
 PORTDOCS=	AUTHORS ChangeLog NEWS README
 
-OPTIONS_DEFINE=	NLS
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
 
-.include <bsd.port.options.mk>
+NLS_USES=	gettext
 
-.if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
-.else
-PLIST_SUB+=	NLS="@comment "
-.endif
+.include <bsd.port.options.mk>
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|^Categories=.*|Categories=Application;Accessibility;System;|' \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"