Bug 180182 - mail/postgrey rc.d script missing rcvar
Summary: mail/postgrey rc.d script missing rcvar
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 22:10 UTC by Doug Barton
Modified: 2013-07-06 15:10 UTC (History)
0 users

See Also:


Attachments
file.diff (501 bytes, patch)
2013-07-01 22:10 UTC, Doug Barton
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Barton 2013-07-01 22:10:00 UTC
In r319058 madpilot inappropriate removed the rcvar assignment in this script, causing it to start unconditionally.

Fix: Apply the following patch:

Patch attached with submission follows:
How-To-Repeat: Install the port, restart the system
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-01 22:10:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-01 22:10:07 UTC
Maintainer of mail/postgrey,

Please note that PR ports/180182 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180182

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 ports.maintainer 2013-07-02 06:11:53 UTC
Patch approved.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2013-07-02 08:39:56 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2013-07-06 14:52:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-07-06 15:03:32 UTC
Author: madpilot
Date: Sat Jul  6 14:03:24 2013
New Revision: 322395
URL: http://svnweb.freebsd.org/changeset/ports/322395

Log:
  Add back rcvar assignment in startup script.
  
  PR:		ports/180182
  Submitted by:	Doug Barton <dougb@dougbarton.us>
  Approved by:	Darren Pilgrim <ports.maintainer@evilphi.com> (maintainer)

Modified:
  head/mail/postgrey/Makefile
  head/mail/postgrey/files/postgrey.in

Modified: head/mail/postgrey/Makefile
==============================================================================
--- head/mail/postgrey/Makefile	Sat Jul  6 13:29:54 2013	(r322394)
+++ head/mail/postgrey/Makefile	Sat Jul  6 14:03:24 2013	(r322395)
@@ -3,7 +3,7 @@
 
 PORTNAME=	postgrey
 PORTVERSION=	1.34
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	mail
 MASTER_SITES=	http://postgrey.schweikert.ch/pub/ \
 		http://postgrey.schweikert.ch/pub/old/

Modified: head/mail/postgrey/files/postgrey.in
==============================================================================
--- head/mail/postgrey/files/postgrey.in	Sat Jul  6 13:29:54 2013	(r322394)
+++ head/mail/postgrey/files/postgrey.in	Sat Jul  6 14:03:24 2013	(r322395)
@@ -1,12 +1,12 @@
 #!/bin/sh
+
 # $FreeBSD$
 #
-
 # PROVIDE: postgrey
 # REQUIRE: LOGIN
 # BEFORE: mail
 # KEYWORD: shutdown
-
+#
 # Add the following lines to /etc/rc.conf to enable postgrey:
 #
 # postgrey_enable (bool)        Set to 'YES' to enable
@@ -25,6 +25,7 @@
 . /etc/rc.subr
 
 name=postgrey
+rcvar=postgrey_enable
 
 load_rc_config $name
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2013-07-06 15:03:50 UTC
State Changed
From-To: open->closed

Committed. Sorry for the mistake. Thanks!