Bug 180203 - [MAINTAINER] net-mgmt/netdisco: [SUMMARIZE CHANGES]
Summary: [MAINTAINER] net-mgmt/netdisco: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 16:40 UTC by geoffroy desvernay
Modified: 2013-07-02 18:00 UTC (History)
1 user (show)

See Also:

Attachments
netdisco-1.3.patch (685 bytes, patch)
2013-07-02 16:40 UTC, geoffroy desvernay 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description geoffroy desvernay 2013-07-02 16:40:01 UTC 
Fix a syntax problem with mibs directories list containing spaces instead of colons.

Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: SVN)

Fix: attached
How-To-Repeat: Install current port and try to get it working from scratch
Comment 1 Lars Engels freebsd_committer freebsd_triage 2013-07-02 17:53:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lme

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-07-02 17:59:32 UTC 
Author: lme
Date: Tue Jul  2 16:59:24 2013
New Revision: 322181
URL: http://svnweb.freebsd.org/changeset/ports/322181

Log:
  Fix a syntax problem with mibs directories list containing spaces instead of colons.
  
  PR:		ports/180203
  Submitted by:	maintainer

Modified:
  head/net-mgmt/netdisco/Makefile

Modified: head/net-mgmt/netdisco/Makefile
==============================================================================
--- head/net-mgmt/netdisco/Makefile	Tue Jul  2 16:54:14 2013	(r322180)
+++ head/net-mgmt/netdisco/Makefile	Tue Jul  2 16:59:24 2013	(r322181)
@@ -63,11 +63,8 @@ MIBSDIR=	${PREFIX}/share/netdisco-mibs
 RUN_DEPENDS+=	${MIBSDIR}/mib_index.txt:${PORTSDIR}/net-mgmt/netdisco-mibs
 BUILD_DEPENDS+=	${MIBSDIR}/mib_index.txt:${PORTSDIR}/net-mgmt/netdisco-mibs
 . include 	"${.CURDIR}/../netdisco-mibs/bsd.port.netdisco.mk"
-MIBINCLUDES=
-. for mib in ${MIBDIRS}
-MIBINCLUDES+=	${MIBSDIR}/${mib},
-. endfor
-MIBINCLUDES:=${MIBINCLUDES:S/,$//}
+MIBINCLUDES!=${ECHO} \"${MIBDIRS:S/^/${MIBSDIR}\//}\"
+MIBINCLUDES:=${MIBINCLUDES:S/ /:/g:S/"//g}
 .else
 MIBINCLUDES="#please add here mibs dirs list (at least snmp and rfc ones)"
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Lars Engels freebsd_committer freebsd_triage 2013-07-02 17:59:33 UTC 
State Changed
From-To: open->closed

Committed. Thanks!