Bug 180212 - net-p2p/museekplus : remove QT3 interface (MUSEEQ and QSA options)
Summary: net-p2p/museekplus : remove QT3 interface (MUSEEQ and QSA options)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 20:00 UTC by Rene Ladan
Modified: 2013-07-17 01:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.59 KB, patch)
2013-07-02 20:00 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2013-07-02 20:00:00 UTC
The MUSEEQ and QSA options of this port depend on the QT3 port, which expired on 2013-07-01. Remove these options from the Makefile.

Leave the MUSEEQ lines in pkg-plist (now always a comment) to ease a possible update to QT4.

Fix pkg-descr while here.

Fix: Patch attached with submission follows:
How-To-Repeat: Run 'make index' after locally removing the QT3/KDE3 ports.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-02 20:00:07 UTC
Maintainer of net-p2p/museekplus,

Please note that PR ports/180212 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180212

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-02 20:00:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2013-07-02 20:20:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Track
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-07-17 01:18:12 UTC
Author: rene
Date: Wed Jul 17 00:18:05 2013
New Revision: 323141
URL: http://svnweb.freebsd.org/changeset/ports/323141

Log:
  - Remove the QSA and MUSEEQ options, they depend on the expired QT 3 port.
  - Fix pkg-descr
  - Bump PORTREVISION, default options changed.
  
  PR:		ports/180212
  Submitted by:	myself
  Approved by:	maintainer timeout (silver@ultrasoft.ee , 15 days)

Modified:
  head/net-p2p/museekplus/Makefile   (contents, props changed)
  head/net-p2p/museekplus/pkg-descr   (contents, props changed)

Modified: head/net-p2p/museekplus/Makefile
==============================================================================
--- head/net-p2p/museekplus/Makefile	Wed Jul 17 00:09:16 2013	(r323140)
+++ head/net-p2p/museekplus/Makefile	Wed Jul 17 00:18:05 2013	(r323141)
@@ -3,7 +3,7 @@
 
 PORTNAME=	museekplus
 PORTVERSION=	0.1.13
-PORTREVISION=	8
+PORTREVISION=	9
 CATEGORIES=	net-p2p
 MASTER_SITES=	SF/museek-plus/museek-plus/${PORTVERSION}
 DISTNAME=	museek+-${PORTVERSION}
@@ -22,10 +22,8 @@ SCONS_ARGS=	QTDIR=${QT_PREFIX} QT_LIB=qt
 DATADIR=	share/museek
 MAN1=		musetup.1 mulog.1 museekcontrol.1 muscan.1 muscand.1 museekd.1
 
-OPTIONS_DEFINE=	MUSEEQ QSA MUSETUPGTK PYMUCIPHER VORBIS MURMUR MUCOUS OPTIMIZED_CFLAGS DEBUG
-OPTIONS_DEFAULT=	MUSEEQ QSA MUSETUPGTK PYMUCIPHER VORBIS
-MUSEEQ_DESC=		Install Museeq (Qt3 client)
-QSA_DESC=		Build Museeq with Qt Script support
+OPTIONS_DEFINE=	MUSETUPGTK PYMUCIPHER VORBIS MURMUR MUCOUS OPTIMIZED_CFLAGS DEBUG
+OPTIONS_DEFAULT=	MUSETUPGTK PYMUCIPHER VORBIS
 MUSETUPGTK_DESC=	Install musetup-gtk
 PYMUCIPHER_DESC=	Install python bindings for Mucipher
 MURMUR_DESC=		Install PyGTK client
@@ -37,22 +35,10 @@ MUCOUS_DESC=		Install Curses Python clie
 USE_PYTHON=	yes
 .endif
 
-.if ${PORT_OPTIONS:MMUSEEQ}
-USE_QT_VER=	3
-SCONS_ARGS+=	MUSEEQ=yes
-MAN1+=		museeq.1
-PLIST_SUB+=	MUSEEQ=""
-.if ${PORT_OPTIONS:MQSA}
-SCONS_ARGS+=	QSA=yes
-LIB_DEPENDS+=	qsa:${PORTSDIR}/devel/qsa
-.else
-SCONS_ARGS+=	QSA=no
-.endif
-.else
 SCONS_ARGS+=	MUSEEQ=no
 PLIST_SUB+=	MUSEEQ="@comment "
 SCONS_ARGS+=	QSA=no
-.endif
+
 .if ${PORT_OPTIONS:MVORBIS}
 SCONS_ARGS+=	VORBIS=yes
 LIB_DEPENDS+=	vorbis:${PORTSDIR}/audio/libvorbis

Modified: head/net-p2p/museekplus/pkg-descr
==============================================================================
--- head/net-p2p/museekplus/pkg-descr	Wed Jul 17 00:09:16 2013	(r323140)
+++ head/net-p2p/museekplus/pkg-descr	Wed Jul 17 00:18:05 2013	(r323141)
@@ -2,4 +2,4 @@ Museek+ (or Museek-Plus) is an enhanced 
 application for the Soulseek peer-to-peer network. The actual SoulSeek client
 and the GUI are separate programs that communicate via Unix or network sockets.
 
-WWW:	http://www.museek-plus.org/
+WWW: http://www.museek-plus.org/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2013-07-17 01:18:20 UTC
State Changed
From-To: feedback->closed

Committed