Bug 180263 - [patch] net-mgmt/dhcdrop: add USE_CSTD=gnu89 for clang
Summary: [patch] net-mgmt/dhcdrop: add USE_CSTD=gnu89 for clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 16:30 UTC by Tijl Coosemans
Modified: 2013-07-23 14:51 UTC (History)
0 users

See Also:


Attachments
dhcdrop.patch (653 bytes, patch)
2013-07-04 16:30 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2013-07-04 16:30:00 UTC
Problems with inline and clang are because clang defaults to C99.
By adding USE_CSTD=gnu89 the post-patch target can be removed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-04 16:30:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-04 16:30:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-04 16:30:09 UTC
Maintainer of net-mgmt/dhcdrop,

Please note that PR ports/180263 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180263

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2013-07-04 20:28:49 UTC
Responsible Changed
From-To: miwi->tijl

Take my own PR.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-07-23 10:47:43 UTC
Author: tijl
Date: Tue Jul 23 09:47:30 2013
New Revision: 323523
URL: http://svnweb.freebsd.org/changeset/ports/323523

Log:
  Add USE_CSTD=gnu89 for clang instead of removing inline.
  
  PR:		180263
  Approved by:	maintainer timeout (19 days)

Modified:
  head/net-mgmt/dhcdrop/Makefile   (contents, props changed)
Directory Properties:
  head/net-mgmt/dhcdrop/distinfo   (props changed)
  head/net-mgmt/dhcdrop/pkg-descr   (props changed)

Modified: head/net-mgmt/dhcdrop/Makefile
==============================================================================
--- head/net-mgmt/dhcdrop/Makefile	Tue Jul 23 08:48:04 2013	(r323522)
+++ head/net-mgmt/dhcdrop/Makefile	Tue Jul 23 09:47:30 2013	(r323523)
@@ -3,6 +3,7 @@
 
 PORTNAME=	dhcdrop
 PORTVERSION=	0.5
+PORTREVISION=	1
 CATEGORIES=	net-mgmt sysutils
 MASTER_SITES=	http://www.netpatch.ru/projects/dhcdrop/
 
@@ -10,6 +11,7 @@ MAINTAINER=	ffault@gmail.com
 COMMENT=	Tool for searching and suppressing false DHCP servers
 
 USE_BZIP2=	yes
+USE_CSTD=	gnu89
 GNU_CONFIGURE=	yes
 
 MAN8=		${PORTNAME}.8
@@ -26,9 +28,4 @@ STATIC_DESC=	Build a static version of d
 CONFIGURE_ARGS+=--enable-static-build
 .endif
 
-post-patch:
-	@${REINPLACE_CMD} -e \
-		's,inline void rand_ether_addr,static void rand_ether_addr,' \
-			${WRKSRC}/src/dhcdrop.[c,h]
-
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2013-07-23 14:50:24 UTC
State Changed
From-To: feedback->closed

Committed in r323523.