Bug 180273 - games/nethack33 : remove QT3 support
Summary: games/nethack33 : remove QT3 support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 17:40 UTC by Rene Ladan
Modified: 2013-07-10 02:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.94 KB, patch)
2013-07-04 17:40 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2013-07-04 17:40:00 UTC
Remove support for the expired QT3 (or even QT2 ?) port.
While here convert Makefile header NOPORTDOCS

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-04 17:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glewis

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-07-10 02:31:27 UTC
Author: glewis
Date: Wed Jul 10 01:31:18 2013
New Revision: 322594
URL: http://svnweb.freebsd.org/changeset/ports/322594

Log:
  . Remove the vestiges of support for the expired QT2 port.
  . Convert Makefile header.
  . NOPORTDOCS -> PORT_OPTIONS:MDOCS.
  
  PR:		180273
  Submitted by:	rene@

Modified:
  head/games/nethack33/Makefile   (contents, props changed)

Modified: head/games/nethack33/Makefile
==============================================================================
--- head/games/nethack33/Makefile	Wed Jul 10 01:19:12 2013	(r322593)
+++ head/games/nethack33/Makefile	Wed Jul 10 01:31:18 2013	(r322594)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	nethack
-# Date created:		27 March 1995
-# Whom:			asami
-#
+# Created by: asami
 # $FreeBSD$
-#
 
 PORTNAME=	nethack
 PORTVERSION=	3.3.1
@@ -47,16 +43,13 @@ USE_GNOME=	gnomelibs
 GRAPHICS=	GNOME_GRAPHICS
 .elif ${PKGNAMESUFFIX} == "-nox11"
 GRAPHICS=	# none
-.elif ${PKGNAMESUFFIX} == "-qt"
-USE_QT_VER=	2
-MAKE_ENV+=	QTCPPFLAGS="${QTCPPFLAGS}" QTCFGLIBS="${QTCFGLIBS}" \
-		MOC="${MOC}" LIBQT="-l${QTNAME}"
-GRAPHICS=	QT_GRAPHICS
 .endif
 .endif
 
 .include <bsd.port.pre.mk>
 
+.include <bsd.port.options.mk>
+
 .if !exists(${PREFIX}/bin/${HACKLINK}) && ${HACKNAME} != ${HACKLINK}
 PLIST_SUB+=	HACKLINK=""
 .else
@@ -64,7 +57,7 @@ PLIST_SUB+=	HACKLINK="@comment "
 .endif
 
 pre-everything::
-.if defined(WITH_GNOME_GRAPHICS) || defined(WITH_QT_GRAPHICS) \
+.if defined(WITH_GNOME_GRAPHICS) \
 		|| defined(WITH_TTY_GRAPHICS) || defined(WITHOUT_X11)
 	@${ECHO_MSG} "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
 	@${ECHO_MSG} " You cannot install nethack and ${PKGBASE} in parallel   "
@@ -76,7 +69,6 @@ pre-everything::
 	@${ECHO_MSG} "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
 	@${ECHO_MSG} " You may use the following build options:                "
 	@${ECHO_MSG} " WITH_GNOME_GRAPHICS=yes            build with GNOME GUI "
-	@${ECHO_MSG} " WITH_QT_GRAPHICS=yes               build with Qt GUI    "
 	@${ECHO_MSG} " WITH_TTY_GRAPHICS=yes              build with no GUI    "
 	@${ECHO_MSG} " WITHOUT_X11=yes                    same as above        "
 	@${ECHO_MSG} "                                                         "
@@ -114,7 +106,7 @@ post-install:
 	@${LN} -s -f ${PREFIX}/bin/${HACKNAME} ${PREFIX}/bin/${HACKLINK}
 .endif
 	@cd ${WRKSRC}/doc; ${SETENV} ${MAKE_ENV} ${MAKE} manpages
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/Guidebook.txt ${DOCSDIR}
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Greg Lewis freebsd_committer freebsd_triage 2013-07-10 02:31:37 UTC
State Changed
From-To: open->closed

Committed. Thanks!