Bug 180370 - [patch] net-mgmt/collectd5 Fix build with PGSQL and GCRYPT
Summary: [patch] net-mgmt/collectd5 Fix build with PGSQL and GCRYPT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-07 20:50 UTC by Brad Davis
Modified: 2013-07-07 23:00 UTC (History)
0 users

See Also:


Attachments
collectd5-build.diff (1.11 KB, patch)
2013-07-07 20:50 UTC, Brad Davis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer freebsd_triage 2013-07-07 20:50:00 UTC
	- Fix a few typos in the descriptions
	- Fix build with PGSQL
	- Fix build with GCRYPT
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-07 20:50:07 UTC
Maintainer of net-mgmt/collectd5,

Please note that PR ports/180370 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180370

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-07 20:50:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Krzysztof 2013-07-07 21:48:05 UTC
Hello,

On Sun, Jul 07, 2013 at 07:50:07PM +0000, Edwin Groothuis wrote:
> Maintainer of net-mgmt/collectd5,
> 
> Please note that PR ports/180370 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180370
> 
Yes, I 've found bug with pgsql plugin lately. I wanted to make a PR,
but it seems, that someone did it earlier :-)))

So I apporve this patch. Thank a lot for your work Brad and Edwin.

Greetings,
-- 
Krzysztof Stryjek
UNIX administrator/Juniper Networks Specialist
email: wtp (at) bsdserwis (dot) com
http://www.linkedin.com/in/KrzysztofStryjek
GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76

In theory, there is no difference between theory and practice.
In practice, there is.
Comment 4 William Grzybowski freebsd_committer freebsd_triage 2013-07-07 22:53:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 5 William Grzybowski freebsd_committer freebsd_triage 2013-07-07 22:55:48 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-07-07 22:55:51 UTC
Author: wg
Date: Sun Jul  7 21:55:43 2013
New Revision: 322460
URL: http://svnweb.freebsd.org/changeset/ports/322460

Log:
  net-mgmt/collectd5: fix build with PGSQL and GCRYPT
  
  - Fix build with PGSQL and GCRYPT
  - Fix typo in a couple descriptions
  
  PR:		ports/180370
  Submitted by:	brd
  Approved by:	maintainer

Modified:
  head/net-mgmt/collectd5/Makefile

Modified: head/net-mgmt/collectd5/Makefile
==============================================================================
--- head/net-mgmt/collectd5/Makefile	Sun Jul  7 21:41:02 2013	(r322459)
+++ head/net-mgmt/collectd5/Makefile	Sun Jul  7 21:55:43 2013	(r322460)
@@ -27,9 +27,9 @@ GCRYPT_DESC=		Build with libgcrypt
 JSON_DESC=		Enable JSON plugins
 MEMCACHEC_DESC=		Enable memcachec plugin
 MODBUS_DESC=		Enable modbus plugin
-MYSQL_DESC=		Enable mysql-basd plugins
+MYSQL_DESC=		Enable mysql-based plugins
 NUTUPS_DESC=		Enable nut (ups) plugin
-PGSQL_DESC=		Enable postgresql-basd plugins
+PGSQL_DESC=		Enable postgresql-based plugins
 PING_DESC=		Enable ping plugin
 PYTHON_DESC=		Enable python-based plugins
 REDIS_DESC=		Enable redis-based plugins
@@ -206,6 +206,7 @@ PLIST_SUB+=	DBI="@comment "
 .if ${PORT_OPTIONS:MGCRYPT}
 LIB_DEPENDS+=	gcrypt:${PORTSDIR}/security/libgcrypt
 CONFIGURE_ARGS+=--with-libgcrypt=${LOCALBASE}
+LDFLAGS+=	-lgcrypt
 .endif
 
 .if ${PORT_OPTIONS:MJSON}
@@ -258,7 +259,7 @@ PLIST_SUB+=	NUTUPS="@comment "
 
 .if ${PORT_OPTIONS:MPGSQL}
 USE_PGSQL=	yes
-CONFIGURE_ARGS+=--with-postgresql=${LOCALBASE} --enable-postgresql
+CONFIGURE_ARGS+=--with-postgresql=${LOCALBASE} --enable-postgresql --with-libpq
 PLIST_SUB+=	PGSQL=""
 .else
 PLIST_SUB+=	PGSQL="@comment "
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"