For options that actually require CURL, check to see if it is enabled before we even try to build
Maintainer of net-mgmt/collectd, Please note that PR ports/180376 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180376 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hello, On Mon, Jul 08, 2013 at 05:00:07AM +0000, Edwin Groothuis wrote: > Maintainer of net-mgmt/collectd, > > Please note that PR ports/180376 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180376 > Yes, I approve this patch. Greetings, -- Krzysztof Stryjek UNIX administrator/Juniper Networks Specialist email: wtp (at) bsdserwis (dot) com http://www.linkedin.com/in/KrzysztofStryjek GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C 91CD 1292 8959 DC61 0E76 In theory, there is no difference between theory and practice. In practice, there is.
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->wg I'll take it.
State Changed From-To: open->closed Committed. Thanks!
Author: wg Date: Mon Jul 8 21:49:14 2013 New Revision: 322541 URL: http://svnweb.freebsd.org/changeset/ports/322541 Log: net-mgmt/collectd: sanity checking for options requiring CURL For options that actually require CURL, check to see if it is enabled before we even try to build. PR: ports/180376 Submitted by: brd Approved by: maintainer Modified: head/net-mgmt/collectd/Makefile Modified: head/net-mgmt/collectd/Makefile ============================================================================== --- head/net-mgmt/collectd/Makefile Mon Jul 8 21:31:53 2013 (r322540) +++ head/net-mgmt/collectd/Makefile Mon Jul 8 21:49:14 2013 (r322541) @@ -155,6 +155,9 @@ CONFIGURE_ARGS+=--enable-bind LIB_DEPENDS+= curl:${PORTSDIR}/ftp/curl LIB_DEPENDS+= xml2:${PORTSDIR}/textproc/libxml2 PLIST_SUB+= BIND="" +. if empty(PORT_OPTIONS:MCURL) +IGNORE= BIND requires CURL. Either select CURL or deselect BIND +. endif .else CONFIGURE_ARGS+=--disable-bind PLIST_SUB+= BIND="@comment " @@ -164,6 +167,9 @@ PLIST_SUB+= BIND="@comment " CONFIGURE_ARGS+=--enable-apache LIB_DEPENDS+= curl:${PORTSDIR}/ftp/curl PLIST_SUB+= APACHE="" +. if empty(PORT_OPTIONS:MCURL) +IGNORE= APACHE requires CURL. Either select CURL or deselect APACHE +. endif .else CONFIGURE_ARGS+=--disable-apache PLIST_SUB+= APACHE="@comment " @@ -285,6 +291,9 @@ PLIST_SUB+= MYSQL="@comment " LIB_DEPENDS+= curl:${PORTSDIR}/ftp/curl CONFIGURE_ARGS+=--enable-nginx PLIST_SUB+= NGINX="" +. if empty(PORT_OPTIONS:MCURL) +IGNORE= NGINX requires CURL. Either select CURL or deselect NGINX +. endif .else CONFIGURE_ARGS+=--disable-nginx PLIST_SUB+= NGINX="@comment " _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"