Bug 180384 - [PATCH] x11/dzen2 hardcodes gcc
Summary: [PATCH] x11/dzen2 hardcodes gcc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-08 15:30 UTC by Niclas Zeising
Modified: 2013-08-08 00:40 UTC (History)
0 users

See Also:

Attachments
x11.dzen2.clangfix.diff (784 bytes, patch)
2013-07-08 15:30 UTC, Niclas Zeising 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising 2013-07-08 15:30:00 UTC 
	x11/dzen2 hardcodes CC=gcc in its makefile.

Fix: Attached patch changes the default to use cc, and makes it possible to override CC in the environment.  This makes the port build with clang, or when gcc does not exists.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-08 15:30:08 UTC 
Maintainer of x11/dzen2,

Please note that PR ports/180384 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180384

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-08 15:30:09 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2013-07-08 15:35:40 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->zeising

Grab, since I sent it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-08-08 00:36:51 UTC 
Author: zeising
Date: Wed Aug  7 23:36:35 2013
New Revision: 324372
URL: http://svnweb.freebsd.org/changeset/ports/324372

Log:
  Don't hardcode the use of gcc.
  
  PR:		ports/180384
  Submitted by:	zeising
  Approved by:	Maintainer timeout (one month)

Added:
  head/x11/dzen2/files/
  head/x11/dzen2/files/patch-config.mk   (contents, props changed)

Added: head/x11/dzen2/files/patch-config.mk
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/x11/dzen2/files/patch-config.mk	Wed Aug  7 23:36:35 2013	(r324372)
@@ -0,0 +1,9 @@
+--- config.mk.orig	2013-07-03 22:32:45.866885213 +0200
++++ config.mk	2013-07-03 22:32:51.306100406 +0200
+@@ -49,5 +49,5 @@
+ #LDFLAGS = -g ${LIBS}
+ 
+ # compiler and linker
+-CC = gcc
++CC ?= cc
+ LD = ${CC}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Niclas Zeising freebsd_committer freebsd_triage 2013-08-08 00:36:54 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!