Bug 180412 - audio/musicpd: Radio buttons: shoutcast, tremor, vorbis
Summary: audio/musicpd: Radio buttons: shoutcast, tremor, vorbis
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-09 13:00 UTC by Kalten
Modified: 2013-08-09 13:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kalten 2013-07-09 13:00:00 UTC
I think we nedd some OPTIONS_RADIO entries for shoutcast, tremor and vorbis.

---SCHNIPP---
===>  musicpd-0.17.3_1 shoutcast and tremor do not coexist; use vorbis instead.
*** [all] Error code 1

Stop in /usr/ports.portsnap/audio/musicpd.
---schnapp---

Maybe someone could correct this. :-)

Fix: 

selecting either (SHOUTCAST and no-TREMOR and VORBIS) or (no-SHOUTCAST and TREMOR and VORBIS)---the problem screams for OPTIONS_RADIO and may be some comment about it in the knobs' descriptions.
How-To-Repeat: ``make config'' and select (SHOUTCAST and TREMOR) or (SHOUTCAST and TREMOR and VORBIS), then ``make''.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-09 13:00:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer freebsd_triage 2013-07-10 20:07:03 UTC
State Changed
From-To: open->feedback

I don't think a radio button is right here.  Vorbis has nothing to do 
with the conflicts, it just solves it.  Are you suggesting a radio 
between SHOUTCAST and TREMOR?
Comment 3 Kalten 2013-07-13 16:03:47 UTC
Hello Crees!

>> shoutcast and tremor do not coexist; use vorbis instead.
> I don't think a radio button is right here.  Vorbis has nothing to do
> with the conflicts, it just solves it.
If it solves it, it does not have nothing to do with it ;-)
And the error messages suggests to ``use vorbis instead'' so why no
radio button, or the error message is totally misleading. :-(

> Are you suggesting a radio between SHOUTCAST and TREMOR?
Well: if ``shoutcast and tremor do not coexist'', sure, it would reflect
the error message.

Anyway: the user should be able to know what to do ere he hits OK in the
options dialog and not have to wait for the compiler to tell him, his
choice had been wrong after getting up from bed and being, lets say,
``unhappy'' about the fact, that there is not everything done. At least
one could describe the conflict and its solution in some way allready in
the descriptions of the knobs.

ru,
 Kalten
--
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-08-09 13:21:49 UTC
Author: crees
Date: Fri Aug  9 12:21:41 2013
New Revision: 324431
URL: http://svnweb.freebsd.org/changeset/ports/324431

Log:
  Improve TREMOR description to make it explicit that it may not be used with
  SHOUTCAST
  
  PR:		ports/180412

Modified:
  head/audio/musicpd/Makefile

Modified: head/audio/musicpd/Makefile
==============================================================================
--- head/audio/musicpd/Makefile	Fri Aug  9 12:16:33 2013	(r324430)
+++ head/audio/musicpd/Makefile	Fri Aug  9 12:21:41 2013	(r324431)
@@ -8,7 +8,7 @@ MASTER_SITES=	SF/${PORTNAME}/mpd/${PORTV
 DISTNAME=	mpd-${PORTVERSION}
 
 MAINTAINER=	crees@FreeBSD.org
-COMMENT=	A remote-controllable music daemon
+COMMENT=	Remote-controllable music daemon
 
 LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/libmad \
 		curl:${PORTSDIR}/ftp/curl
@@ -41,6 +41,8 @@ OPTIONS_DEFINE=	ID3TAG IPV6 FLAC VORBIS 
 OPTIONS_RADIO=	ZEROCONF
 OPTIONS_RADIO_ZEROCONF=	AVAHI MDNSRESPONDER
 
+TREMOR_DESC=	Tremor decoder (not with SHOUTCAST; use VORBIS)
+
 OPTIONS_DEFAULT=ID3TAG IPV6 FLAC VORBIS WAV FFMPEG SNDFILE
 LAME_DESC=	Support for MP3 Icecast Streams
 
@@ -171,7 +173,9 @@ LIB_DEPENDS+=	id3tag.0:${PORTSDIR}/audio
 CONFIGURE_ARGS+=--disable-id3
 .endif
 
-.if empty(PORT_OPTIONS:MIPV6)
+.if ${PORT_OPTIONS:MIPV6}
+CONFIGURE_ARGS+=--enable-ipv6
+.else
 CONFIGURE_ARGS+=--disable-ipv6
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Chris Rees freebsd_committer freebsd_triage 2013-08-09 13:25:04 UTC
State Changed
From-To: feedback->closed

I've changed the description of the TREMOR option to  make the situation 
clear.