Bug 180611 - [patch] update cad/feappv
Summary: [patch] update cad/feappv
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 17:10 UTC by Anton Shterenlikht
Modified: 2013-08-25 13:50 UTC (History)
0 users

See Also:


Attachments
feappv.diff (2.38 KB, patch)
2013-07-17 17:10 UTC, Anton Shterenlikht
no flags Details | Diff
feappv.diff2 (2.65 KB, text/plain; charset=us-ascii)
2013-07-24 20:31 UTC, Anton Shterenlikht
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Shterenlikht 2013-07-17 17:10:00 UTC
- updated the port to the latest version
- updated the Makefile header
- updated pkg-descr

Two issues:

1. for some reason the file permissions after
applying the svn patch are 600. I don't know how
to fix this. If you know I'll provide an updated
patch, of if it's easy to fix, maybe you can fix it.

2. The port installs a library: /usr/local/lib/libfeappv.a.
The library name has changed in this version.
I'm not sure which other ports might depend on this library.
Perhaps a note should be made to ports/UPDATING that
any users of this library should relink and better
recompile/relink their codes.
Comment 1 Anton Shterenlikht 2013-07-24 20:31:12 UTC
Please ignore the previous patch and use this instead.

- added myself as a maintainer

The two issues mentioned above still need to be
looked into. This is beyond my knowledge.
Comment 2 Anton Shterenlikht 2013-07-25 01:01:45 UTC
forgot to say, I tested this patch on redports.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-08-25 13:42:03 UTC
Author: danfe
Date: Sun Aug 25 12:41:50 2013
New Revision: 325342
URL: http://svnweb.freebsd.org/changeset/ports/325342

Log:
  - Update to version from 12 August 2013
  - Give maintainership to submitter
  - Cleanup the port a bit while I'm at it
  
  PR:	ports/180611

Modified:
  head/cad/feappv/Makefile
  head/cad/feappv/distinfo
  head/cad/feappv/pkg-descr

Modified: head/cad/feappv/Makefile
==============================================================================
--- head/cad/feappv/Makefile	Sun Aug 25 12:30:09 2013	(r325341)
+++ head/cad/feappv/Makefile	Sun Aug 25 12:41:50 2013	(r325342)
@@ -1,45 +1,37 @@
-# New ports collection makefile for:	FEAPpv
-# Date created:		29 Feb 2006
-# Whom:			Pedro F. Giffuni
-#
+# Created by: Pedro F. Giffuni <giffunip@asme.org>
 # $FreeBSD$
-#
 
 PORTNAME=	feappv
 PORTVERSION=	3.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	cad science
 MASTER_SITES=	http://www.ce.berkeley.edu/projects/feap/feappv/
-DISTFILES=	${PORTNAME}${PORTVERSION:S/.//}${EXTRACT_SUFX} ${PDF_MANUAL}
+DISTFILES=	${PORTNAME}${PORTVERSION:S/.//}${EXTRACT_SUFX} ${PORTDOCS}
 DIST_SUBDIR=	${PORTNAME}${PORTVERSION:S/.//}
 EXTRACT_ONLY=	${PORTNAME}${PORTVERSION:S/.//}${EXTRACT_SUFX}
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	Finite Element Analysis Program "personal version"
-
-OPTIONS_DEFINE=	DOCS
-
-WRKSRC=		${WRKDIR}/ver${PORTVERSION:S/.//}
+MAINTAINER=	mexas@bris.ac.uk
+COMMENT=	Finite element analysis program (personal version)
 
+USES=		gmake
 USE_ZIP=	yes
 USE_XORG=	x11
 USE_FORTRAN=	yes
-USE_GMAKE=	yes
 MAKEFILE=	makefile
 MAKE_ENV=	FEAPPVHOME3_1="${WRKSRC}"
 ALL_TARGET=	install
 
+WRKSRC=		${WRKDIR}/ver${PORTVERSION:S/.//}
+
 CFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib -lX11 -lm
 
-PORTDOCS=	*
-PLIST_FILES=	bin/feappv lib/Feappv_gnu.a
+PLIST_FILES=	bin/feappv lib/libfeappv.a
+PORTDOCS=	manual.pdf
 
-.include <bsd.port.options.mk>
+OPTIONS_DEFINE=	DOCS
 
-.if ${PORT_OPTIONS:MDOCS}
-PDF_MANUAL=	manual.pdf
-.endif
+.include <bsd.port.options.mk>
 
 post-patch:
 	@${REINPLACE_CMD} -e \
@@ -54,10 +46,10 @@ post-patch:
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/main/feappv ${PREFIX}/bin
-	${INSTALL_DATA} ${WRKSRC}/Feappv_gnu.a ${PREFIX}/lib
+	${INSTALL_DATA} ${WRKSRC}/libfeappv.a ${PREFIX}/lib
 .if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/manual.pdf ${DOCSDIR}
+	${INSTALL_DATA} ${_DISTDIR}/${PORTDOCS} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>

Modified: head/cad/feappv/distinfo
==============================================================================
--- head/cad/feappv/distinfo	Sun Aug 25 12:30:09 2013	(r325341)
+++ head/cad/feappv/distinfo	Sun Aug 25 12:41:50 2013	(r325342)
@@ -1,4 +1,4 @@
-SHA256 (feappv31/feappv31.zip) = cfd38f80c27d8010db1d270e13846e9b68d84bf77ee71659278b2b207b4b71e5
-SIZE (feappv31/feappv31.zip) = 613363
+SHA256 (feappv31/feappv31.zip) = e1edbced934474b0839857ce799a6cc6b31961b7c0acae8ee70ce2f1efa26791
+SIZE (feappv31/feappv31.zip) = 615732
 SHA256 (feappv31/manual.pdf) = f3c6d5ac9c310852dfcde0c74c22df7388fcc6230e30630f70d591c50fd93832
 SIZE (feappv31/manual.pdf) = 649124

Modified: head/cad/feappv/pkg-descr
==============================================================================
--- head/cad/feappv/pkg-descr	Sun Aug 25 12:30:09 2013	(r325341)
+++ head/cad/feappv/pkg-descr	Sun Aug 25 12:41:50 2013	(r325342)
@@ -5,9 +5,9 @@ references:
 The Finite Element Method, 6th ed., Vols. 1 and 2, by O.C. Zienkiewicz and
 R.L. Taylor, Elsevier, Oxford, 2005.
 
-FEAPpv is designed to be compatible for compilation in UNIX/LINUX and 
+FEAPpv is designed to be compatible for compilation in Unix/Linux and
 Windows PC environments.
 
-WWW:  http://www.ce.berkeley.edu/projects/feap/feappv/
-
 No support on use of the program will be provided.
+
+WWW: http://www.ce.berkeley.edu/projects/feap/feappv/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2013-08-25 13:42:21 UTC
State Changed
From-To: open->closed

Committed with modifications, thanks!  No UPDATING note is necessary as this 
port is not anyone's dependency (in the tree) and hardly has large user base 
to warrant such (pretty obvious) note.