The patch for adding syslog support sets the wrong define variable causing syslog support to not be built. Port maintainer (osa@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Responsible Changed From-To: freebsd-ports-bugs->osa Over to maintainer (via the GNATS Auto Assign Tool)
Any update on this issue?
State Changed From-To: open->closed Committed, thanks!
Author: mat Date: Mon Dec 2 18:14:19 2013 New Revision: 335523 URL: http://svnweb.freebsd.org/changeset/ports/335523 Log: The patch for adding syslog support sets the wrong define variable causing syslog support to not be built. maintainer timeout. PR: ports/180639 Submitted by: Dave Duchscher Modified: head/www/nginx/Makefile head/www/nginx/files/extra-patch-syslog_support Modified: head/www/nginx/Makefile ============================================================================== --- head/www/nginx/Makefile Mon Dec 2 18:08:41 2013 (r335522) +++ head/www/nginx/Makefile Mon Dec 2 18:14:19 2013 (r335523) @@ -3,6 +3,7 @@ PORTNAME= nginx PORTVERSION= 1.4.4 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= www MASTER_SITES= http://nginx.org/download/ Modified: head/www/nginx/files/extra-patch-syslog_support ============================================================================== --- head/www/nginx/files/extra-patch-syslog_support Mon Dec 2 18:08:41 2013 (r335522) +++ head/www/nginx/files/extra-patch-syslog_support Mon Dec 2 18:14:19 2013 (r335523) @@ -721,7 +721,7 @@ index 54e1c26..2b05157 100644 + SYSLOG_FACILITY="LOG_DAEMON" +fi +if test "${USE_SYSLOG}" = "YES"; then -+ CFLAGS="$CFLAGS -DUSE_SYSLOG -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" ++ CFLAGS="$CFLAGS -DNGX_ENABLE_SYSLOG -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" +fi cat << END > $NGX_MAKEFILE _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: closed->open Re-open the ticket.
Responsible Changed From-To: osa->mat Revert back these changes.
Responsible Changed From-To: mat->osa Back to you, but if these changes are wrong, you should say so, and not let the PR get stale for 4 months :-)
Do you know when this issue will be fixed? We are having to patch the nginx port every time we updated our tree. -- DaveD
Author: osa Date: Tue Dec 3 18:08:20 2013 New Revision: 335584 URL: http://svnweb.freebsd.org/changeset/ports/335584 Log: Fix syslog support. Do not bump PORTREVISION cause syslog support disabled by default. Patch from: rea PR: ports/180639 Modified: head/www/nginx/files/extra-patch-syslog_support Modified: head/www/nginx/files/extra-patch-syslog_support ============================================================================== --- head/www/nginx/files/extra-patch-syslog_support Tue Dec 3 17:47:15 2013 (r335583) +++ head/www/nginx/files/extra-patch-syslog_support Tue Dec 3 18:08:20 2013 (r335584) @@ -347,14 +347,16 @@ diff --git src/core/ngx_log.h src/core/n index 3233647..5e7fdbf 100644 --- src/core/ngx_log.h +++ src/core/ngx_log.h -@@ -12,6 +12,13 @@ +@@ -12,6 +12,15 @@ #include <ngx_config.h> #include <ngx_core.h> +#if (NGX_ENABLE_SYSLOG) +#include <syslog.h> + ++#ifndef SYSLOG_FACILITY +#define SYSLOG_FACILITY LOG_LOCAL5 ++#endif +#define ERR_SYSLOG_PRIORITY LOG_ERR +#endif + @@ -721,7 +723,7 @@ index 54e1c26..2b05157 100644 + SYSLOG_FACILITY="LOG_DAEMON" +fi +if test "${USE_SYSLOG}" = "YES"; then -+ CFLAGS="$CFLAGS -DUSE_SYSLOG -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" ++ CFLAGS="$CFLAGS -DNGX_ENABLE_SYSLOG -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" +fi cat << END > $NGX_MAKEFILE _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed with modifications.