Bug 180877 - [PATCH] converters/iconv: optional perl run depend
Summary: [PATCH] converters/iconv: optional perl run depend
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexander Nedotsukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-26 13:30 UTC by William Grzybowski
Modified: 2013-08-21 14:10 UTC (History)
0 users

See Also:


Attachments
iconv.patch (2.05 KB, patch)
2013-07-26 13:30 UTC, William Grzybowski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Grzybowski freebsd_committer freebsd_triage 2013-07-26 13:30:00 UTC
	Currently perl is a run dependency due to iconv_mktbl which is written in perl.
	Proposed patch add an option to do not install it, leaving us free of perl as run dependency.
	I also removed the PROFILE plist sub which is not used.

Fix: See attached patch
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-26 13:30:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bland

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-08-21 14:08:52 UTC
Author: wg
Date: Wed Aug 21 13:08:44 2013
New Revision: 325125
URL: http://svnweb.freebsd.org/changeset/ports/325125

Log:
  converters/iconv: make iconv_mktbl optional
  
  - Add a default option called CSSUTIL which installs iconv_mktbl and pulls in
    perl as a run dependency
  
  PR:		ports/180877
  Submitted by:	wg (myself)
  Approved by:	maintainer (timeout)

Added:
  head/converters/iconv/files/extra-patch-ccs_Makefile   (contents, props changed)
Modified:
  head/converters/iconv/Makefile
  head/converters/iconv/pkg-plist

Modified: head/converters/iconv/Makefile
==============================================================================
--- head/converters/iconv/Makefile	Wed Aug 21 13:07:03 2013	(r325124)
+++ head/converters/iconv/Makefile	Wed Aug 21 13:08:44 2013	(r325125)
@@ -12,7 +12,7 @@ MAINTAINER=	bland@FreeBSD.org
 COMMENT=	Charset conversion library and utilities
 
 USES=		shebangfix
-USE_PERL5=	yes
+USE_PERL5_BUILD=yes
 USE_LDCONFIG=	yes
 SHEBANG_FILES=	iconv_builtin ccs/iconv_mktbl
 
@@ -20,10 +20,19 @@ MANCOMPRESSED=	yes
 MAN1=		biconv.1
 MAN3=		biconv.3 biconv_open.3 biconv_close.3
 
-.if defined(NO_PROFILE) || defined(NOPROFILE) || defined(WITHOUT_PROFILE)
-PLIST_SUB=	PROFILE:="@comment "
+OPTIONS_DEFINE=	CCSUTIL
+OPTIONS_DEFAULT=CCSUTIL
+
+OPTIONS_SUB=	yes
+
+CCSUTIL_DESC=	Install Coded character set (CCS) util
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MCCSUTIL}
+USE_PERL5_RUN=	yes
 .else
-PLIST_SUB=	PROFILE:=""
+EXTRA_PATCHES=	${FILESDIR}/extra-patch-ccs_Makefile
 .endif
 
 .include <bsd.port.mk>

Added: head/converters/iconv/files/extra-patch-ccs_Makefile
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/converters/iconv/files/extra-patch-ccs_Makefile	Wed Aug 21 13:08:44 2013	(r325125)
@@ -0,0 +1,13 @@
+diff --git ccs/Makefile ccs/Makefile
+index b61420c..faffe0f 100644
+--- ccs/Makefile
++++ ccs/Makefile
+@@ -67,8 +67,6 @@ beforeinstall:
+ 	cd ${.CURDIR}; \
+ 	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m 444 \
+ 		${INSTALLFLAGS} ${CHARSETS_TBL} ${DESTDIR}${TABLEDIR}; \
+-	${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
+-		iconv_mktbl ${DESTDIR}${BINDIR}
+ 
+ CLEANFILES +=	*.c *.cct
+ 

Modified: head/converters/iconv/pkg-plist
==============================================================================
--- head/converters/iconv/pkg-plist	Wed Aug 21 13:07:03 2013	(r325124)
+++ head/converters/iconv/pkg-plist	Wed Aug 21 13:08:44 2013	(r325125)
@@ -1,10 +1,10 @@
 bin/biconv
-bin/iconv_mktbl
+%%CCSUTIL%%bin/iconv_mktbl
 include/biconv.h
 lib/libbiconv.a
 lib/libbiconv.so
 lib/libbiconv.so.2
-%%PROFILE:%%lib/libbiconv_p.a
+lib/libbiconv_p.a
 libexec/iconv/euc-jp.so
 libexec/iconv/euc-kr.so
 libexec/iconv/euc-tw.so
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-08-21 14:08:57 UTC
State Changed
From-To: open->closed

Committed. Thanks!