Bug 181367 - [PATCH] fix "__asm volatime" issue on devel/gobject-introspection
Summary: [PATCH] fix "__asm volatime" issue on devel/gobject-introspection
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-18 02:30 UTC by Takeshi Taguchi
Modified: 2013-08-18 16:40 UTC (History)
0 users

See Also:


Attachments
file.diff (565 bytes, patch)
2013-08-18 02:30 UTC, Takeshi Taguchi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takeshi Taguchi 2013-08-18 02:30:00 UTC
devel/gobject-intrispection can not deal "__asm volatile".
for example graphics/gdk-pixmap2 build-depend on this ports produces
folowing compile log:
..
g-ir-scanner: warning: Option --strip-prefix has been deprecated;
see --identifier-prefix and --symbol-prefix.
/usr/include/machine/endian.h:90: syntax error, unexpected identifier, expecting ',' or ';' in ' __asm volatile("eor %1, %0, %0, ror #16\n"' at 'o'
/usr/include/machine/endian.h:104: syntax error, unexpected identifier, expecting ',' or ';' in ' __asm volatile(' at 'o'
  GICOMP GdkPixbuf-2.0.gir
..

Fix: NetBSD people fix this issue.
see: http://gnats.netbsd.org/46017

add attached file to gobject-introspection/files/

Patch attached with submission follows:
How-To-Repeat: # cd /usr/ports/graphics/gdk-pixbuf2
# make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-18 02:30:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-08-18 16:38:04 UTC
Author: kwm
Date: Sun Aug 18 15:37:57 2013
New Revision: 324926
URL: http://svnweb.freebsd.org/changeset/ports/324926

Log:
  Fix __asm volatile warnings from g-ir-scanner.
  
  Take patch from pkgsrc because the PR patch isn't complete.
  
  PR:		ports/181367
  Submitted by:	Takeshi Taguchi <taguchi@ff.iij4u.or.jp>
  Obtained from:	NetBSD pkgsrc

Added:
  head/devel/gobject-introspection/files/patch-giscanner_scannerlexer.l   (contents, props changed)
Modified:
  head/devel/gobject-introspection/Makefile

Modified: head/devel/gobject-introspection/Makefile
==============================================================================
--- head/devel/gobject-introspection/Makefile	Sun Aug 18 15:25:24 2013	(r324925)
+++ head/devel/gobject-introspection/Makefile	Sun Aug 18 15:37:57 2013	(r324926)
@@ -1,10 +1,10 @@
 # Created by: Alexander Logvinov <avl@FreeBSD.org>
 # $FreeBSD$
-#   $MCom: ports/trunk/devel/gobject-introspection/Makefile 18634 2013-07-26 10:42:35Z kwm $
+#   $MCom: ports/trunk/devel/gobject-introspection/Makefile 18652 2013-08-18 15:14:13Z kwm $
 
 PORTNAME=	gobject-introspection
 PORTVERSION=	1.36.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	GNOME
 DIST_SUBDIR=	gnome3

Added: head/devel/gobject-introspection/files/patch-giscanner_scannerlexer.l
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/gobject-introspection/files/patch-giscanner_scannerlexer.l	Sun Aug 18 15:37:57 2013	(r324926)
@@ -0,0 +1,25 @@
+$NetBSD: patch-giscanner_scannerlexer.l,v 1.2 2013/05/05 09:20:44 drochner Exp $
+
+Ignore __asm volatile as per PR pkg/46017
+https://bugzilla.gnome.org/show_bug.cgi?id=678794
+
+--- giscanner/scannerlexer.l.orig	2012-12-18 16:27:16.000000000 +0000
++++ giscanner/scannerlexer.l
+@@ -134,6 +134,8 @@ stringtext				([^\\\"])|(\\.)
+ ","					{ return ','; }
+ "->"					{ return ARROW; }
+ 
++"__asm"[\t\f\v\r ]+"volatile"		{ if (!parse_ignored_macro()) REJECT; }
++"__asm__"[\t\f\v\r ]+"volatile"		{ if (!parse_ignored_macro()) REJECT; }
+ "__asm" 	        	        { if (!parse_ignored_macro()) REJECT; }
+ "__asm__" 	        	        { if (!parse_ignored_macro()) REJECT; }
+ "__attribute__" 		        { if (!parse_ignored_macro()) REJECT; }
+@@ -145,6 +147,8 @@ stringtext				([^\\\"])|(\\.)
+ "__signed__"				{ return SIGNED; }
+ "__restrict"				{ return RESTRICT; }
+ "__typeof"				{ if (!parse_ignored_macro()) REJECT; }
++"__volatile"				{ if (!parse_ignored_macro()) REJECT; }
++"__volatile__"				{ if (!parse_ignored_macro()) REJECT; }
+ "_Bool"					{ return BOOL; }
+ 
+ "G_GINT64_CONSTANT"			{ return INTL_CONST; }
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer freebsd_triage 2013-08-18 16:38:18 UTC
State Changed
From-To: open->closed

Committed the patch from NetBSD pkgsrc directly. Thanks for reporting!