Bug 181504 - devel/liboil: Fix build error by CC=clang
Summary: devel/liboil: Fix build error by CC=clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-24 16:50 UTC by Norikatsu Shigemura
Modified: 2013-10-19 12:20 UTC (History)
0 users

See Also:

Attachments
file.diff (320 bytes, patch)
2013-08-24 16:50 UTC, Norikatsu Shigemura 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Norikatsu Shigemura freebsd_committer freebsd_triage 2013-08-24 16:50:00 UTC 
liboil's Makefile defined USE_GCC=any, so not use clang.
But there is clang test code, so no longer use.

Fix: Please apply my patch.

Patch attached with submission follows:
How-To-Repeat: $ cd /usr/ports/devel/liboil
$ env CC=clang make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-24 16:50:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-10-19 12:07:44 UTC 
Author: tijl
Date: Sat Oct 19 11:07:36 2013
New Revision: 330858
URL: http://svnweb.freebsd.org/changeset/ports/330858

Log:
  - Remove -fheinous-gnu-extensions.  No longer needed. [1]
  - Remove substitutions that have no effect.
  
  PR:		ports/181504 [1]
  Submitted by:	nork [1]

Modified:
  head/devel/liboil/Makefile

Modified: head/devel/liboil/Makefile
==============================================================================
--- head/devel/liboil/Makefile	Sat Oct 19 10:19:44 2013	(r330857)
+++ head/devel/liboil/Makefile	Sat Oct 19 11:07:36 2013	(r330858)
@@ -13,7 +13,7 @@ COMMENT=	Library of optimized inner loop
 LICENSE=	BSD
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-USES=		pathfix pkgconfig
+USES=		pkgconfig
 USE_GNOME=	ltverhack
 USE_AUTOTOOLS=	libtool
 USE_LDCONFIG=	yes
@@ -21,19 +21,8 @@ CONFIGURE_ARGS=	--disable-gtk-doc \
 		--disable-glib
 CFLAGS:=	${CFLAGS:N-O*} -O2
 
-_COMPILER_VERSION!=	${CC} --version
-.if ${_COMPILER_VERSION:Mclang}
-CFLAGS+=	-fheinous-gnu-extensions
-.endif
-
-.include <bsd.port.pre.mk>
-
 post-patch:
 	@${REINPLACE_CMD} -e 's|\\$$(libdir)/pkgconfig|${PREFIX}/libdata/pkgconfig|' \
 		${WRKSRC}/configure
-	@${REINPLACE_CMD} -e 's|<stdint\.h|<inttypes.h|g' \
-		${WRKSRC}/liboil/liboiltypes.h \
-		${WRKSRC}/liboil/liboilprofile.h \
-		${WRKSRC}/liboil/liboil.h
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-19 12:07:49 UTC 
State Changed
From-To: open->closed

Committed in r330858.  USE_GCC has been removed but the flag doesn't 
seem to be necessary anyway.
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-19 12:07:49 UTC 
Responsible Changed
From-To: mm->tijl

Committed in r330858.  USE_GCC has been removed but the flag doesn't 
seem to be necessary anyway.