Bug 181615 - [PATCH] audio/wavegain: Fix build with clang
Summary: [PATCH] audio/wavegain: Fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 13:40 UTC by Guido Falsi
Modified: 2013-09-16 18:40 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.66 KB, patch)
2013-08-28 13:40 UTC, Guido Falsi
no flags Details | Diff
wavegain.diff (1.68 KB, patch)
2013-08-28 15:47 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2013-08-28 13:40:03 UTC
- Fix build with clang (Respect CC)
- Make it respect LOCALBASE
- Trim Makefile headers
- Convert  LIB_DEPENDS to new format and remove ABI version number
- USES=gmake
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-28 13:40:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-28 13:40:12 UTC
Maintainer of audio/wavegain,

Please note that PR ports/181615 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181615

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-28 13:40:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2013-08-28 15:47:34 UTC
Attaching a revised patch, a small line was missing in the previous one.

It is needed to account the case that the ${CC} variable is redefined.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2013-09-02 22:32:33 UTC
Responsible Changed
From-To: miwi->madpilot

I'll take it.
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2013-09-16 18:38:58 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-09-16 18:38:58 UTC
Author: madpilot
Date: Mon Sep 16 17:38:50 2013
New Revision: 327426
URL: http://svnweb.freebsd.org/changeset/ports/327426

Log:
  - Fix build with clang (Respect CC)
  - Make it respect LOCALBASE
  - Trim Makefile headers
  - Convert LIB_DEPENDS to new format and remove ABI version number
  - USES gmake
  
  PR:		ports/181615
  Submitted by:	Me
  Approved by:	Maintainer timeout

Modified:
  head/audio/wavegain/Makefile   (contents, props changed)
  head/audio/wavegain/files/patch-Makefile.linux   (contents, props changed)

Modified: head/audio/wavegain/Makefile
==============================================================================
--- head/audio/wavegain/Makefile	Mon Sep 16 17:37:14 2013	(r327425)
+++ head/audio/wavegain/Makefile	Mon Sep 16 17:38:50 2013	(r327426)
@@ -10,7 +10,7 @@ DISTNAME=	${PORTNAME}-${PORTVERSION}srcs
 MAINTAINER=	darcsis@gmail.com
 COMMENT=	A program that applies ReplayGain to wave files
 
-LIB_DEPENDS=	sndfile.1:${PORTSDIR}/audio/libsndfile
+LIB_DEPENDS=	libsndfile.so:${PORTSDIR}/audio/libsndfile
 
 USES=		gmake
 USE_ZIP=	yes
@@ -26,6 +26,9 @@ WRKSRC=	${WRKDIR}/WaveGain-${PORTVERSION
 BROKEN=		Does not compile on ia64, powerpc, or sparc64
 .endif
 
+post-patch:
+	@${REINPLACE_CMD} -e "s|%%LOCALBASE%%|${LOCALBASE}|" ${WRKSRC}/Makefile.linux
+
 do-configure:
 	@cd ${WRKSRC} && ${CP} Makefile.linux Makefile
 

Modified: head/audio/wavegain/files/patch-Makefile.linux
==============================================================================
--- head/audio/wavegain/files/patch-Makefile.linux	Mon Sep 16 17:37:14 2013	(r327425)
+++ head/audio/wavegain/files/patch-Makefile.linux	Mon Sep 16 17:38:50 2013	(r327426)
@@ -1,9 +1,11 @@
---- Makefile.linux	2005-11-30 11:17:14.000000000 +0800
-+++ Makefile.linux	2008-05-24 22:14:34.000000000 +0800
-@@ -1,5 +1,5 @@
+--- Makefile.linux.orig	2005-11-30 12:17:14.000000000 +0100
++++ Makefile.linux	2013-08-28 13:02:43.817494398 +0200
+@@ -1,5 +1,7 @@
++CC ?=	cc
++
  all:
 -	gcc *.c -o wavegain -DHAVE_CONFIG_H -lm -lsndfile
-+	gcc *.c -o wavegain -DHAVE_CONFIG_H -lm -lsndfile -L/usr/local/lib
++	${CC} *.c -o wavegain -DHAVE_CONFIG_H -lm -lsndfile -L%%LOCALBASE%%/lib
  
  install:
  	install -d /usr/bin/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"