Bug 181617 - [patch] misc/window: fix build with clang, add LICENSE and more
Summary: [patch] misc/window: fix build with clang, add LICENSE and more
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tom Rhodes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 13:50 UTC by Boris Samorodov
Modified: 2013-09-11 17:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1003 bytes, patch)
2013-08-28 13:50 UTC, Boris Samorodov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2013-08-28 13:50:02 UTC
The ports fails to build with clang:
-----
cmd.c:297:3: error: non-void function 'setselwin' should return a value [-Wreturn-type]
                return;
                ^
-----

Fix: . fix build with clang (CFLAGS+=-Wno-return-type);
. trim Makefile headers;
. reword COMMENT;
. add LICENSE (BSD);
. remove check for unsupported FreeBSD versions (<800093).

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-28 13:50:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->trhodes

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-09-11 17:09:12 UTC
Author: bsam
Date: Wed Sep 11 16:09:04 2013
New Revision: 326990
URL: http://svnweb.freebsd.org/changeset/ports/326990

Log:
  . fix build with clang (CFLAGS+=-Wno-return-type);
  . trim Makefile headers;
  . reword COMMENT;
  . add LICENSE (BSD);
  . remove check for unsupported FreeBSD versions (<800093).
  
  PR:		ports/181617
  Submitted by:	bsam (me)
  Approved by:	trhodes (maintainer timeout, 2 weeks)

Modified:
  head/misc/window/Makefile

Modified: head/misc/window/Makefile
==============================================================================
--- head/misc/window/Makefile	Wed Sep 11 15:53:29 2013	(r326989)
+++ head/misc/window/Makefile	Wed Sep 11 16:09:04 2013	(r326990)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	window
-# Date created:				31 May 2009
-# Whom:					Tom Rhodes <trhodes@FreeBSD.org>
-#
+# Created by: Tom Rhodes <trhodes@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	window
 PORTVERSION=	1.0
@@ -11,15 +7,12 @@ CATEGORIES=	misc
 MASTER_SITES=	http://people.FreeBSD.org/~trhodes/
 
 MAINTAINER=	trhodes@FreeBSD.org
-COMMENT=	The FreeBSD usr.bin/window application
+COMMENT=	Window environment on ASCII terminals
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} < 800093
-IGNORE=		window-1.0 is still part of the base system
-.endif
+LICENSE=	BSD
 
 WRKSRC=		${WRKDIR}/window
+CFLAGS+=	-Wno-return-type
 
 MAN1=		window.1
 PLIST_FILES=	bin/window
@@ -28,4 +21,4 @@ do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/window ${PREFIX}/bin
 	${INSTALL_DATA} ${WRKSRC}/${MAN1} ${PREFIX}/man/man1
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Boris Samorodov freebsd_committer freebsd_triage 2013-09-11 17:09:36 UTC
State Changed
From-To: open->closed

Committed, thanks! ;-)