Bug 181637 - [MAINTAINER] devel/pecl-inotify: [SUMMARIZE CHANGES]
Summary: [MAINTAINER] devel/pecl-inotify: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-29 06:00 UTC by Gasol Wu
Modified: 2014-01-06 15:13 UTC (History)
0 users

See Also:


Attachments
pecl-inotify-0.1.6_1.patch (1.65 KB, patch)
2013-08-29 06:00 UTC, Gasol Wu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gasol Wu 2013-08-29 06:00:00 UTC
Correct variable name to fix shared library links

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-29 06:00:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2013-09-22 15:11:26 UTC
Responsible Changed
From-To: miwi->freebsd-ports-bugs

Back to the heap due to timeout
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-06 19:23:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

sunpoet@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-01-06 15:08:53 UTC
Author: sunpoet
Date: Mon Jan  6 15:08:43 2014
New Revision: 338891
URL: http://svnweb.freebsd.org/changeset/ports/338891

Log:
  - Correct variable name to fix shared library links
  - Bump PORTREVISION for package change
  - While I'm here, convert to new LIB_DEPENDS format and support STAGEDIR
  
  PR:		ports/181637
  Submitted by:	Gasol Wu <gasol.wu@gmail.com> (maintainer)

Modified:
  head/devel/pecl-inotify/Makefile
  head/devel/pecl-inotify/files/patch-config.m4   (contents, props changed)

Modified: head/devel/pecl-inotify/Makefile
==============================================================================
--- head/devel/pecl-inotify/Makefile	Mon Jan  6 15:08:38 2014	(r338890)
+++ head/devel/pecl-inotify/Makefile	Mon Jan  6 15:08:43 2014	(r338891)
@@ -3,6 +3,7 @@
 
 PORTNAME=	inotify
 PORTVERSION=	0.1.6
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	http://pecl.php.net/get/
 PKGNAMEPREFIX=	pecl-
@@ -14,7 +15,7 @@ COMMENT=	This extension allows to use in
 
 LICENSE=	PHP301
 
-LIB_DEPENDS=	inotify:${PORTSDIR}/devel/libinotify
+LIB_DEPENDS=	libinotify.so:${PORTSDIR}/devel/libinotify
 
 USE_PHP=	yes
 USE_PHP_BUILD=	yes
@@ -22,5 +23,4 @@ USE_PHPIZE=	yes
 USE_PHPEXT=	yes
 IGNORE_WITH_PHP=4
 
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: head/devel/pecl-inotify/files/patch-config.m4
==============================================================================
--- head/devel/pecl-inotify/files/patch-config.m4	Mon Jan  6 15:08:38 2014	(r338890)
+++ head/devel/pecl-inotify/files/patch-config.m4	Mon Jan  6 15:08:43 2014	(r338891)
@@ -1,6 +1,6 @@
 --- ./config.m4.orig	2012-05-04 17:51:20.000000000 +0800
-+++ ./config.m4	2012-06-27 12:05:19.620198000 +0800
-@@ -1,22 +1,52 @@
++++ ./config.m4	2013-08-29 12:49:00.000000000 +0800
+@@ -1,22 +1,51 @@
  dnl $Id: config.m4 262896 2008-07-17 19:11:16Z lbarnaud $
  dnl config.m4 for extension inotify
  
@@ -44,8 +44,6 @@
 +    AC_MSG_ERROR([Cannot find libevent headers])
 +  fi
 +
-+  PHP_ADD_INCLUDE($LIBINOTIFY_DIR/include)
-+
 +  LIBNAME=inotify
 +  LIBSYMBOL=inotify_init
 +
@@ -55,13 +53,14 @@
 +
 +  PHP_CHECK_LIBRARY($LIBNAME,$LIBSYMBOL,
 +  [
-+    PHP_ADD_LIBRARY_WITH_PATH($LIBNAME, $LIBINOTIFY_DIR/$PHP_LIBDIR, LIBINOTIFY_SHARED_LIBADD)
++    PHP_ADD_INCLUDE($LIBINOTIFY_DIR/include)
++    PHP_ADD_LIBRARY_WITH_PATH($LIBNAME, $LIBINOTIFY_DIR/$PHP_LIBDIR, INOTIFY_SHARED_LIBADD)
 +  ],[
 +    AC_MSG_ERROR([Your system does not support inotify])
 +  ],[
-+    -L$LIBINOTIFY_DIR/$PHP_LIBDIR 
++    -L$LIBINOTIFY_DIR/$PHP_LIBDIR
    ])
  
-+  PHP_SUBST(LIBINOTIFY_SHARED_LIBADD)
++  PHP_SUBST(INOTIFY_SHARED_LIBADD)
    PHP_NEW_EXTENSION(inotify, inotify.c, $ext_shared)
  fi
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-01-06 15:13:31 UTC
State Changed
From-To: open->closed

Committed. Thanks!