Bug 181761 - [patch] devel/mingw32-binutils: fix build with clang
Summary: [patch] devel/mingw32-binutils: fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-02 20:10 UTC by Tijl Coosemans
Modified: 2013-09-02 23:10 UTC (History)
0 users

See Also:


Attachments
mingw32-binutils.patch (860 bytes, patch)
2013-09-02 20:10 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2013-09-02 20:10:00 UTC
The attached removes USE_GCC=any and adds --disable-werror to
CONFIGURE_ARGS to allow building with clang.
Initially I tried adding flags like -Wno-error=string-plus-int to CFLAGS
but I kept having to disable more and more warnings and future versions
of clang might require even more that I think setting --disable-werror is
best.
The attached patch also converts USE_GMAKE to USES=gmake.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-02 20:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-02 20:10:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-02 20:10:10 UTC
Maintainer of devel/mingw32-binutils,

Please note that PR ports/181761 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181761

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2013-09-02 20:15:15 UTC
Responsible Changed
From-To: miwi->tijl

Track my own PR.
Comment 5 Naram Qashat 2013-09-02 22:05:11 UTC
This patch is good to me. Go ahead.

Thanks,
Naram Qashat

On 09/02/13 15:10, Edwin Groothuis wrote:
> Maintainer of devel/mingw32-binutils,
>
> Please note that PR ports/181761 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181761
>
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-09-02 23:00:59 UTC
Author: tijl
Date: Mon Sep  2 22:00:52 2013
New Revision: 326102
URL: http://svnweb.freebsd.org/changeset/ports/326102

Log:
  - Remove USE_GCC=any and fix building with clang by disabling -Werror.
  - Convert USE_GMAKE to USES=gmake.
  
  PR:		181761
  Approved by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Modified:
  head/devel/mingw32-binutils/Makefile

Modified: head/devel/mingw32-binutils/Makefile
==============================================================================
--- head/devel/mingw32-binutils/Makefile	Mon Sep  2 21:57:08 2013	(r326101)
+++ head/devel/mingw32-binutils/Makefile	Mon Sep  2 22:00:52 2013	(r326102)
@@ -3,6 +3,7 @@
 
 PORTNAME=	binutils
 PORTVERSION=	${BINUTILVERSION}
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_SOURCEWARE}
@@ -15,14 +16,12 @@ COMMENT=	GNU Binutils for Windows cross-
 BINUTILVERSION=	2.23.1
 
 USE_BZIP2=	yes
-USE_GCC=	any
-USE_GMAKE=	yes
-USES=		iconv
+USES=		gmake iconv
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--target=${PKGNAMEPREFIX:S/-$//} \
 		--with-gcc --with-gnu-ld --with-gnu-as \
 		--disable-nls --disable-win32-registry \
-		--disable-shared
+		--disable-shared --disable-werror
 INFO_PATH=	${PKGNAMEPREFIX:S/-$//}/info
 
 MAN1=	${PKGNAMEPREFIX}addr2line.1 ${PKGNAMEPREFIX}ar.1    \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Tijl Coosemans freebsd_committer freebsd_triage 2013-09-02 23:03:58 UTC
State Changed
From-To: feedback->closed

Committed in r326102.