Bug 181923 - security/heimdal JOBS_UNSAFE and default prefix location
Summary: security/heimdal JOBS_UNSAFE and default prefix location
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-08 02:20 UTC by dewayne
Modified: 2014-06-10 22:10 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2013-09-08 02:20:00 UTC 
Heimdal failed to build unless MAKE_JOBS_UNSAFE= yes
also the location of cracklib should be located with heimdal and not in localbase.  The heimdal prefix is changed when overwriting the system default heimdal.

Fix: 

+MAKE_JOBS_UNSAFE= yes
 USE_AUTOTOOLS= autoconf autoheader libtool
 USE_OPENSSL=   yes
 USES=          gettext pathfix pkgconfig
@@ -120,7 +121,7 @@
 .endif

 .if ${PORT_OPTIONS:MCRACKLIB}
-BUILD_DEPENDS+=                ${LOCALBASE}/lib/libcrack.a:${PORTSDIR}/security/cracklib
+BUILD_DEPENDS+=                ${PREFIX}/lib/libcrack.a:${PORTSDIR}/security/cracklib
 .endif

 .if ${PORT_OPTIONS:MX11}--UL0vL1aZVRc490ZBbrNT2ZAlGi9Ks35Wvk6u6s5igrWgvBaO
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: Makefile
===================================================================
--- Makefile    (revision 326699)
+++ Makefile    (working copy)
@@ -27,6 +27,7 @@
 CRACKLIB_DESC= Use CrackLib for password quality checking
 X11_DESC=      Build X11 utilies
How-To-Repeat: On a busy system, cd /usr/ports/security/heimdal && make PREFIX=/usr package
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-08 03:05:46 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-08 03:05:46 UTC 
Maintainer of security/heimdal,

Please note that PR ports/181923 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181923

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-10 10:37:27 UTC 
I can confirm this is not jobs safe; dports has used a patch to add it for about a year now!

And the other change sounds reasonable.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-06-10 22:08:54 UTC 
A commit references this bug:

Author: marino
Date: Tue Jun 10 22:08:01 UTC 2014
New revision: 357393
URL: http://svnweb.freebsd.org/changeset/ports/357393

Log:
  security/heimdal: Mark not-jobs-safe and fix cracklib location

  While here:
   * Clean up options and PLIST_SUB with new option framework capabilities
   * Remove condition for FreeBSD 6 and earlier
     - Remove never-fulfilled plist condition
     - Move extra-patch to always-patch
   * minor cosmetic realignment

  PR:		181923
  Submitted by:	dewayne

Changes:
  head/security/heimdal/Makefile
  head/security/heimdal/files/extra-patch-doc__Makefile.in
  head/security/heimdal/files/patch-doc__Makefile.in
  head/security/heimdal/pkg-plist