182037 – Response for Build failed for games/mangband 1.1.2 during build

Bug 182037 - Response for Build failed for games/mangband 1.1.2 during build

Summary: Response for Build failed for games/mangband 1.1.2 during build

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	Normal Affects Only Me
Assignee:	Pawel Pekala

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-09-12 14:20 UTC by flambard
Modified:	2014-02-04 19:30 UTC (History)
CC List:	0 users

See Also:

Attachments
file.diff (599 bytes, patch) 2013-09-12 14:20 UTC, flambard	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description flambard 2013-09-12 14:20:00 UTC

I'm responding to an alert from an automated build server.

The subject line was [RELEASE - head-amd64-default][games/mangband] Build failed for mangband-1.1.2 during build

And the logs were shown at
Log URL:        http://beefy2.isc.freebsd.org/bulk/head-amd64-default/2013-09-12_01h37m09s/logs/mangband-1.1.2.log
Build URL:      http://beefy2.isc.freebsd.org/bulk/head-amd64-default/2013-09-12_01h37m09s

The upstream has been notified and the fix will be incorporated into the next release. Meanwhile, here's a port update.

Fix: Update the port with the attached diff.

Patch attached with submission follows:
How-To-Repeat: Try building mangband on head-amd64-default machine.

Comment 1 Pawel Pekala freebsd_committer

2014-02-04 16:31:13 UTC

Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.

Comment 2 dfilter service freebsd_committer

2014-02-04 18:59:05 UTC

Author: pawel
Date: Tue Feb  4 18:58:58 2014
New Revision: 342588
URL: http://svnweb.freebsd.org/changeset/ports/342588
QAT: https://qat.redports.org/buildarchive/r342588/

Log:
  Fix build with clang
  
  PR:		ports/182037
  Submitted by:	maintainer
  MFH:		2014Q1

Added:
  head/games/mangband/files/patch-client_main-sdl.c   (contents, props changed)
Modified:
  head/games/mangband/Makefile

Modified: head/games/mangband/Makefile
==============================================================================
--- head/games/mangband/Makefile	Tue Feb  4 18:39:42 2014	(r342587)
+++ head/games/mangband/Makefile	Tue Feb  4 18:58:58 2014	(r342588)
@@ -12,8 +12,8 @@ COMMENT=	Free online multiplayer real-ti
 ALL_TARGET=	mangclient mangband
 WRKSRC=		${WRKDIR}/${DISTNAME}/src
 GNU_CONFIGURE=	yes
-USES=		ncurses
-USE_GMAKE=	yes
+USES=		dos2unix gmake ncurses
+DOS2UNIXFILES=	${WRKSRC}/client/main-sdl.c
 
 MAKE_ARGS=	"DATADIR=${DATADIR}"
 

Added: head/games/mangband/files/patch-client_main-sdl.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/mangband/files/patch-client_main-sdl.c	Tue Feb  4 18:58:58 2014	(r342588)
@@ -0,0 +1,11 @@
+--- client/main-sdl.c.orig	2014-02-04 19:51:35.412181886 +0100
++++ client/main-sdl.c	2014-02-04 19:51:50.859119136 +0100
+@@ -1031,7 +1031,7 @@
+ 	//if (td->cx != -1 && td->cy != -1) { 
+ 	//		RedrawChar(td->cx, td->cy); 
+ 	//	}
+-	if (td->cx == x && td->cy == y) return;
++	if (td->cx == x && td->cy == y) return (0);
+ 	//if (x == -1 && y == -1) return;
+ 	if (td->cursor_on) 
+ 	{
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"

Comment 3 Pawel Pekala freebsd_committer

2014-02-04 18:59:19 UTC

State Changed
From-To: open->closed

Committed. Thanks!

Comment 4 dfilter service freebsd_committer

2014-02-04 19:20:54 UTC

Author: pawel
Date: Tue Feb  4 19:20:46 2014
New Revision: 342593
URL: http://svnweb.freebsd.org/changeset/ports/342593
QAT: https://qat.redports.org/buildarchive/r342593/

Log:
  MFH: r342588
  
  Fix build with clang
  
  PR:		ports/182037
  Submitted by:	maintainer
  Approved by:	portmgr (erwin)

Added:
  branches/2014Q1/games/mangband/files/patch-client_main-sdl.c
     - copied unchanged from r342588, head/games/mangband/files/patch-client_main-sdl.c
Modified:
  branches/2014Q1/games/mangband/Makefile
Directory Properties:
  branches/2014Q1/   (props changed)

Modified: branches/2014Q1/games/mangband/Makefile
==============================================================================
--- branches/2014Q1/games/mangband/Makefile	Tue Feb  4 19:15:43 2014	(r342592)
+++ branches/2014Q1/games/mangband/Makefile	Tue Feb  4 19:20:46 2014	(r342593)
@@ -12,8 +12,8 @@ COMMENT=	Free online multiplayer real-ti
 ALL_TARGET=	mangclient mangband
 WRKSRC=		${WRKDIR}/${DISTNAME}/src
 GNU_CONFIGURE=	yes
-USES=		ncurses
-USE_GMAKE=	yes
+USES=		dos2unix gmake ncurses
+DOS2UNIXFILES=	${WRKSRC}/client/main-sdl.c
 
 MAKE_ARGS=	"DATADIR=${DATADIR}"
 

Copied: branches/2014Q1/games/mangband/files/patch-client_main-sdl.c (from r342588, head/games/mangband/files/patch-client_main-sdl.c)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2014Q1/games/mangband/files/patch-client_main-sdl.c	Tue Feb  4 19:20:46 2014	(r342593, copy of r342588, head/games/mangband/files/patch-client_main-sdl.c)
@@ -0,0 +1,11 @@
+--- client/main-sdl.c.orig	2014-02-04 19:51:35.412181886 +0100
++++ client/main-sdl.c	2014-02-04 19:51:50.859119136 +0100
+@@ -1031,7 +1031,7 @@
+ 	//if (td->cx != -1 && td->cy != -1) { 
+ 	//		RedrawChar(td->cx, td->cy); 
+ 	//	}
+-	if (td->cx == x && td->cy == y) return;
++	if (td->cx == x && td->cy == y) return (0);
+ 	//if (x == -1 && y == -1) return;
+ 	if (td->cursor_on) 
+ 	{
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"