Bug 182039 - devel/xa65: CLANG fixes
Summary: devel/xa65: CLANG fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 14:30 UTC by Uffe Jakobsen
Modified: 2013-10-19 14:40 UTC (History)
0 users

See Also:

Attachments
file.diff (588 bytes, patch)
2013-09-12 14:30 UTC, Uffe Jakobsen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uffe Jakobsen 2013-09-12 14:30:01 UTC 
This log reports that xa65 has a build problem with clang

http://beefy2.isc.freebsd.org/bulk/head-amd64-default/2013-09-12_01h37m09s/logs/xa65-2.3.5.log

Patch attached.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-12 14:30:09 UTC 
Class Changed
From-To: change-request->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-12 14:30:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2013-09-22 15:12:11 UTC 
Responsible Changed
From-To: miwi->freebsd-ports-bugs

Back to the heap due to timeout
Comment 4 Uffe Jakobsen 2013-10-16 12:45:52 UTC 
Why the timeout on this PR ?

As far as I can tell I've delivered all the relevant info into this case.

I keep getting emails from  pkg-fallout@ complaining about this error.
Please let me know if anything is missing -

/Uffe
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-10-19 14:33:54 UTC 
Author: tijl
Date: Sat Oct 19 13:33:47 2013
New Revision: 330867
URL: http://svnweb.freebsd.org/changeset/ports/330867

Log:
  Fix build with clang by defining LD.
  
  PR:		ports/182039
  Submitted by:	Uffe Jakobsen <uffe@uffe.org> (maintainer)

Modified:
  head/devel/xa65/Makefile

Modified: head/devel/xa65/Makefile
==============================================================================
--- head/devel/xa65/Makefile	Sat Oct 19 13:29:27 2013	(r330866)
+++ head/devel/xa65/Makefile	Sat Oct 19 13:33:47 2013	(r330867)
@@ -14,6 +14,8 @@ OPTIONS_DEFINE=	DOCS EXAMPLES
 
 USES=	gmake
 
+MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}" LD="${CC}" LDFLAGS="${LDFLAGS}"
+
 MAN1=	file65.1 ldo65.1 printcbm.1 reloc65.1 uncpk.1 xa.1
 MLINKS=	xa.1 xa65.1
 
@@ -28,10 +30,6 @@ PLIST_FILES=	bin/xa65 \
 		bin/uncpk
 
 NO_STAGE=	yes
-post-patch-script:
-.for i in CC LDFLAGS CFLAGS
-	@${REINPLACE_CMD} 's|${i} = |${i} ?= |g' ${WRKSRC}/Makefile
-.endfor
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/xa ${PREFIX}/bin/xa65
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-19 14:34:04 UTC 
State Changed
From-To: open->closed

Committed in r330867.
Comment 7 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-19 14:34:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->tijl

Committed in r330867.