argparse is a part of python standard library since 2.7 and 3.2. Because python2.6 will be removed soon and python3.1 is deprecated, this dependency should be removed. While I'm on it, remove excessшму MASTER_SITE_SUBDIR and add trailing slash to WWW. PS. I'm not reporting argparse issue to apstream, because they removed this dependency in git trunk: https://github.com/openstack-infra/git-review/blob/master/setup.py Fix: Patch attached with submission follows:
Maintainer of devel/git-review, Please note that PR ports/182085 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182085 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thank you for the patch. I'm not really comfortable with the idea to drop Python 2.6 support from an utility port BEFORE Python 2.6 is removed from the ports. Especially as legacy development servers built two years ago still use Python 2.6.8 (early 2011, Python default port version still were 2.6). On Sat, Sep 14, 2013 at 12:40 PM, Edwin Groothuis <edwin@freebsd.org> wrote= : > Maintainer of devel/git-review, > > Please note that PR ports/182085 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/182085 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org --=20 S=E9bastien Santoro aka Dereckson http://www.dereckson.be/
Author: rm Date: Sun Jan 26 16:43:29 2014 New Revision: 341244 URL: http://svnweb.freebsd.org/changeset/ports/341244 QAT: https://qat.redports.org/buildarchive/r341244/ Log: - drop dependency on devel/py-argparse - it was only needed for python26, that's gone some time ago - add staging support, while here - bump PORTREVISION PR: 182085 Submitted by: rm (myself) Approved by: Dereckson <dereckson@gmail.com> (maintainer) Deleted: head/devel/git-review/pkg-plist Modified: head/devel/git-review/Makefile head/devel/git-review/pkg-descr Modified: head/devel/git-review/Makefile ============================================================================== --- head/devel/git-review/Makefile Sun Jan 26 16:40:14 2014 (r341243) +++ head/devel/git-review/Makefile Sun Jan 26 16:43:29 2014 (r341244) @@ -2,34 +2,28 @@ PORTNAME= git-review PORTVERSION= 1.23 +PORTREVISION= 1 CATEGORIES= devel python MASTER_SITES= CHEESESHOP -MASTER_SITE_SUBDIR= source/g/${PORTNAME} MAINTAINER= dereckson@gmail.com COMMENT= Allow to push review and interact with a Gerrit server LICENSE= APACHE20 -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}argparse>0:${PORTSDIR}/devel/py-argparse \ - git:${PORTSDIR}/devel/git +RUN_DEPENDS= git:${PORTSDIR}/devel/git USE_PYTHON= yes NO_BUILD= yes -MAN1= git-review.1 - -NO_STAGE= yes -.include <bsd.port.options.mk> +PLIST_FILES= bin/git-review \ + man/man1/git-review.1.gz +PORTDOCS= README.rst HACKING.rst AUTHORS do-install: - ${INSTALL_SCRIPT} ${WRKSRC}/git-review ${PREFIX}/bin/git-review - ${INSTALL_MAN} ${WRKSRC}/git-review.1 ${PREFIX}/man/man1 -.if ${PORT_OPTIONS:MDOCS} - ${MKDIR} ${DOCSDIR} - ${INSTALL_MAN} ${WRKSRC}/README.rst ${DOCSDIR} - ${INSTALL_MAN} ${WRKSRC}/HACKING.rst ${DOCSDIR} - ${INSTALL_MAN} ${WRKSRC}/AUTHORS ${DOCSDIR} -.endif + ${INSTALL_SCRIPT} ${WRKSRC}/git-review ${STAGEDIR}${PREFIX}/bin/git-review + ${INSTALL_MAN} ${WRKSRC}/git-review.1 ${STAGEDIR}${MANPREFIX}/man/man1 + @${MKDIR} ${STAGEDIR}${DOCSDIR} + ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR} .include <bsd.port.mk> Modified: head/devel/git-review/pkg-descr ============================================================================== --- head/devel/git-review/pkg-descr Sun Jan 26 16:40:14 2014 (r341243) +++ head/devel/git-review/pkg-descr Sun Jan 26 16:43:29 2014 (r341244) @@ -4,4 +4,4 @@ from the console. It allows you to push change to review, download a changeset into a new branch, push a change as draft or push an amended change as new patchset. -WWW: https://launchpad.net/git-review +WWW: https://launchpad.net/git-review/ _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thank you!