Bug 182185 - [PATCH] www/mod_python3: Fix linking when Python is built with libs in LOCALBASE
Summary: [PATCH] www/mod_python3: Fix linking when Python is built with libs in LOCALBASE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 12:00 UTC by koobs
Modified: 2013-10-20 05:10 UTC (History)
1 user (show)

See Also:

Attachments
ap22-mod_python-3.3.1_4.patch (1.30 KB, patch)
2013-09-17 12:00 UTC, koobs 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description koobs 2013-09-17 12:00:00 UTC 
www/mod_python3: Fix linking when Python is built with libs in LOCALBASE

- Bump port revision
- While I'm here, sort Makefile entries
- Add regression-test target with comment

Reported by:	des, pkg-fallout
Reviewed by:	mva

portlint: WARN - pkg-message: possible use of absolute pathname
porttest: ??? whats up with pkg-plist, are apache mod ports not PREFIX safe ???
unittest: 
 - Ran 68 tests in 12.590s - OK
 - Ran 6 tests in 41.549s - OK

Port maintainer (apache@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-17 12:00:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2013-10-20 04:58:03 UTC 
Responsible Changed
From-To: apache->koobs

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-10-20 05:00:05 UTC 
Author: koobs
Date: Sun Oct 20 03:59:52 2013
New Revision: 330969
URL: http://svnweb.freebsd.org/changeset/ports/330969

Log:
  www/mod_python3: Fix linking when Python is built with libs in LOCALBASE
  
  - Bump port revision
  - While I'm here, sort Makefile entries
  - Add regression-test target with comment
  
  PR:		ports/182185
  Reported by:	des, pkg-fallout
  Reviewed by:	mva
  Approved by:	maintainer timeout (1 month)

Modified:
  head/www/mod_python3/Makefile

Modified: head/www/mod_python3/Makefile
==============================================================================
--- head/www/mod_python3/Makefile	Sun Oct 20 03:58:35 2013	(r330968)
+++ head/www/mod_python3/Makefile	Sun Oct 20 03:59:52 2013	(r330969)
@@ -3,7 +3,7 @@
 
 PORTNAME=	mod_python
 PORTVERSION=	3.3.1
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	www python
 MASTER_SITES=	${MASTER_SITE_APACHE_HTTPD}
 MASTER_SITE_SUBDIR=	modpython
@@ -13,21 +13,27 @@ EXTRACT_SUFX=	.tgz
 MAINTAINER=	apache@FreeBSD.org
 COMMENT=	Apache module that embeds the Python interpreter within the server
 
-
 USE_APACHE=	22
 USE_PYTHON=	yes
 
-MAKE_ARGS+=	APXS=${APXS}
-
 INSTALLS_EGGINFO=	yes
-LATEST_LINK=	mod_python3
-GNU_CONFIGURE=	yes
-CONFIGURE_ARGS+=--with-apxs="${APXS}" --with-python="${PYTHON_CMD}" \
-		--without-flex
+LATEST_LINK=		mod_python3
+
+GNU_CONFIGURE=		yes
+CONFIGURE_ARGS+=	--with-apxs="${APXS}"		\
+			--with-python="${PYTHON_CMD}"	\
+			--without-flex
+
+LDFLAGS+=	-L${LOCALBASE}/lib
+MAKE_ARGS+=	APXS=${APXS}
 MAKE_ENV=	EXPR_COMPAT=yes
 
 NO_STAGE=	yes
 post-install:
 	@${CAT} ${PKGMESSAGE}
 
+# You need to install apache & mod_python before you run this
+regression-test: build
+	@cd ${WRKSRC} && ${MAKE} check
+
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2013-10-20 05:00:12 UTC 
State Changed
From-To: open->closed

Committed. Thanks!