Bug 182277 - missing rcvar on net-mgmt/netdisco
Summary: missing rcvar on net-mgmt/netdisco
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-21 11:00 UTC by loic.blot
Modified: 2013-11-03 05:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description loic.blot 2013-09-21 11:00:00 UTC
	netdisco service rcvar is missing, then service wants to launch at each boot.

Fix: 

This line must be added to /usr/local/etc/rc.d/netdisco:
	rcvar=${name}_enable
How-To-Repeat: 	Install netdisco without set the netdisco_enable in rc.conf. Reboot
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-21 16:23:50 UTC
Maintainer of net-mgmt/netdisco,

Please note that PR ports/182277 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182277

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-21 16:23:51 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-09-22 07:13:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-11-03 04:54:07 UTC
Author: sunpoet
Date: Sun Nov  3 04:53:54 2013
New Revision: 332583
URL: http://svnweb.freebsd.org/changeset/ports/332583

Log:
  - Add missing rcvar in rc.d script
  - Bump PORTREVISION for package change
  - While I'm here, use bsd.port.mk instead of bsd.port.pre.mk + bsd.port.post.mk
  
  PR:		ports/182277
  Submitted by:	Loic Blot <loic.blot@unix-experience.fr>
  Approved by:	maintainer (timeout, 7 weeks)

Modified:
  head/net-mgmt/netdisco/Makefile
  head/net-mgmt/netdisco/files/netdisco.in

Modified: head/net-mgmt/netdisco/Makefile
==============================================================================
--- head/net-mgmt/netdisco/Makefile	Sun Nov  3 04:53:49 2013	(r332582)
+++ head/net-mgmt/netdisco/Makefile	Sun Nov  3 04:53:54 2013	(r332583)
@@ -3,6 +3,7 @@
 
 PORTNAME=	netdisco
 PORTVERSION=	1.3.2
+PORTREVISION=	1
 CATEGORIES=	net-mgmt www
 MASTER_SITES=	SF
 
@@ -38,6 +39,7 @@ USE_APACHE_RUN=	22+
 USE_RC_SUBR=	netdisco
 
 NO_BUILD=	yes
+NO_STAGE=	yes
 
 NETDISCO_RUNDIR=/var/run
 NETDISCO_DBDIR=	/var/db/netdisco
@@ -56,8 +58,7 @@ CONFIG_FILES=	netdisco.conf netdisco.cro
 
 DOCFILES=	ChangeLog doc/*.pod INSTALL README* UPGRADE
 
-NO_STAGE=	yes
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 MIBSDIR=	${PREFIX}/share/netdisco-mibs
 .if ${PORT_OPTIONS:MMIBS}
@@ -150,4 +151,4 @@ post-install:
 .	endif
 	@${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/net-mgmt/netdisco/files/netdisco.in
==============================================================================
--- head/net-mgmt/netdisco/files/netdisco.in	Sun Nov  3 04:53:49 2013	(r332582)
+++ head/net-mgmt/netdisco/files/netdisco.in	Sun Nov  3 04:53:54 2013	(r332583)
@@ -10,6 +10,7 @@
 . /etc/rc.subr
 
 name="netdisco"
+rcvar="netdisco_enable"
 
 load_rc_config $name
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-03 04:54:09 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!