Bug 182395 - [MAINTAINER] japanese/lookup: add staging support.
Summary: [MAINTAINER] japanese/lookup: add staging support.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-26 07:20 UTC by Yasuhiro Kimura
Modified: 2014-02-21 22:10 UTC (History)
0 users

See Also:


Attachments
patch-ja-lookup (597 bytes, text/plain)
2013-09-26 07:20 UTC, Yasuhiro Kimura
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2013-09-26 07:20:00 UTC
	
	- Add staging support.
	- Remove definition of unused variable PORTINFODIR.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2013-12-17 00:37:46 UTC
Hi,

I've tried your patch locally, and `make check-orphans' fails:

====> Items missing from pkg-plist (check-orphans)
info/dir
info/lookup-guide.info
info/lookup.info
info/lookup.info-1
info/lookup.info-2
info/lookup.info-3
@dirrmtry share/emacs/24.3/site-lisp
@dirrmtry share/emacs/24.3
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2013-12-17 01:59:53 UTC
Hi.

Thank you for comment.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Subject: Re: ports/182395: [MAINTAINER] japanese/lookup: add staging support.
Date: Tue, 17 Dec 2013 02:37:46 +0200

> I've tried your patch locally, and `make check-orphans' fails:
> 
> ====> Items missing from pkg-plist (check-orphans)
> info/dir
> info/lookup-guide.info
> info/lookup.info
> info/lookup.info-1
> info/lookup.info-2
> info/lookup.info-3

It seems bug of 'check-orphans' to me because info files are included
in package archive as following:

yasu@eastasia[22230]% pkg info -l -F /usr0/freebsd/ports/packages/amd64-freebsd9/All/ja-lookup-emacs24-1.4.1_15.txz | grep '\.info'
        /usr/local/info/lookup.info
        /usr/local/info/lookup.info-1
        /usr/local/info/lookup.info-2
        /usr/local/info/lookup.info-3
        /usr/local/info/lookup-guide.info
yasu@eastasia[22231]%

And,

> @dirrmtry share/emacs/24.3/site-lisp
> @dirrmtry share/emacs/24.3

These 2 directories are owned bye emacs package and should not be
include in pkg-plist of dependent port,

Best Regards.

---
Yasuhiro KIMURA
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2014-02-21 19:11:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-02-21 22:08:10 UTC
Author: pawel
Date: Fri Feb 21 22:08:02 2014
New Revision: 345554
URL: http://svnweb.freebsd.org/changeset/ports/345554
QAT: https://qat.redports.org/buildarchive/r345554/

Log:
  Add staging support
  
  PR:		ports/182395
  Submitted by:	maintainer

Modified:
  head/japanese/lookup-emacs21/Makefile
  head/japanese/lookup/Makefile

Modified: head/japanese/lookup-emacs21/Makefile
==============================================================================
--- head/japanese/lookup-emacs21/Makefile	Fri Feb 21 21:59:53 2014	(r345553)
+++ head/japanese/lookup-emacs21/Makefile	Fri Feb 21 22:08:02 2014	(r345554)
@@ -6,5 +6,4 @@ MASTERDIR=	${.CURDIR}/../lookup
 USE_EMACS=	yes
 EMACS_PORT_NAME=	emacs21
 
-NO_STAGE=	yes
 .include "${MASTERDIR}/Makefile"

Modified: head/japanese/lookup/Makefile
==============================================================================
--- head/japanese/lookup/Makefile	Fri Feb 21 21:59:53 2014	(r345553)
+++ head/japanese/lookup/Makefile	Fri Feb 21 22:08:02 2014	(r345554)
@@ -17,17 +17,14 @@ USE_EMACS=	yes
 
 INFO?=		lookup lookup-guide
 
-NO_STAGE=	yes
 .include <bsd.port.pre.mk>
 
 .if (${EMACS_PORT_NAME} == "xemacs21-mule")
 EMACSDIR=	${PREFIX}/lib/xemacs/site-packages
 ELISPDIR=	${EMACSDIR}/lisp/lookup
-PORTINFODIR=	${EMACSDIR}/info
 MANIFEST=	MANIFEST.lookup
 .else
 ELISPDIR=	${PREFIX}/${EMACS_VERSION_SITE_LISPDIR}/lookup
-PORTINFODIR=	${PREFIX}/info
 PLIST_SUB=	ELISPDIR=${EMACS_VERSION_SITE_LISPDIR}
 .endif
 HAS_CONFIGURE=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2014-02-21 22:08:14 UTC
State Changed
From-To: open->closed

Committed. Thanks!