Bug 182481 - [MAINTAINER] textproc/yaml-mode.el: add staging support
Summary: [MAINTAINER] textproc/yaml-mode.el: add staging support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-29 06:10 UTC by Yasuhiro Kimura
Modified: 2014-02-06 20:20 UTC (History)
0 users

See Also:


Attachments
patch-yaml-mode.el (715 bytes, text/plain)
2013-09-29 06:10 UTC, Yasuhiro Kimura
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2013-09-29 06:10:00 UTC
	
	Add staging support.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2013-12-17 00:35:07 UTC
Thanks for the patch, sorry that it took so long for anyone to look at
it.

I've tried it locally, and `make check-orphans' failed:

  ====> Items missing from pkg-plist (check-orphans)
  @dirrmtry share/emacs/24.3/site-lisp
  @dirrmtry share/emacs/24.3

Could you take a look at the issue?
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2013-12-17 01:41:12 UTC
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Subject: Re: ports/182481: [MAINTAINER] textproc/yaml-mode.el: add staging support
Date: Tue, 17 Dec 2013 02:35:07 +0200

> I've tried it locally, and `make check-orphans' failed:
> 
>   ====> Items missing from pkg-plist (check-orphans)
>   @dirrmtry share/emacs/24.3/site-lisp
>   @dirrmtry share/emacs/24.3
> 
> Could you take a look at the issue?

Thank you for comment. I think these 2 directories are owned by
editors/emacs and should not be included in pkg-plist of this port.

Best Regards.

---
Yasuhiro KIMURA
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2014-02-06 16:50:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-02-06 20:15:42 UTC
Author: pawel
Date: Thu Feb  6 20:15:32 2014
New Revision: 343147
URL: http://svnweb.freebsd.org/changeset/ports/343147
QAT: https://qat.redports.org/buildarchive/r343147/

Log:
  Stage support
  
  PR:		ports/182481
  Submitted by:	maintainer

Modified:
  head/textproc/yaml-mode.el-emacs21/Makefile
  head/textproc/yaml-mode.el/Makefile

Modified: head/textproc/yaml-mode.el-emacs21/Makefile
==============================================================================
--- head/textproc/yaml-mode.el-emacs21/Makefile	Thu Feb  6 19:49:22 2014	(r343146)
+++ head/textproc/yaml-mode.el-emacs21/Makefile	Thu Feb  6 20:15:32 2014	(r343147)
@@ -6,5 +6,4 @@ MASTERDIR=	${.CURDIR}/../yaml-mode.el
 USE_EMACS=	yes
 EMACS_PORT_NAME=	emacs21
 
-NO_STAGE=	yes
 .include "${MASTERDIR}/Makefile"

Modified: head/textproc/yaml-mode.el/Makefile
==============================================================================
--- head/textproc/yaml-mode.el/Makefile	Thu Feb  6 19:49:22 2014	(r343146)
+++ head/textproc/yaml-mode.el/Makefile	Thu Feb  6 20:15:32 2014	(r343147)
@@ -21,20 +21,17 @@ USE_EMACS=	yes
 
 MAKE_ENV+=	LISPDIR=${LISPDIR}
 
-LISPDIR=	${PREFIX}/${EMACS_VERSION_SITE_LISPDIR}
+LISPDIR=	${STAGEDIR}${PREFIX}/${EMACS_VERSION_SITE_LISPDIR}
 
 OPTIONS_DEFINE=	DOCS
 
-NO_STAGE=	yes
-.include <bsd.port.options.mk>
+pre-install:
+	${MKDIR} ${LISPDIR}
 
 post-install:
-.if ${PORT_OPTIONS:MDOCS}
-	${MKDIR} ${DOCSDIR}
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
 .for file in Changes README
-	${INSTALL_MAN} ${WRKSRC}/${file} ${DOCSDIR}
+	${INSTALL_MAN} ${WRKSRC}/${file} ${STAGEDIR}${DOCSDIR}
 .endfor
-.endif
-	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2014-02-06 20:15:45 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!