Bug 182567 - [patch] devel/scons: support staging
Summary: [patch] devel/scons: support staging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-02 11:40 UTC by Boris Samorodov
Modified: 2013-10-02 12:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.29 KB, patch)
2013-10-02 11:40 UTC, Boris Samorodov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2013-10-02 11:40:01 UTC
The port does not support staging.

Fix: . support staging;
. all MAN magic is done inside staging;
. remove the indefinite article from COMMENT.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-02 11:40:08 UTC
Maintainer of devel/scons,

Please note that PR ports/182567 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182567

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-02 11:40:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 gavin 2013-10-02 12:22:29 UTC
Approved!

Thanks Boris, lgtm

Gav...


> -----Original Message-----
> From: Edwin Groothuis [mailto:edwin@FreeBSD.org]
> Sent: Wednesday, 2 October 2013 8:40 PM
> To: gavin@16degrees.com.au
> Cc: bug-followup@FreeBSD.org
> Subject: Re: ports/182567: [patch] devel/scons: support staging
> 
> Maintainer of devel/scons,
> 
> Please note that PR ports/182567 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix you
agree
> on, reply to this email stating that you approve the patch and a committer
will
> take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182567
> 
> --
> Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-10-02 12:42:10 UTC
Author: bsam
Date: Wed Oct  2 11:42:02 2013
New Revision: 329039
URL: http://svnweb.freebsd.org/changeset/ports/329039

Log:
  . support staging;
  . all MAN magic is done inside staging;
  . remove the indefinite article from COMMENT.
  
  PR:		ports/182567
  Submitted by:	bsam (me)
  Approved by:	Gavin McDonald <gavin@16degrees.com.au> (maintainer)

Modified:
  head/devel/scons/Makefile
  head/devel/scons/pkg-plist

Modified: head/devel/scons/Makefile
==============================================================================
--- head/devel/scons/Makefile	Wed Oct  2 11:34:18 2013	(r329038)
+++ head/devel/scons/Makefile	Wed Oct  2 11:42:02 2013	(r329039)
@@ -7,14 +7,10 @@ CATEGORIES=	devel python
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
 
 MAINTAINER=	gavin@16degrees.com.au
-COMMENT=	A build tool alternative to make
+COMMENT=	Build tool alternative to make
 
 RUN_DEPENDS+=	python2:${PORTSDIR}/lang/python2
 
-.if !defined (NO_INSTALL_MANPAGES)
-MAN1=		scons.1 sconsign.1 scons-time.1
-.endif
-
 USE_PYTHON=	yes
 USE_PYDISTUTILS=	yes
 PYDISTUTILS_EGGINFODIR=	${PREFIX}/lib/scons-${PORTVERSION}
@@ -23,11 +19,4 @@ PLIST_SUB+=	SCONS_VER=${PORTVERSION}
 
 USE_PYTHON=	-2.7
 
-NO_STAGE=	yes
-.include <bsd.port.pre.mk>
-
-.if defined (NO_INSTALL_MANPAGES)
-PYDISTUTILS_INSTALLARGS+=	--no-install-man
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/devel/scons/pkg-plist
==============================================================================
--- head/devel/scons/pkg-plist	Wed Oct  2 11:34:18 2013	(r329038)
+++ head/devel/scons/pkg-plist	Wed Oct  2 11:42:02 2013	(r329039)
@@ -580,6 +580,9 @@ lib/scons-%%SCONS_VER%%/SCons/dblite.pyo
 lib/scons-%%SCONS_VER%%/SCons/exitfuncs.py
 lib/scons-%%SCONS_VER%%/SCons/exitfuncs.pyc
 lib/scons-%%SCONS_VER%%/SCons/exitfuncs.pyo
+man/man1/scons-time.1.gz
+man/man1/scons.1.gz
+man/man1/sconsign.1.gz
 @dirrm lib/scons-%%SCONS_VER%%/SCons/compat
 @dirrm lib/scons-%%SCONS_VER%%/SCons/Variables
 @dirrm lib/scons-%%SCONS_VER%%/SCons/Tool/packaging
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Boris Samorodov freebsd_committer freebsd_triage 2013-10-02 12:42:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bsam

Take mine.
Comment 6 Boris Samorodov freebsd_committer freebsd_triage 2013-10-02 12:43:05 UTC
State Changed
From-To: feedback->closed

Committed, thanks! ;-)