Bug 182621 - [PATCH] devel/p5-Gtk2-Notify: fails to build
Summary: [PATCH] devel/p5-Gtk2-Notify: fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 04:10 UTC by hiroto.kagotani
Modified: 2013-11-18 19:40 UTC (History)
1 user (show)

See Also:


Attachments
p5-Gtk2-Notify-0.05.patch (703 bytes, patch)
2013-10-04 04:10 UTC, hiroto.kagotani
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hiroto.kagotani 2013-10-04 04:10:00 UTC
p5-Gtk2-Notify fails to build without MAKE_JOBS_UNSAFE option.

Also changed LIB_DEPENDS format.

Port maintainer (lichray@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: suffix)

How-To-Repeat: Just do make.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-04 04:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-04 04:10:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-04 04:10:10 UTC
Maintainer of devel/p5-Gtk2-Notify,

Please note that PR ports/182621 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182621

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 zy 2013-10-04 04:36:08 UTC
Confirmed.  And the patch is correct.  Thanks!

-- 
Zhihao Yuan, ID lichray
The best way to predict the future is to invent it.
___________________________________________________
4BSD -- http://4bsd.biz/
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-18 19:22:40 UTC
Responsible Changed
From-To: perl->sunpoet

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-11-18 19:35:16 UTC
Author: sunpoet
Date: Mon Nov 18 19:35:09 2013
New Revision: 334255
URL: http://svnweb.freebsd.org/changeset/ports/334255

Log:
  - Mark MAKE_JOBS_UNSAFE
  - Convert to new LIB_DEPENDS format
  - While I'm here, support STAGEDIR
  
  PR:		ports/182621
  Submitted by:	Hiroto Kagotani <hiroto.kagotani@gmail.com>
  Approved by:	Zhihao Yuan <zy@miator.net> (maintainer)

Modified:
  head/devel/p5-Gtk2-Notify/Makefile
  head/devel/p5-Gtk2-Notify/pkg-plist   (contents, props changed)

Modified: head/devel/p5-Gtk2-Notify/Makefile
==============================================================================
--- head/devel/p5-Gtk2-Notify/Makefile	Mon Nov 18 19:31:36 2013	(r334254)
+++ head/devel/p5-Gtk2-Notify/Makefile	Mon Nov 18 19:35:09 2013	(r334255)
@@ -14,15 +14,12 @@ BUILD_DEPENDS=	p5-ExtUtils-Depends>=0:${
 		p5-ExtUtils-PkgConfig>=0:${PORTSDIR}/devel/p5-ExtUtils-PkgConfig \
 		p5-Glib2>=0:${PORTSDIR}/devel/p5-Glib2 \
 		p5-Gtk2>=0:${PORTSDIR}/x11-toolkits/p5-Gtk2
-LIB_DEPENDS=	notify.4:${PORTSDIR}/devel/libnotify
+LIB_DEPENDS=	libnotify.so:${PORTSDIR}/devel/libnotify
 RUN_DEPENDS=	p5-Gtk2>=0:${PORTSDIR}/x11-toolkits/p5-Gtk2
-
 TEST_DEPENDS=	p5-Test-Exception>=0:${PORTSDIR}/devel/p5-Test-Exception
 
+MAKE_JOBS_UNSAFE=	yes
 USES=		perl5
 USE_PERL5=	configure
 
-MAN3=		Gtk2::Notify.3 Gtk2::Notify::index.3
-
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: head/devel/p5-Gtk2-Notify/pkg-plist
==============================================================================
--- head/devel/p5-Gtk2-Notify/pkg-plist	Mon Nov 18 19:31:36 2013	(r334254)
+++ head/devel/p5-Gtk2-Notify/pkg-plist	Mon Nov 18 19:35:09 2013	(r334255)
@@ -7,6 +7,8 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Gtk2/Notify/.packlist
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Gtk2/Notify/Notify.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Gtk2/Notify/Notify.so
+%%PERL5_MAN3%%/Gtk2::Notify.3.gz
+%%PERL5_MAN3%%/Gtk2::Notify::index.3.gz
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Gtk2/Notify
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Gtk2/Notify/Install
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Gtk2/Notify
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-18 19:35:21 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!