Bug 183062 - [PATCH] graphics/squish: respect LOCALBASE, support staging
Summary: [PATCH] graphics/squish: respect LOCALBASE, support staging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 15:50 UTC by Dmitry Marakasov
Modified: 2013-10-22 20:20 UTC (History)
1 user (show)

See Also:


Attachments
squish-1.10.patch (671 bytes, patch)
2013-10-17 15:50 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2013-10-17 15:50:00 UTC
- Respect PREFIX/LOCALBASE (always installs into /usr/local otherwise)
- Support staging
- Convert USE_GMAKE to USES
- Pet portlint by reordering stuff a bit

Port maintainer (me@rdb.name) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-17 15:50:29 UTC
Maintainer of graphics/squish,

Please note that PR ports/183062 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183062

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-17 15:50:30 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-10-22 20:12:04 UTC
Author: amdmi3
Date: Tue Oct 22 19:11:57 2013
New Revision: 331307
URL: http://svnweb.freebsd.org/changeset/ports/331307

Log:
  - Respect PREFIX/LOCALBASE (always installs into /usr/local otherwise)
  - Support staging
  - Convert USE_GMAKE to USES
  - Pet portlint by reordering stuff a bit
  
  PR:		183062
  Submitted by:	amdmi3
  Approved by:	maintainer email bounces

Modified:
  head/graphics/squish/Makefile

Modified: head/graphics/squish/Makefile
==============================================================================
--- head/graphics/squish/Makefile	Tue Oct 22 19:02:06 2013	(r331306)
+++ head/graphics/squish/Makefile	Tue Oct 22 19:11:57 2013	(r331307)
@@ -10,20 +10,20 @@ MAINTAINER=	me@rdb.name
 COMMENT=	Open source DXT compression library
 
 LICENSE=	MIT
-USE_GMAKE=	YES
+
+USES=		gmake
+MAKE_ENV=	INSTALL_DIR=${STAGEDIR}${PREFIX}
 PLIST_FILES=	include/squish.h \
 		lib/libsquish.a
+CXXFLAGS+=	-fPIC
 
 OPTIONS_RADIO=	RG1
 OPTIONS_RADIO_RG1=	ALTIVEC SSE
 ALTIVEC_DESC=	Use Altivec instructions
 RG1_DESC=	Optimizations Selection
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
-CXXFLAGS+=	-fPIC
-
 .if ${PORT_OPTIONS:MALTIVEC}
 CXXFLAGS+=	-DSQUISH_USE_ALTIVEC=1 -maltivec
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2013-10-22 20:12:05 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!