Bug 183114 - [PATCH] security/unhide: fix build with clang
Summary: [PATCH] security/unhide: fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-19 22:50 UTC by Po-Chuan Hsieh
Modified: 2013-11-06 19:10 UTC (History)
1 user (show)

See Also:


Attachments
unhide-20121229.patch (2.90 KB, patch)
2013-10-19 22:50 UTC, Po-Chuan Hsieh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-10-19 22:50:00 UTC
- Remove leading indefinite article from COMMENT
- Respect CC and fix build with clang
- Support STAGEDIR
- Remove contiguous blank line from pkg-descr

Port maintainer (ntarmos@ceid.upatras.gr) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-19 22:50:09 UTC
Maintainer of security/unhide,

Please note that PR ports/183114 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183114

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-19 22:50:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-10-19 22:51:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-06 19:05:54 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-11-06 19:05:58 UTC
Author: sunpoet
Date: Wed Nov  6 19:05:49 2013
New Revision: 333032
URL: http://svnweb.freebsd.org/changeset/ports/333032

Log:
  - Respect CC and fix build with clang
  - Add LICENSE
  - Remove leading indefinite article from COMMENT
  - Support STAGEDIR
  - Remove contiguous blank line from pkg-descr
  
  PR:		ports/183114
  Submitted by:	sunpoet (myself)
  Approved by:	maintainer (timeout, 17 days)

Modified:
  head/security/unhide/Makefile
  head/security/unhide/files/patch-Makefile
  head/security/unhide/pkg-descr   (contents, props changed)

Modified: head/security/unhide/Makefile
==============================================================================
--- head/security/unhide/Makefile	Wed Nov  6 18:58:46 2013	(r333031)
+++ head/security/unhide/Makefile	Wed Nov  6 19:05:49 2013	(r333032)
@@ -9,20 +9,20 @@ DISTNAME=	${PORTNAME}_${DISTVERSION}
 EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	ntarmos@ceid.upatras.gr
-COMMENT=	A forensic tool to find hidden processes and TCP/UDP ports
+COMMENT=	Forensic tool to find hidden processes and TCP/UDP ports
 
-NO_WRKSUBDIR=	true
-PLIST_FILES=	sbin/unhide sbin/unhide-tcp
-MAN8=		unhide.8 unhide-tcp.8
-MANCOMPRESSED=	yes
+LICENSE=	GPLv3
 
-NO_STAGE=	yes
-.include <bsd.port.pre.mk>
+NO_WRKSUBDIR=	true
+PLIST_FILES=	man/man8/unhide.8.gz \
+		man/man8/unhide-tcp.8.gz \
+		sbin/unhide \
+		sbin/unhide-tcp
 
-pre-configure:
+post-patch:
 	@${REINPLACE_CMD} -e 's/-eLf/-axH/g' -e 's/$$2/$$1/g' ${WRKDIR}/unhide-posix.c
 	@${REINPLACE_CMD} -e 's/linux\/limits/limits/g' ${WRKDIR}/unhide-output.c
 	@${REINPLACE_CMD} -e 's/-tan/-p tcp -an/g' -e 's/-uan/-p udp -an/g' \
 		-e 's/use_ss = 1/use_ss = 0/g' ${WRKDIR}/unhide-tcp.c
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/security/unhide/files/patch-Makefile
==============================================================================
--- head/security/unhide/files/patch-Makefile	Wed Nov  6 18:58:46 2013	(r333031)
+++ head/security/unhide/files/patch-Makefile	Wed Nov  6 19:05:49 2013	(r333032)
@@ -1,8 +1,7 @@
 --- /dev/null	2013-01-06 20:26:43.000000000 +0200
 +++ Makefile	2013-01-06 20:26:46.000000000 +0200
-@@ -0,0 +1,23 @@
-+DESTDIR		:= ${PREFIX}
-+MANDIR		:= ${DESTDIR}/man
+@@ -0,0 +1,20 @@
++MANDIR		:= ${PREFIX}/man
 +INSTALL_PROGRAM	:= /usr/bin/install -s -m 0700
 +INSTALL_MAN	:= /usr/bin/install -m 0444
 +GZIP_CMD	:= /usr/bin/gzip -9
@@ -11,16 +10,14 @@
 +all: unhide unhide-tcp
 +
 +unhide: unhide-posix.c
-+	gcc -Wall -O2 --static unhide-posix.c -o unhide
++	${CC} -Wall -O2 --static unhide-posix.c -o unhide
 +
 +unhide-tcp: unhide-tcp.c unhide-tcp-fast.c unhide-output.c
-+	gcc -Wall -O2 --static unhide-tcp.c unhide-tcp-fast.c unhide-output.c -o unhide-tcp
++	${CC} -Wall -O2 --static unhide-tcp.c unhide-tcp-fast.c unhide-output.c -o unhide-tcp
 +
 +install: all
-+	${MKDIR_CMD} ${DESTDIR}/sbin ${MANDIR}/man8
-+	${INSTALL_PROGRAM} unhide ${DESTDIR}/sbin/unhide
-+	${INSTALL_PROGRAM} unhide-tcp ${DESTDIR}/sbin/unhide-tcp
-+	${INSTALL_MAN} man/unhide.8 ${MANDIR}/man8 && \
-+		${GZIP_CMD} ${MANDIR}/man8/unhide.8
-+	${INSTALL_MAN} man/unhide-tcp.8 ${MANDIR}/man8 && \
-+		${GZIP_CMD} ${MANDIR}/man8/unhide-tcp.8
++	${MKDIR_CMD} ${DESTDIR}${PREFIX}/sbin ${DESTDIR}${MANDIR}/man8
++	${INSTALL_PROGRAM} unhide ${DESTDIR}${PREFIX}/sbin/unhide
++	${INSTALL_PROGRAM} unhide-tcp ${DESTDIR}${PREFIX}/sbin/unhide-tcp
++	${INSTALL_MAN} man/unhide.8 ${DESTDIR}${MANDIR}/man8
++	${INSTALL_MAN} man/unhide-tcp.8 ${DESTDIR}${MANDIR}/man8

Modified: head/security/unhide/pkg-descr
==============================================================================
--- head/security/unhide/pkg-descr	Wed Nov  6 18:58:46 2013	(r333031)
+++ head/security/unhide/pkg-descr	Wed Nov  6 19:05:49 2013	(r333032)
@@ -11,5 +11,4 @@ unhide detects hidden processes through:
 unhide-tcp identifies TCP/UDP ports that are listening but not listed in
 /bin/netstat by doing brute forcing of all TCP/UDP ports availables.
 
-
 WWW: http://www.unhide-forensics.info/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"