- Fixup after latest textproc/cdiff update - Convert to staging Port maintainer (joemann@beefree.free.de) is cc'd. Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Maintainer of ports-mgmt/porttools, Please note that PR ports/183188 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183188 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->mat Take
Hi! Thanks for your patch! Please excuse my delayed response. On Tue, 22 Oct 2013 11:36:04 +0200 (CEST), Mathieu Arnold <mat@FreeBSD.org> wrote: > [...] > -.if ${PORT_OPTIONS:MNEWFILE} > -RUN_DEPENDS+= newfile:${PORTSDIR}/devel/newfile > -.endif > - > -.if ${PORT_OPTIONS:MDOCS} > -INSTALL_TARGET= install install-docs > -.endif > +NEWFILE_RUN_DEPENDS= newfile:${PORTSDIR}/devel/newfile > +DOCS_INSTALL_TARGET= install install-docs Unfortunately, this doesn't work for me: % make package [...] install -m 444 porttools.5 /mnt/work/wrkdirprefix/home/joemann/src/ports/porttools/work/stage/usr/local/man/man5 ====> Compressing man pages ===> Building package for porttools-0.99_9 pkg-static: lstat([...]/porttools/work/stage/usr/local/share/doc/porttools/LICENSE): No such file or directory pkg-static: lstat([...]/porttools/work/stage/usr/local/share/doc/porttools/README): No such file or directory [...] *** [do-package] Error code 1 But if I change the Makefile from OPTIONS_DEFINE= NEWFILE to OPTIONS_DEFINE= DOCS NEWFILE then your patch works (for me too:). Looking forward to your response Johannes
+--On 30 octobre 2013 20:23:55 +0100 Johannes 5 Joemann <joemann@beefree.free.de> wrote: | Hi! | | Thanks for your patch! Please excuse my delayed response. | | But if I change the Makefile from | OPTIONS_DEFINE= NEWFILE | to | OPTIONS_DEFINE= DOCS NEWFILE | then your patch works (for me too:). Yes, you're right, it's was a late change, I misread a bit about how the DOCS and EXAMPLES options work. You do need to add them there. -- Mathieu Arnold
State Changed From-To: feedback->closed Committed, thanks!
Author: mat Date: Wed Nov 6 12:25:51 2013 New Revision: 332978 URL: http://svnweb.freebsd.org/changeset/ports/332978 Log: - Fixup after latest textproc/cdiff update - Convert to staging PR: ports/183188 Submitted by: mat Approved by: maintainer Modified: head/ports-mgmt/porttools/Makefile head/ports-mgmt/porttools/files/patch-Makefile head/ports-mgmt/porttools/files/patch-cmd_diff.in head/ports-mgmt/porttools/pkg-plist Modified: head/ports-mgmt/porttools/Makefile ============================================================================== --- head/ports-mgmt/porttools/Makefile Wed Nov 6 12:25:00 2013 (r332977) +++ head/ports-mgmt/porttools/Makefile Wed Nov 6 12:25:51 2013 (r332978) @@ -3,7 +3,7 @@ PORTNAME= porttools PORTVERSION= 0.99 -PORTREVISION= 8 +PORTREVISION= 9 CATEGORIES= ports-mgmt MASTER_SITES= SF @@ -28,23 +28,12 @@ MAKE_ENV+= PORTREVISION="${PORTREVISION} MAKE_ENV+= PORTEPOCH="${PORTEPOCH}" .endif -MAN1= port.1 -MAN5= porttools.5 - -OPTIONS_DEFINE= NEWFILE +OPTIONS_DEFINE= DOCS NEWFILE OPTIONS_DEFAULT= NEWFILE NEWFILE_DESC= Enable newfile support -NO_STAGE= yes -.include <bsd.port.options.mk> - -.if ${PORT_OPTIONS:MNEWFILE} -RUN_DEPENDS+= newfile:${PORTSDIR}/devel/newfile -.endif - -.if ${PORT_OPTIONS:MDOCS} -INSTALL_TARGET= install install-docs -.endif +NEWFILE_RUN_DEPENDS= newfile:${PORTSDIR}/devel/newfile +DOCS_INSTALL_TARGET= install install-docs .include <bsd.port.mk> Modified: head/ports-mgmt/porttools/files/patch-Makefile ============================================================================== --- head/ports-mgmt/porttools/files/patch-Makefile Wed Nov 6 12:25:00 2013 (r332977) +++ head/ports-mgmt/porttools/files/patch-Makefile Wed Nov 6 12:25:51 2013 (r332978) @@ -1,5 +1,5 @@ --- ./Makefile.orig 2009-09-09 21:59:59.000000000 +0200 -+++ ./Makefile 2011-11-23 23:11:14.000000000 +0100 ++++ ./Makefile 2013-10-22 10:41:23.000000000 +0200 @@ -9,6 +9,15 @@ PORTNAME?= porttools PORTVERSION?= 0.99 @@ -16,7 +16,7 @@ PROGRAMS= port SCRIPTS= cmd_commit cmd_create cmd_diff cmd_fetch cmd_getpr cmd_help \ -@@ -31,8 +40,8 @@ +@@ -31,23 +40,23 @@ .SUFFIXES: .in @@ -27,3 +27,27 @@ inc_header.in ${.IMPSRC} > ${.TARGET} chmod a+x ${.TARGET} + install: ${PROGRAMS} ${SCRIPTS} +- ${BSD_INSTALL_SCRIPT} ${PROGRAMS} ${PREFIX}/bin +- mkdir -p ${DATADIR} +- ${BSD_INSTALL_SCRIPT} ${SCRIPTS} ${DATADIR} +- mkdir -p ${MANPREFIX}/man/man1 +- ${BSD_INSTALL_MAN} ${MAN1} ${MANPREFIX}/man/man1 +- mkdir -p ${MANPREFIX}/man/man5 +- ${BSD_INSTALL_MAN} ${MAN5} ${MANPREFIX}/man/man5 ++ ${BSD_INSTALL_SCRIPT} ${PROGRAMS} ${DESTDIR}${PREFIX}/bin ++ mkdir -p ${DESTDIR}${DATADIR} ++ ${BSD_INSTALL_SCRIPT} ${SCRIPTS} ${DESTDIR}${DATADIR} ++ mkdir -p ${DESTDIR}${MANPREFIX}/man/man1 ++ ${BSD_INSTALL_MAN} ${MAN1} ${DESTDIR}${MANPREFIX}/man/man1 ++ mkdir -p ${DESTDIR}${MANPREFIX}/man/man5 ++ ${BSD_INSTALL_MAN} ${MAN5} ${DESTDIR}${MANPREFIX}/man/man5 + + install-docs: +- mkdir -p ${DOCSDIR} +- ${BSD_INSTALL_DATA} ${DOCS} ${DOCSDIR} ++ mkdir -p ${DESTDIR}${DOCSDIR} ++ ${BSD_INSTALL_DATA} ${DOCS} ${DESTDIR}${DOCSDIR} + + clean: + rm -rf ${PROGRAMS} ${SCRIPTS} ${DISTNAME}* Modified: head/ports-mgmt/porttools/files/patch-cmd_diff.in ============================================================================== --- head/ports-mgmt/porttools/files/patch-cmd_diff.in Wed Nov 6 12:25:00 2013 (r332977) +++ head/ports-mgmt/porttools/files/patch-cmd_diff.in Wed Nov 6 12:25:51 2013 (r332978) @@ -1,5 +1,5 @@ ---- cmd_diff.in.orig 2009-09-10 04:59:59.000000000 +0900 -+++ cmd_diff.in 2012-12-27 20:13:30.000000000 +0900 +--- cmd_diff.in.orig 2009-09-09 21:59:59.000000000 +0200 ++++ cmd_diff.in 2013-10-22 10:37:13.000000000 +0200 @@ -20,7 +20,7 @@ Usage: port diff [-h] [-d <diff mode>] -h - Display this usage summary @@ -9,3 +9,12 @@ <dir> - against Ports tree in <dir> <pattern> - against original port in <pwd><pattern> EOF +@@ -65,7 +65,7 @@ + [ -n "${DIFF_VIEWER}" ] || DIFF_VIEWER="more" + fi + echo "===> Viewing diff with ${DIFF_VIEWER}" +-${DIFF_VIEWER} ${PATCH} ++${DIFF_VIEWER} < ${PATCH} + + # Cleanup + rm -rf ${TEMPROOT} Modified: head/ports-mgmt/porttools/pkg-plist ============================================================================== --- head/ports-mgmt/porttools/pkg-plist Wed Nov 6 12:25:00 2013 (r332977) +++ head/ports-mgmt/porttools/pkg-plist Wed Nov 6 12:25:51 2013 (r332978) @@ -1,5 +1,7 @@ @comment $FreeBSD$ bin/port +man/man1/port.1.gz +man/man5/porttools.5.gz %%DATADIR%%/cmd_commit %%DATADIR%%/cmd_create %%DATADIR%%/cmd_diff _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"