Bug 183393 - [PATCH] devel/p5-ExtUtils-ParseXS: Fixup build with pkgng
Summary: [PATCH] devel/p5-ExtUtils-ParseXS: Fixup build with pkgng
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-28 12:00 UTC by Mathieu Arnold
Modified: 2013-10-29 23:16 UTC (History)
1 user (show)

See Also:

Attachments
p5-ExtUtils-ParseXS-3.22.patch (1.19 KB, patch)
2013-10-28 12:00 UTC, Mathieu Arnold 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Sivachenko 2013-10-28 11:59:38 UTC 
My bad, sorry.

Can you please commit this?

Thanks!
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2013-10-28 12:00:00 UTC 
With pkgng, you can't overwrite files that already exist. We ship a xsubpp file
with every perl version we have, so this port will never install.

Port maintainer (demon@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-28 12:00:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->demon

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-10-28 12:02:06 UTC 
Author: mat
Date: Mon Oct 28 12:01:59 2013
New Revision: 331844
URL: http://svnweb.freebsd.org/changeset/ports/331844

Log:
  Fixup install, don't overwrite existing files.
  
  PR:		ports/183393
  Submitted by:	mat
  Approved by:	demon (maintainer)

Modified:
  head/devel/p5-ExtUtils-ParseXS/Makefile
  head/devel/p5-ExtUtils-ParseXS/pkg-plist

Modified: head/devel/p5-ExtUtils-ParseXS/Makefile
==============================================================================
--- head/devel/p5-ExtUtils-ParseXS/Makefile	Mon Oct 28 11:19:20 2013	(r331843)
+++ head/devel/p5-ExtUtils-ParseXS/Makefile	Mon Oct 28 12:01:59 2013	(r331844)
@@ -11,7 +11,13 @@ PKGNAMEPREFIX=	p5-
 MAINTAINER=	demon@FreeBSD.org
 COMMENT=	Converts Perl XS code into C code
 
-USES=		perl5
+USES=		perl5 shebangfix
 USE_PERL5=	configure
+# Overwrite this here
+perl_OLD_CMD=	perl
+SHEBANG_FILES=	lib/ExtUtils/xsubpp
+
+post-patch:
+	@${REINPLACE_CMD} '/EXE_FILES/d' ${WRKSRC}/Makefile.PL
 
 .include <bsd.port.mk>

Modified: head/devel/p5-ExtUtils-ParseXS/pkg-plist
==============================================================================
--- head/devel/p5-ExtUtils-ParseXS/pkg-plist	Mon Oct 28 11:19:20 2013	(r331843)
+++ head/devel/p5-ExtUtils-ParseXS/pkg-plist	Mon Oct 28 12:01:59 2013	(r331844)
@@ -1,5 +1,3 @@
-bin/xsubpp
-man/man1/xsubpp.1.gz
 %%PERL5_MAN3%%/ExtUtils::ParseXS.3.gz
 %%PERL5_MAN3%%/ExtUtils::ParseXS::Constants.3.gz
 %%PERL5_MAN3%%/ExtUtils::ParseXS::Eval.3.gz
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2013-10-28 12:03:09 UTC 
State Changed
From-To: open->closed

Committed, thanks!