Bug 183702 - [PATCH] security/xca: Fix build on 10 and head
Summary: [PATCH] security/xca: Fix build on 10 and head
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 23:00 UTC by Guido Falsi
Modified: 2013-11-06 18:20 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (2.33 KB, patch)
2013-11-05 23:00 UTC, Guido Falsi
no flags Details | Diff
patch.txt (2.54 KB, text/x-diff)
2013-11-05 23:41 UTC, freebsd
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2013-11-05 23:00:00 UTC
- Fix build with new ld behavior (on 10 and head)
- Add USES=desktop-file-utils
- Convert to staging
- Use space in pkg-descr WWW line
- Remove redundant update-mime-database lines from pkg-plist
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-05 23:00:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-05 23:00:08 UTC
Maintainer of security/xca,

Please note that PR ports/183702 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183702

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2013-11-05 23:13:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 4 freebsd 2013-11-05 23:41:59 UTC
Slightly modified patch that further simplifies the Makefile.
I'll trust the original patch does indeed fix the link error as it  
just works for me. :>
Thanks & kind regards.
Alex.

Zitat von madpilot@freebsd.org:

> Synopsis: [PATCH] security/xca: Fix build on 10 and head
>
> Responsible-Changed-From-To: freebsd-ports-bugs->madpilot
> Responsible-Changed-By: madpilot
> Responsible-Changed-When: Tue Nov 5 23:13:12 UTC 2013
> Responsible-Changed-Why:
> I'll take it.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=183702

Comment 5 dfilter service freebsd_committer freebsd_triage 2013-11-06 18:11:24 UTC
Author: madpilot
Date: Wed Nov  6 18:11:17 2013
New Revision: 333020
URL: http://svnweb.freebsd.org/changeset/ports/333020

Log:
  - Fix build with new ld behavior (on 10 and head)
  - Add USES=desktop-file-utils
  - Convert to staging
  - Use space in pkg-descr WWW line
  - Remove redundant update-mime-database lines from pkg-plist
  
  PR:		ports/183702
  Submitted by:	Me
  Approved by:	FreeBSD@nagilum.org (maintainer)

Modified:
  head/security/xca/Makefile   (contents, props changed)
  head/security/xca/pkg-descr   (contents, props changed)
  head/security/xca/pkg-plist   (contents, props changed)

Modified: head/security/xca/Makefile
==============================================================================
--- head/security/xca/Makefile	Wed Nov  6 18:04:20 2013	(r333019)
+++ head/security/xca/Makefile	Wed Nov  6 18:11:17 2013	(r333020)
@@ -3,7 +3,7 @@
 
 PORTNAME=	xca
 PORTVERSION=	0.9.3
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	security
 MASTER_SITES=	SF
 
@@ -15,17 +15,20 @@ LICENSE=	BSD
 USE_OPENSSL=	yes
 USE_QT4=	gui moc_build uic_build qmake_build rcc_build linguist_build
 USE_AUTOTOOLS=	libltdl
-USES=		gmake shared-mime-info
+USES=		desktop-file-utils gmake shared-mime-info
+DESTDIRNAME=	destdir
 
-MAN1=		xca.1
-MANCOMPRESSED=	yes
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} >= 1000054
+LD_CXX_LIB=	-lc++
+.endif
 
-NO_STAGE=	yes
 post-patch:
 	@echo "CPPFLAGS=-I. -I.. -I${WRKSRC}/ui -I${QT_INCDIR} -I${QT_INCDIR}/Qt -I${LOCALBASE}/include" > ${WRKSRC}/Local.mak
 	@echo "CFLAGS= ${CFLAGS} -Wall -ggdb" >> ${WRKSRC}/Local.mak
 	@echo "LDFLAGS= ${LDFLAGS} -L${QT_LIBDIR} -L${LOCALBASE}/lib" >> ${WRKSRC}/Local.mak
-	@echo "LIBS= -lQtGui ${PTHREAD_LIBS} -lcrypto -lltdl" >> ${WRKSRC}/Local.mak
+	@echo "LIBS=-lQtCore -lQtGui ${PTHREAD_LIBS} -lcrypto -lltdl ${LD_CXX_LIB}" >> ${WRKSRC}/Local.mak
 	@echo "MOC=${MOC}" >> ${WRKSRC}/Local.mak
 	@echo "UIC=${QT_PREFIX}/bin/uic-qt4" >> ${WRKSRC}/Local.mak
 	@echo "RCC=${LOCALBASE}/bin/rcc"  >> ${WRKSRC}/Local.mak
@@ -45,7 +48,4 @@ post-patch:
 	@${REINPLACE_CMD} -e "/VPATH/{G;s/$$/TOPDIR_/;}" -e "s:\(TOPDIR\)_:\1=${WRKSRC}:" ${WRKSRC}/misc/Makefile
 	@${REINPLACE_CMD} -e 's|malloc.h|stdlib.h|' ${WRKSRC}/lib/import.cpp
 
-post-configure:
-	${REINPLACE_CMD} -e 's/-lQtGui/-lQtCore -lQtGui/' ${WRKSRC}/Local.mak
-
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

Modified: head/security/xca/pkg-descr
==============================================================================
--- head/security/xca/pkg-descr	Wed Nov  6 18:04:20 2013	(r333019)
+++ head/security/xca/pkg-descr	Wed Nov  6 18:11:17 2013	(r333020)
@@ -6,4 +6,4 @@ signing and revoking of PEM DER PKCS12, 
 A tree view of certificates is presented.
 
 Author:	Christian Hohnstaedt <christian@hohnstaedt.de>
-WWW:	http://www.hohnstaedt.de/xca.html
+WWW: http://www.hohnstaedt.de/xca.html

Modified: head/security/xca/pkg-plist
==============================================================================
--- head/security/xca/pkg-plist	Wed Nov  6 18:04:20 2013	(r333019)
+++ head/security/xca/pkg-plist	Wed Nov  6 18:11:17 2013	(r333020)
@@ -14,6 +14,7 @@ bin/xca
 %%DATADIR%%/xca_ru.qm
 %%DATADIR%%/xca_tr.qm
 %%DOCSDIR%%/xca.html
+man/man1/xca.1.gz
 share/applications/xca.desktop
 share/mime/packages/xca.xml
 share/pixmaps/xca-32x32.xpm
@@ -21,5 +22,3 @@ share/pixmaps/xca-32x32.xpm
 @dirrm %%DOCSDIR%%
 @dirrmtry share/mime/packages
 @dirrmtry share/mime
-@exec %%LOCALBASE%%/bin/update-mime-database %D/share/mime > /dev/null || /usr/bin/true
-@unexec %%LOCALBASE%%/bin/update-mime-database %D/share/mime > /dev/null || /usr/bin/true
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2013-11-06 18:11:30 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!