Bug 183718 - [PATCH] astro/wcslib: Support staging, fix .pc file installation path.
Summary: [PATCH] astro/wcslib: Support staging, fix .pc file installation path.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 15:20 UTC by Raphael Kubo da Costa
Modified: 2013-11-10 17:30 UTC (History)
1 user (show)

See Also:


Attachments
wcslib-4.13.4.patch (2.85 KB, patch)
2013-11-06 15:20 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2013-11-06 15:20:01 UTC
- Support staging, which allows us to simplify the Makefile a bit.
- Fix a regression introduced in r297435 (ports/167611) that hardcoded wcslib.pc's installation path and rendered the sed call in the post-patch target useless. This broke automated builds in things like Poudriere.

Port maintainer (tonymaher@optusnet.com.au) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-06 15:20:09 UTC
Maintainer of astro/wcslib,

Please note that PR ports/183718 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183718

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-06 15:20:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 tonymaher 2013-11-08 21:13:44 UTC
Approved.

-- 
Tony Maher                    email: tonymaher@optusnet.com.au
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2013-11-09 18:45:58 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-11-10 17:27:25 UTC
Author: rakuco
Date: Sun Nov 10 17:27:16 2013
New Revision: 333411
URL: http://svnweb.freebsd.org/changeset/ports/333411

Log:
  - Support staging, which allows us to simplify the Makefile a bit.
  - Fix a regression introduced in r297435 (ports/167611) that hardcoded
    wcslib.pc's installation path and rendered the sed call in the post-patch
    target useless. This broke automated builds in things like Poudriere.
  
  PR:		ports/183718
  Submitted by:	rakuco@
  Approved by:	Tony Maher <tonymaher@optusnet.com.au> (maintainer)

Modified:
  head/astro/wcslib/Makefile
  head/astro/wcslib/files/patch-GNUmakefile
  head/astro/wcslib/pkg-plist

Modified: head/astro/wcslib/Makefile
==============================================================================
--- head/astro/wcslib/Makefile	Sun Nov 10 16:57:25 2013	(r333410)
+++ head/astro/wcslib/Makefile	Sun Nov 10 17:27:16 2013	(r333411)
@@ -9,7 +9,6 @@ MASTER_SITES=	ftp://ftp.atnf.csiro.au/pu
 MAINTAINER=	tonymaher@optusnet.com.au
 COMMENT=	Library for parsing/generating FITS headers
 
-NO_STAGE=	yes
 USE_BZIP2=	yes
 GNU_CONFIGURE=	yes
 USES=		gmake
@@ -17,7 +16,6 @@ MAKEFILE=	GNUmakefile
 USE_LDCONFIG=	yes
 
 PLIST_SUB=	VERSION="${PORTVERSION}"
-MAN1=		fitshdr.1
 
 # See makedefs.in which describes why you want to set the extra support.
 # For most users it will not be required.
@@ -43,15 +41,13 @@ LIB_DEPENDS+=	pgplot.5:${PORTSDIR}/graph
 .endif
 
 post-patch:
-	@${REINPLACE_CMD} -e 's#%%PKGDIR%%#${LOCALBASE}/libdata#g' \
+	@${REINPLACE_CMD} -e 's#%%PKGDIR%%#${STAGEDIR}${PREFIX}/libdata#g' \
 		${WRKSRC}/GNUmakefile
 
 post-install:
-.if ${PORT_OPTIONS:MDOCS}
-	@${MKDIR} ${DOCSDIR}
-	(cd ${WRKSRC}/ && ${INSTALL_DATA} CHANGES README COPYING COPYING.LESSER wcslib.pdf ${DOCSDIR})
-	@${MKDIR} ${DOCSDIR}/html
-	(cd ${WRKSRC}/html && ${INSTALL_DATA} * ${DOCSDIR}/html)
-.endif
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
+	(cd ${WRKSRC}/ && ${INSTALL_DATA} CHANGES README COPYING COPYING.LESSER wcslib.pdf ${STAGEDIR}${DOCSDIR})
+	${MKDIR} ${STAGEDIR}${DOCSDIR}/html
+	(cd ${WRKSRC}/html && ${INSTALL_DATA} * ${STAGEDIR}${DOCSDIR}/html)
 
 .include <bsd.port.mk>

Modified: head/astro/wcslib/files/patch-GNUmakefile
==============================================================================
--- head/astro/wcslib/files/patch-GNUmakefile	Sun Nov 10 16:57:25 2013	(r333410)
+++ head/astro/wcslib/files/patch-GNUmakefile	Sun Nov 10 17:27:16 2013	(r333411)
@@ -22,11 +22,11 @@
 -	   $(INSTALL) -m 444 html/* $(HTMLDIR)/html
 -	   if [ ! -d "$(LIBDIR)/pkgconfig" ] ; then \
 -	     $(INSTALL) -d -m 2775 $(LIBDIR)/pkgconfig ; \
-+	   if [ ! -d "/usr/local/libdata/pkgconfig" ] ; then \
-+	     $(INSTALL) -d -m 2775 /usr/local/libdata/pkgconfig ; \
++	   if [ ! -d "%%PKGDIR%%/pkgconfig" ] ; then \
++	     $(INSTALL) -d -m 2775 %%PKGDIR%%/pkgconfig ; \
  	   fi
 -	   $(INSTALL) -m 444 wcslib.pc $(LIBDIR)/pkgconfig/wcslib.pc
-+	   $(INSTALL) -m 444 wcslib.pc /usr/local/libdata/pkgconfig/wcslib.pc
++	   $(INSTALL) -m 444 wcslib.pc %%PKGDIR%%/pkgconfig/wcslib.pc
  
  clean cleaner :
  	   for DIR in $(SUBDIRS) doxygen ; do \

Modified: head/astro/wcslib/pkg-plist
==============================================================================
--- head/astro/wcslib/pkg-plist	Sun Nov 10 16:57:25 2013	(r333410)
+++ head/astro/wcslib/pkg-plist	Sun Nov 10 17:27:16 2013	(r333411)
@@ -29,6 +29,7 @@ lib/libwcs.so
 lib/libwcs.so.%%VERSION%%
 lib/libwcs.so.4
 libdata/pkgconfig/wcslib.pc
+man/man1/fitshdr.1.gz
 %%PORTDOCS%%%%DOCSDIR%%/html/functions_0x73.html
 %%PORTDOCS%%%%DOCSDIR%%/html/functions_vars_0x62.html
 %%PORTDOCS%%%%DOCSDIR%%/html/wcshdr_8h-source.html
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2013-11-10 17:27:34 UTC
State Changed
From-To: open->closed

Committed in r333411.