Bug 183982 - [MAINTAINER] databases/php5-pdo_cassandra: [SUMMARIZE CHANGES]
Summary: [MAINTAINER] databases/php5-pdo_cassandra: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-15 08:40 UTC by Gasol Wu
Modified: 2013-11-15 18:01 UTC (History)
0 users

See Also:


Attachments
php5-pdo_cassandra-0.2.1_2.patch (3.70 KB, patch)
2013-11-15 08:40 UTC, Gasol Wu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gasol Wu 2013-11-15 08:40:00 UTC
1. Fix broken caused by thrift-0.9.1,1
2. Stage support
3. Add LICENSE
4. portlint warning

Generated with FreeBSD Port Tools 0.99_9 (mode: change, diff: ports)
Comment 1 Gasol Wu 2013-11-15 08:42:03 UTC
Please ignore the swap files, Thanks.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-15 09:26:50 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-11-15 17:55:39 UTC
Author: sunpoet
Date: Fri Nov 15 17:55:27 2013
New Revision: 333899
URL: http://svnweb.freebsd.org/changeset/ports/333899

Log:
  - Fix build with thrift-0.9.1
  - Add LICENSE
  - Support STAGEDIR
  - Use single space after WWW:
  
  PR:		ports/183982
  Submitted by:	Gasol Wu <gasol.wu@gmail.com> (maintainer)

Added:
  head/databases/php5-pdo_cassandra/files/
  head/databases/php5-pdo_cassandra/files/patch-config.m4   (contents, props changed)
Modified:
  head/databases/php5-pdo_cassandra/Makefile
  head/databases/php5-pdo_cassandra/pkg-descr   (contents, props changed)

Modified: head/databases/php5-pdo_cassandra/Makefile
==============================================================================
--- head/databases/php5-pdo_cassandra/Makefile	Fri Nov 15 17:55:22 2013	(r333898)
+++ head/databases/php5-pdo_cassandra/Makefile	Fri Nov 15 17:55:27 2013	(r333899)
@@ -3,7 +3,7 @@
 
 PORTNAME=	pdo_cassandra
 PORTVERSION=	0.2.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 MASTER_SITES=	https://github.com/${GITHUB_USER}/php-${PORTNAME}/tarball/${GITREVISION}/
 PKGNAMEPREFIX=	php5-
@@ -12,8 +12,9 @@ DISTNAME=	${GITHUB_USER}-php-${PORTNAME}
 MAINTAINER=	gasol.wu@gmail.com
 COMMENT=	PDO driver for Apache Cassandra
 
-LIB_DEPENDS=	boost_iostreams:${PORTSDIR}/devel/boost-libs \
-		thrift:${PORTSDIR}/devel/thrift
+LICENSE=	AL2
+
+LIB_DEPENDS=	libboost_iostreams.so:${PORTSDIR}/devel/boost-libs
 
 GITREVISION=	7debd5b
 GITTAG=		0.8-support
@@ -27,14 +28,25 @@ USE_PHP=	pdo
 USE_PHPEXT=	yes
 DEFAULT_PHP_VER=5
 IGNORE_WITH_PHP=52
-THRIFT_CMD=	${LOCALBASE}/bin/thrift
 
-NO_STAGE=	yes
+.include <bsd.port.pre.mk>
+.include "${PORTSDIR}/devel/thrift/bsd.thrift.mk"
+
+THRIFT_MAJOR_VER=	${THRIFT_PORTVERSION:R:R}
+THRIFT_MINOR_VER=	${THRIFT_PORTVERSION:R:E}
+THRIFT_PATCH_VER=	${THRIFT_PORTVERSION:E}
+
+.if ${THRIFT_MAJOR_VER} >= 0 || ${THRIFT_MINOR_VER} >= 9 || ${THRIFT_PATCH_VER} >= 1
+LIB_DEPENDS+=	libthrift.so:${PORTSDIR}/devel/thrift-cpp
+BUILD_DEPENDS+=	${LOCALBASE}/bin/thrift:${PORTSDIR}/devel/thrift
+.else
+LIB_DEPENDS+=	libthrift.so:${PORTSDIR}/devel/thrift
+.endif
+
 post-configure:
-	thrift_version=`${THRIFT_CMD} -version | ${AWK} '{print $$3}'`; \
-	if [ "$$thrift_version" = "0.8.0" ]; then \
-		${REINPLACE_CMD} 's/\([^:]\)apache::thrift/\1 ::apache::thrift/g' ${WRKSRC}/gen-cpp/Cassandra.h; \
-		${REINPLACE_CMD} 's/\([^:]\)apache::thrift/\1 ::apache::thrift/g' ${WRKSRC}/gen-cpp/Cassandra.cpp; \
-	fi
+.if ${THRIFT_PORTVERSION} == "0.8.0"
+	${REINPLACE_CMD} 's/\([^:]\)apache::thrift/\1 ::apache::thrift/g' ${WRKSRC}/gen-cpp/Cassandra.h
+	${REINPLACE_CMD} 's/\([^:]\)apache::thrift/\1 ::apache::thrift/g' ${WRKSRC}/gen-cpp/Cassandra.cpp
+.endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

Added: head/databases/php5-pdo_cassandra/files/patch-config.m4
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/databases/php5-pdo_cassandra/files/patch-config.m4	Fri Nov 15 17:55:27 2013	(r333899)
@@ -0,0 +1,22 @@
+--- ./config.m4.orig	2011-12-30 17:41:22.000000000 +0800
++++ ./config.m4	2013-11-14 21:46:12.000000000 +0800
+@@ -38,8 +38,18 @@
+     PHP_THRIFT_VERSION=`${PKG_CONFIG} thrift --modversion`
+ 
+     AC_MSG_RESULT([found version ${PHP_THRIFT_VERSION}])
++    ac_IFS=$IFS
++    IFS="."
++    set $PHP_THRIFT_VERSION
++    IFS=$ac_IFS
++    dnl workaround for changes of THRIFT-1968
++    THRIFT_VERSION=`expr [$]1 \* 10000 + [$]2 \* 100 + [$]3`
++    if test "$THRIFT_VERSION" -ge "901"; then
++      PHP_THRIFT_INCS="-I`${PKG_CONFIG} thrift --variable=includedir`/thrift"
++    else
++      PHP_THRIFT_INCS=`${PKG_CONFIG} thrift --cflags`
++    fi
+     PHP_THRIFT_LIBS=`${PKG_CONFIG} thrift --libs`
+-    PHP_THRIFT_INCS=`${PKG_CONFIG} thrift --cflags`
+ 
+     PHP_EVAL_LIBLINE(${PHP_THRIFT_LIBS}, PDO_CASSANDRA_SHARED_LIBADD)
+     PHP_EVAL_INCLINE(${PHP_THRIFT_INCS})

Modified: head/databases/php5-pdo_cassandra/pkg-descr
==============================================================================
--- head/databases/php5-pdo_cassandra/pkg-descr	Fri Nov 15 17:55:22 2013	(r333898)
+++ head/databases/php5-pdo_cassandra/pkg-descr	Fri Nov 15 17:55:27 2013	(r333899)
@@ -7,4 +7,4 @@ BigTable. Like Dynamo, Cassandra is even
 BigTable, Cassandra provides a ColumnFamily-based data model richer
 than typical key/value systems.
 
-WWW:	http://code.google.com/a/apache-extras.org/p/cassandra-pdo/
+WWW: http://code.google.com/a/apache-extras.org/p/cassandra-pdo/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-15 18:01:38 UTC
State Changed
From-To: open->closed

Committed. Thanks!