Bug 184061 - Update of www/node-devel==v0.11.8
Summary: Update of www/node-devel==v0.11.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-19 01:10 UTC by amim.knabben
Modified: 2013-11-19 10:20 UTC (History)
0 users

See Also:


Attachments
file.diff (451 bytes, patch)
2013-11-19 01:10 UTC, amim.knabben
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description amim.knabben 2013-11-19 01:10:00 UTC
In updating www/node-devel to the actual devel version, an error is generated by the v8 node subsystem, the patch attached fix it.

Opening the PR to update the package to v0.11.8

Fix: Patch is attached

Patch attached with submission follows:
How-To-Repeat: Compile the last devel v0.11.8 version of Node.JS
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-19 01:10:07 UTC
Maintainer of www/node-devel,

Please note that PR ports/184061 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184061

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-19 01:10:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 linpct 2013-11-19 03:20:20 UTC
Maintainer approved.

Please see the full shar file at
https://raw.github.com/pct/freebsd_files/master/ports/www/node-devel.shar .


2013/11/19 Edwin Groothuis <edwin@freebsd.org>

> Maintainer of www/node-devel,
>
> Please note that PR ports/184061 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184061
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>



-- 
Daniel Lin (pct)
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2013-11-19 04:52:34 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-19 09:39:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-11-19 10:12:15 UTC
Author: sunpoet
Date: Tue Nov 19 10:12:06 2013
New Revision: 334296
URL: http://svnweb.freebsd.org/changeset/ports/334296

Log:
  - Update to 0.11.8
  - While I'm here:
    - Add LICENSE
    - Convert to new LIB_DEPENDS format
    - Support STAGEDIR
  
  Changes:	https://github.com/joyent/node/blob/v0.11.8-release/ChangeLog
  PR:		ports/184061
  Submitted by:	Amim Knabben <amim.knabben@gmail.com>
  Approved by:	Daniel Lin <linpct@gmail.com> (maintainer)

Added:
  head/www/node-devel/files/
  head/www/node-devel/files/patch-platform-freebsd.cc   (contents, props changed)
Modified:
  head/www/node-devel/Makefile
  head/www/node-devel/distinfo
  head/www/node-devel/pkg-plist

Modified: head/www/node-devel/Makefile
==============================================================================
--- head/www/node-devel/Makefile	Tue Nov 19 10:12:00 2013	(r334295)
+++ head/www/node-devel/Makefile	Tue Nov 19 10:12:06 2013	(r334296)
@@ -1,8 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	node
-PORTVERSION=	0.11.7
-PORTREVISION=	1
+PORTVERSION=	0.11.8
 CATEGORIES=	www
 MASTER_SITES=	http://nodejs.org/dist/v${PORTVERSION}/
 PKGNAMESUFFIX=	-devel
@@ -11,9 +10,9 @@ DISTNAME=	${PORTNAME}-v${PORTVERSION}
 MAINTAINER=	linpct@gmail.com
 COMMENT=	V8 javascript for client and server
 
-LIB_DEPENDS=	execinfo:${PORTSDIR}/devel/libexecinfo
+LICENSE=	MIT
 
-MAN1=		node.1
+LIB_DEPENDS=	libexecinfo.so:${PORTSDIR}/devel/libexecinfo
 
 USES=		gmake
 HAS_CONFIGURE=	yes
@@ -27,12 +26,11 @@ CONFIGURE_ARGS=	--prefix=${PREFIX_RELDES
 PREFIX_RELDEST=	${PREFIX:S,^${DESTDIR},,}
 REINPLACE_ARGS=	-i ''
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${OSVERSION} >= 900033 && exists(/usr/bin/clang)
-CC=	clang
-CXX=	clang++
+CC=		clang
+CXX=		clang++
 GYP_DEFINES+=	clang=1
 .else
 USE_GCC?=	yes
@@ -44,9 +42,9 @@ post-patch:
 		${WRKSRC}/deps/v8/tools/gyp/v8.gyp
 
 post-install:
-	${MKDIR} ${PREFIX}/lib/node_modules/
-	${TOUCH} ${PREFIX}/lib/node_modules/.keepme
-	${CHMOD} ${MANMODE} ${PREFIX}/man/man1/node.1
+	${MKDIR} ${STAGEDIR}${PREFIX}/lib/node_modules/
+	${TOUCH} ${STAGEDIR}${PREFIX}/lib/node_modules/.keepme
+	${CHMOD} ${MANMODE} ${STAGEDIR}${PREFIX}/man/man1/node.1
 	@${ECHO_MSG}
 	@${ECHO_MSG} "Note: If you need npm (Node Package Manager), please install www/npm."
 	@${ECHO_MSG}

Modified: head/www/node-devel/distinfo
==============================================================================
--- head/www/node-devel/distinfo	Tue Nov 19 10:12:00 2013	(r334295)
+++ head/www/node-devel/distinfo	Tue Nov 19 10:12:06 2013	(r334296)
@@ -1,2 +1,2 @@
-SHA256 (node-v0.11.7.tar.gz) = d915345639e340405b01f259971f386aafb5a10544b162826514cf56ddd371fe
-SIZE (node-v0.11.7.tar.gz) = 14885051
+SHA256 (node-v0.11.8.tar.gz) = 87c809dea764d5d66f925626fba403fb2fb0c0ccfad408bf79fdb62dc246d65b
+SIZE (node-v0.11.8.tar.gz) = 14937740

Added: head/www/node-devel/files/patch-platform-freebsd.cc
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/node-devel/files/patch-platform-freebsd.cc	Tue Nov 19 10:12:06 2013	(r334296)
@@ -0,0 +1,11 @@
+--- deps/v8/src/platform-freebsd.orig 2013-11-18 22:50:13.000000000 -0200
++++ deps/v8/src/platform-freebsd.cc 2013-11-18 22:55:37.000000000 -0200
+@@ -189,7 +189,7 @@
+     // There may be no filename in this line.  Skip to next.
+     if (start_of_path == NULL) continue;
+     buffer[bytes_read] = 0;
+-    LOG(isolate SharedLibraryEvent(start_of_path, start, end));
++    LOG(isolate, SharedLibraryEvent(start_of_path, start, end));
+   }
+   close(fd);
+ }

Modified: head/www/node-devel/pkg-plist
==============================================================================
--- head/www/node-devel/pkg-plist	Tue Nov 19 10:12:00 2013	(r334295)
+++ head/www/node-devel/pkg-plist	Tue Nov 19 10:12:06 2013	(r334296)
@@ -2,6 +2,7 @@ bin/node
 lib/dtrace/node.d
 lib/node_modules/.keepme
 share/systemtap/tapset/node.stp
+man/man1/node.1.gz
 @dirrmtry share/systemtap/tapset
 @dirrmtry share/systemtap
 @dirrmtry lib/node_modules
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-19 10:12:51 UTC
State Changed
From-To: open->closed

Committed. Thanks!