Bug 184294 - lang/phantomjs does not depend on Qt
Summary: lang/phantomjs does not depend on Qt
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-25 22:40 UTC by ben
Modified: 2013-12-11 15:10 UTC (History)
0 users

See Also:


Attachments
file.diff (526 bytes, patch)
2013-11-25 22:40 UTC, ben
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ben 2013-11-25 22:40:00 UTC
As of version 1.5 upstream bundles their own forked Qt and builds statically [1], so the port Qt dependency should be removed.

$ ldd /usr/local/bin/phantomjs
/usr/local/bin/phantomjs:
        libfreetype.so.9 => /usr/local/lib/libfreetype.so.9 (0x802a91000)
        libfontconfig.so.1 => /usr/local/lib/libfontconfig.so.1 (0x802d1e000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x802f57000)
        libm.so.5 => /lib/libm.so.5 (0x80326d000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x80348e000)
        libthr.so.3 => /lib/libthr.so.3 (0x80369c000)
        libc.so.7 => /lib/libc.so.7 (0x8038bf000)
        libz.so.6 => /lib/libz.so.6 (0x803c1a000)
        libbz2.so.4 => /usr/lib/libbz2.so.4 (0x803e2e000)
        libexpat.so.6 => /usr/local/lib/libexpat.so.6 (0x80403e000)             

[1] http://ariya.ofilabs.com/2012/03/the-evolution-of-phantomjs-build-workflow.html

Fix: Apply the attached patch.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-25 22:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kuriyama

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2013-12-11 15:09:18 UTC
State Changed
From-To: open->closed

Committed.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-12-11 15:09:21 UTC
Author: mat
Date: Wed Dec 11 15:09:13 2013
New Revision: 336175
URL: http://svnweb.freebsd.org/changeset/ports/336175

Log:
  Remove Qt from the dependencies, it uses a bundled up version.[1]
  
  While there, convert to USES, and use new LIB_DEPENDS format.
  
  maintainer timeout[1]
  
  PR:		ports/184294 [1]
  Submitted by:	Benjamin Lee [1]

Modified:
  head/lang/phantomjs/Makefile

Modified: head/lang/phantomjs/Makefile
==============================================================================
--- head/lang/phantomjs/Makefile	Wed Dec 11 15:04:33 2013	(r336174)
+++ head/lang/phantomjs/Makefile	Wed Dec 11 15:09:13 2013	(r336175)
@@ -2,6 +2,7 @@
 
 PORTNAME=	phantomjs
 PORTVERSION=	1.9.2
+PORTREVISION=	1
 CATEGORIES=	lang
 MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE}
 DISTNAME=	${PORTNAME}-${PORTVERSION}-source
@@ -12,12 +13,12 @@ COMMENT=	Minimalistic, headless, WebKit-
 LICENSE=	BSD
 
 BUILD_DEPENDS=	bash:${PORTSDIR}/shells/bash
+LIB_DEPENDS=	libfreetype.so:${PORTSDIR}/print/freetype2 \
+		libfontconfig.so:${PORTSDIR}/x11-fonts/fontconfig
 
 PROJECTHOST=	phantomjs
+USES=		gmake dos2unix
 USE_ZIP=	YES
-USE_GMAKE=	YES
-USE_DOS2UNIX=	YES
-USE_QT4=	moc qmake gui webkit rcc
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
 do-build:
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"